From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11F0C429CE8 for ; Tue, 14 Jul 2026 21:39:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=192.198.163.13 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784065201; cv=fail; b=n85fyoBvm/oyTKkZ9tVtvzGbUYtGPF3RT2sG6XXdCk4yGDD2AEsU+d0MLAqLcEJXQLioUs9qZrWWW261o8NG83wUI+OYNHbc00FsrNIdodu8yysDLwUnXEbv4bnfbIMGM+xRLWtn8bSZZ8uEWZ5SwPJG+Ld/mjU2m4y1DKKpPuM= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784065201; c=relaxed/simple; bh=4oW3oVmJ5rTVdk7UWzTeA2VO3zwqpd8n7XvyzAbJABg=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=CQu7Oot903YzZZp5n9ngH1ansPGBxSgX0zRckbNjClo7NB52cn9wEpTrMASMMqU7wyWbTi+obThpJcXAm1qx98RfOaFaWuP6hwZSveG6erG2S79KQijoX1C9ySWtRcq+o/8jWrcP7XpFNMXzOs5IewaO/pi+kPrBp/qhCbbGQg0= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Eoo3EyMV; arc=fail smtp.client-ip=192.198.163.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Eoo3EyMV" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1784065199; x=1815601199; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=4oW3oVmJ5rTVdk7UWzTeA2VO3zwqpd8n7XvyzAbJABg=; b=Eoo3EyMVMNqLUseg9bslOPV30FK2HIcyvxEF80PPGYs239gbvGmTQmg7 lSWNLP54aVKuqHblOws1eT7Nn1dKK94kuB45VMefvVhvL7b1rsGnCbEBq vemsG+i0fRrSDVa5hrOO5EORgV4agMUAPUsUXk2OxI/+++JyQlodXQKgK 1ZTptVTc+H4Q13/kjKIvzuMN+d+NXGnTAU4OiCiGWWXRCOLs7Tjc5r9+4 4OhLNuPGsRdw7KtW5xeyDm9eJkGgfhf1vIYQ64QEIWxPD9eeWqeyc8j2H 4C590wCAIlLZkhAzpJo6DfNC6bDvGfJw+qmphCOtAyo/N/lbfeyEIl4LQ g==; X-CSE-ConnectionGUID: qJB9QX5GQ92bY5XLNU/14g== X-CSE-MsgGUID: zv6j83b0SbaORLUVztgtjQ== X-IronPort-AV: E=McAfee;i="6800,10657,11847"; a="87241360" X-IronPort-AV: E=Sophos;i="6.25,164,1779174000"; d="scan'208";a="87241360" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jul 2026 14:39:58 -0700 X-CSE-ConnectionGUID: cBJy1ir5Tl6D+oUkYISB3g== X-CSE-MsgGUID: TYaHeH/NRxGSEr68uBkMjw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,164,1779174000"; d="scan'208";a="260275376" Received: from fmsmsx903.amr.corp.intel.com ([10.18.126.92]) by orviesa005.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jul 2026 14:39:58 -0700 Received: from FMSMSX903.amr.corp.intel.com (10.18.126.92) by fmsmsx903.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.43; Tue, 14 Jul 2026 14:39:57 -0700 Received: from fmsedg901.ED.cps.intel.com (10.1.192.143) by FMSMSX903.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.43 via Frontend Transport; Tue, 14 Jul 2026 14:39:57 -0700 Received: from SJ2PR03CU001.outbound.protection.outlook.com (52.101.43.51) by edgegateway.intel.com (192.55.55.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.43; Tue, 14 Jul 2026 14:39:56 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NSAsTAVSu3JEuigtIWYtCaxu/ImITalJFzYp3mkYsZyG3/W1G6zEsPM1Iuj83fSRRRVhMkURwKy0+6RO2rTKd6DmJn+Hxpau+lFEHHEYgtqHMtslfJ3EmlXAGwUD19e0H4OqK1ENTwHtGeXTPWZjPp1lE15Ynbu4JTdEYmCePn+wxcGMDpUL1ZGOKwfQMZ/8dYkF/w7/6VxWpywOTPAM8x71S3fQi9L3HtUxuRCVBZCaBC6thJmX7TEtKdmzKKYRZpbYtRa3s7BF5UkyTpxmtUUWSIv4gVeogR386fDG+OtEGOlEYsAg3WWPw4teJUtK8yjbJ6ksleWwhmbk+4Ue4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7l3aEBvRVm4hj2Rjku0Ots5z4nF/dZ2oyiwBDzygscw=; b=kgVtct6LhYb1w87eoodGt0CbCZpOkyU3U//oxV1NjtRfK7/VP0PWJJm9Zs0fUiywJYb0/V3l8bQxtj/CmZSPKOrqXlPLXpbPi6VB/YhKEliZdJdlJbC+pH/TWE52u0SpsTR8AzZLdZi1cPUQT/OqFFX4j13FpawfeW6iGjZer8JW2Lhrgar7DRZrx6Ay7DfsbaakMDhDQhMUKHkUGT8K/8M8CZDpLDHWDC6A3Pilb+La64ws+DVTPIUPePy5lybUsMI5wSKvrlK5qYBka+V7Vj+Me0SAxvQS4w+U2awYZQWzWLr2a3ZWAnI4nZsSROwKT+eQNF0Ll9M7r16vIBbdDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SJ2PR11MB8370.namprd11.prod.outlook.com (2603:10b6:a03:540::20) by CH0PR11MB8167.namprd11.prod.outlook.com (2603:10b6:610:192::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.202.18; Tue, 14 Jul 2026 21:39:49 +0000 Received: from SJ2PR11MB8370.namprd11.prod.outlook.com ([fe80::b6cf:ce77:3cdf:7cc]) by SJ2PR11MB8370.namprd11.prod.outlook.com ([fe80::b6cf:ce77:3cdf:7cc%5]) with mapi id 15.21.0202.014; Tue, 14 Jul 2026 21:39:49 +0000 Message-ID: Date: Tue, 14 Jul 2026 14:39:46 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [RFC] mpam,x86,fs/resctrl: Generic schema description Proof of Concept To: "Chen, Yu C" CC: Ben Horgan , James Morse , "Dave Martin" , Babu Moger , Drew Fustini , Fenghua Yu , Borislav Petkov , Thomas Gleixner , Dave Hansen , Peter Newman , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , "Luck, Tony" , References: <9b81527e-22e9-4cad-ac32-773f5c9d81e7@intel.com> <68b1b8db-4ffd-4e3b-a097-3bade368ab73@intel.com> From: Reinette Chatre Content-Language: en-US In-Reply-To: <68b1b8db-4ffd-4e3b-a097-3bade368ab73@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MW4PR03CA0356.namprd03.prod.outlook.com (2603:10b6:303:dc::31) To SJ2PR11MB8370.namprd11.prod.outlook.com (2603:10b6:a03:540::20) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR11MB8370:EE_|CH0PR11MB8167:EE_ X-MS-Office365-Filtering-Correlation-Id: e4ab3603-14f5-46fc-63f3-08dee1f06e30 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|376014|7416014|366016|1800799024|22082099003|18002099003|4143699003|11063799006|56012099006|3023799007; X-Microsoft-Antispam-Message-Info: nto9qS27JtE5tWL9qqbFuxz5/8sLBId4PGWrSnC6ZQaaNV7Cihsn7Zc20TAr8hgaVEWK6mtoZ04tnl11aYqv4rAPAFEZpYGrHzy3trvsM9xpPI4+8BTGz6a8T9Ay4FlKOucO83V2rwIgNfntQZTKDC/+5Lug6pxI8W6Y+YmwbG3ezNYfJ8zNGNMh1MpPGukwYM5gasmz/uqEOHWWb6iFT2rUaUXCh9ld8i/6NIiAa7KVXZcu5E+HjWiX/e9lQZiCTiTks5iLk9fAul+djg+53gCdGa/FPTvC4/E6ouS4pejMXEjonexlu46Hje0GWGvGunoiIzIMVE4MA08o3kcj3qBty1XG+2TkzFM59xgQJNW2Nm/qnKU37bYNFv4nDmAR50sFq5asfYErcqj78ZV9WFGKRu/nU+zyYtlZ/8B4v8gteU6D5XO17Fth7ly7EmlaRK/hME9M5ox6osie9Qt+/6rYtnt/MZyAEoi1xzgG4c8mezRjVJZcS6gGGyt583JwM5okVTia+fww9lisgSobuolHzch00G4KbTHp7SkVZ8SxkGcjv7SURf/JDBrh3dl7s7LUR9gqt7PGiQI/OyQu5eoO1Kmz+miQlhxorFZ7JWoU0oyi3YShwzTN6a7HXTLfIX56PQKsvJQNsk+AMSDCugDeLHMVy4uQHZEDIvRS1EQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ2PR11MB8370.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(376014)(7416014)(366016)(1800799024)(22082099003)(18002099003)(4143699003)(11063799006)(56012099006)(3023799007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WEttVWpWdjJvRHhwajJJZnJhNTBTSUtBN0FFQWVieGcwdExna3c5ZWtrMXQ5?= =?utf-8?B?c2NtWlV3RFZoK05aeUJFa2ZuMjVOMVBOZ2RnWlRlSGN5TkNpZ2JOZ29XbDFQ?= =?utf-8?B?S1lLbzhQZjlwbzE2Y1NPaEg0ZW8vMXlMYUJYMWZNdjVLZVA1MDlZSFBNenZW?= =?utf-8?B?b0VjMW0xaHkvRWpqVEptVkJQcGZhbjU3MjNzbTAybGVxZHNCUUpKRDYvbzZu?= =?utf-8?B?L2F2Z0RVVnBLUmxtUTFtVjk4aEFCUEltSzM1VUxSZ2poWkVYbms5Skl5QkM5?= =?utf-8?B?K1kzWllDajNXcFhjdlZGK1JLSm4rWFY4UTZ5MXJ6Ujh6MEJkYjZKUVVZVGhk?= =?utf-8?B?UVZPYzNKMHlWUmhMTnJxZlpPdXQ1b0pnMzhSQjNKOE5PdEhTQVU4M1ovaXdn?= =?utf-8?B?WTJ5QVEwZFQ5MmwxVzFqZXBKWXFQSnhiMjNOa21JMnNFNDBjRzlkS1VVc0lv?= =?utf-8?B?SjhEOUVyaXU3ZThyNWhwNGlDbDdDei9kQldmZGpsM1pWRHRGZjhzSW4xRkRQ?= =?utf-8?B?L205Q3h0dEU2dnYzb3VJRzYwSWM1UEtnMDM5cVJrRFJhbmw1ODNJcGhoUjJM?= =?utf-8?B?Ui81VHJhb3YrT3drSnU3a3A0UlJtamlQRlhLZjhjdXhtTHVVMWNBSGdzbksx?= =?utf-8?B?QUFkQ1RDMVdEM0xQdE9vQnNjdzVyZTI4ZWFjaDNZVWU3RFJ4Tk5tL2toQWtm?= =?utf-8?B?Vi9PY3FnZ251QU1EK1k5S0NMSVR3a25FWTZSSXBWdzI2NUJMTytzbzdwNlo0?= =?utf-8?B?VktCcGZHQnAxdkFIVUJrMlpKdEhJV0krRkNnRWtheDJCd0VvUExMYW5BeTYv?= =?utf-8?B?Qi9IZDRvMC9ZY013SFRDUnVEZnVpUlZ6ZU0vMWFLVHFHbnF2VVJ3VmN2K2tq?= =?utf-8?B?S01sVzBQaTVBMzFRMXlzcU0vdSt2QVB6VktBeXBEc2RPbUc3SHdLOUY1dVNl?= =?utf-8?B?YUFyWThyMkRWZTBQYVFQZ2p1MnBESmc4REp3dFhqamVEYXhmTHcwQ1JrWCs2?= =?utf-8?B?MkNTeFBLaDBEMGp0cHd3Nm1uWm9wc0JSMFJVclFuQlR1NU1PSXpPRjlNek1F?= =?utf-8?B?RFc1amN4V3F1SlJEVzk0ZHRGcGJ5MUdiSERMaFN2WHBKK3NPN0hvaStOeDND?= =?utf-8?B?VG50QU9lWHR2VUlLU0djczF4a0pjS3I2T1c0RG1qbm8xQitIaDdQTUFERVlt?= =?utf-8?B?c0FJcW5RTG9ha1ozSDEwSzh1YkJ6WmE2SlNiZWNwaGpiV3ZHSVhabDdhb1la?= =?utf-8?B?bEdhUlpqdll5aUNucnNYQ2NnWThtckM4b0YzdTk5WGlHL0hQVEhyQjFNK3pk?= =?utf-8?B?Z00zNVZXemhZako4UkxBNUV2Rm45R2tqSmIrTTVyL0lwbXlIcUVZdW5aYmpX?= =?utf-8?B?ZERPaWxBK3hoM0h4dnUydS8yUzh1L3RDd0lQc3VSSndxUVBjeXhYRitIaEt0?= =?utf-8?B?U1RzaExwQjhnWEd3QVlFcjBzSW8yR1hlVVUydm0xUlRxUnNMdUc4VlZUNTZW?= =?utf-8?B?SDhENFB5dWU1NnVpR2NmMjZtL0trSzBDRWkwcVNHenRtNWZyTjVEbmVCcnpu?= =?utf-8?B?eTVZU3J4ZWhNbUEva0RiQWl1WjdwaVYyZGRQdHVrTTRMZGdNU2o5Ti9ZcUZ4?= =?utf-8?B?a0Z2QUg3RXc0dFZjRnNSQ0F4R0lCSm4vWnM2aFBFb2RWb0tQWUhrY0svWnV4?= =?utf-8?B?SEpCODNzNDR0dXBKcFdWK1c2WHUxRXB6MFlBdXU2aHVOV0NNRlhoSGpZNWk3?= =?utf-8?B?Yno0ajFOakw0WGVTSFd5VFc5SUEyRnl2d2dDYU9wa1ZMb1VwczF4YUpmcnVt?= =?utf-8?B?RnBUeUc1d3BBSCtYUnhTbVpwSTJ1MUNaamtGZ2VjYWI2M2FCNlhmT3ZvVmJF?= =?utf-8?B?c1RYa0pkRzMvU1hPTEk0VllaY0xQWnIxcHJHVkVKc0wxc0VRSXBPM3FMOHFT?= =?utf-8?B?NXRIUmNRNjlVcXE5a2F4OW13cVRZakJKSFpjeGh3Q3lSdXNLQjN2M0hHVFpw?= =?utf-8?B?bDBCUWxvamJuNjcyUW83NDkxelVqRElLS0dtTnhZZzllSTZoSGRNTGszTlEw?= =?utf-8?B?L0VsY3dhUEdNazYwUGNSUzBYa2o0S1NYTnc2dCtHWEpBWXY5K1JyUVF5N3Bx?= =?utf-8?B?Qjd0L3NEY01vM29keUI1N1JZajRmSW4xdlFNTklMeXR2Vi9Wd0pCS0F3ckFT?= =?utf-8?B?RHJ5NzE1L05nb3p5OEtudG1DRUtVY0FOZy9jdmhEellCa0hOdEJuS1U5MnRs?= =?utf-8?B?NnUwSWw3a1hRZW9JZWQ2VG9IZFJuRVc4WEg3SUlCT0p2SlNIQVB0QUFDYmFR?= =?utf-8?B?cGorMi8vcWRoODRpbGM1NGNJSnErMmV6R29MM0VIZUorWWpBY2U2YUxoaHlK?= =?utf-8?Q?thjPd6l+jbzsL5f4=3D?= X-Exchange-RoutingPolicyChecked: TCFZ6xYoQTI03y5el1R/C+dOmlqg3BK/O16U/tyCab8C0PuXgZw+uChLp0JvbpSBxB5e+xKG2fbFpZDpNlSd66mIoLHitka2fnyeSoY2YMgqkJtGUVrWKSxX/c70gIkNCvJJE0+aHHcKqslsUXKw9t7XoTTV0WA3RuH2mTcvJvOjn8z9+aY0f9RG/STOvhnOuxcDbDhFcWqyCLC5UpEN9xQxblJvp8GWCwiUOEwino4RlyrksYUm7xuZTOtHxIitzV5W5u1dK9WU6vljoqRqAguwA4te9amj+r8PTWhwM71W7gENN8Uqm8QzQPI2x9Cwr7/+GyT0XgJiOBCXdmZWAQ== X-MS-Exchange-CrossTenant-Network-Message-Id: e4ab3603-14f5-46fc-63f3-08dee1f06e30 X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB8370.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2026 21:39:49.1484 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: V6Wi3G0ROGdcu8DOgWHuv10yV77HmN56KJwfm8H3xw31dNV91KaFMInUTLKYrmS6KDtA7QuZHt6l7K6RjCHijCXPU9UNnQcGna3m27DkZAU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB8167 X-OriginatorOrg: intel.com Hi Chenyu, On 7/8/26 5:56 AM, Chen, Yu C wrote: > Hi Reinette, > > On 6/5/2026 5:42 AM, Reinette Chatre wrote: >> Hi Tony, >> >> On 6/3/26 11:46 AM, Luck, Tony wrote: >>> Reinette, >>> >>> Tiny bug in "mpam,x86,fs/resctrl: Transition resource control to a list" >>> >>>> /* >>>>   * Return length needed to display longest control suffix. >>>>   * Add 1 for the "_" character when control name exists. >>>>   */ >>>> size_t resctrl_resource_ctrl_max_len(struct rdt_resource *r) >>>> { >>>>     struct resctrl_ctrl *ctrl; >>>>     size_t total = 0; >>>>     size_t len; >>>> >>>>     for_each_resource_ctrl(ctrl,r) { >>>>         len = strlen(resctrl_ctrl_name_str(ctrl->name)); >>>>         if (len) >>>>             total += 1 + len; >>> >>> Should be: >>> >>>             total = max(total, 1 + len); >> >> Thank you very much. I squashed this locally. >> > > A minor alignment schemata issue is found when testing region-aware RDT: > [resctrl]# cat schemata >             MB:0=100 >             MB_REGION0_OPT:0=255 >             MB_REGION0_MIN:0=255 >             MB_REGION0_MAX:0=255 >             MB_REGION1_OPT:0=255 >             MB_REGION1_MIN:0=255 >             MB_REGION1_MAX:0=255 >             L2:0=ffff;2=ffff;4=ffff >             L3:0=3ff > > The schemata file right-justified only the resource name in a > max_name_width field, then printed the control suffix afterwards > without padding. Since max_name_width reserves space for name plus > suffix, this left a run of spaces before every line. A small hacky > fix: > > diff --git a/fs/resctrl/ctrlmondata.c b/fs/resctrl/ctrlmondata.c > index 9b51464b66b7..7d517f3457bf 100644 > --- a/fs/resctrl/ctrlmondata.c > +++ b/fs/resctrl/ctrlmondata.c > @@ -521,6 +521,7 @@ ssize_t rdtgroup_schemata_write(struct kernfs_open_file *of, >  static void show_doms(struct seq_file *s, struct rdt_resource_final *f, >                       bool print_ctrl, int closid, struct resctrl_ctrl *ctrl) >  { > +       char name[20]; >         struct rdt_resource *r = f->res; >         struct rdt_ctrl_domain *dom; >         bool sep = false; > @@ -529,11 +530,13 @@ static void show_doms(struct seq_file *s, struct rdt_resource_final *f, >         /* Walking r->domains, ensure it can't race with cpuhp */ >         lockdep_assert_cpus_held(); > > -       if (print_ctrl) > -               seq_printf(s, "%*s%s%s:", max_name_width, f->name, > -                               resctrl_ctrl_is_default(ctrl) ? "" : "_", > -                               resctrl_ctrl_is_default(ctrl) ? > -                                "" : resctrl_ctrl_name_str(ctrl->name)); > +       if (print_ctrl) { > +               snprintf(name, sizeof(name), "%s%s%s", f->name, > +                        resctrl_ctrl_is_default(ctrl) ? "" : "_", > +                        resctrl_ctrl_is_default(ctrl) ? > +                         "" : resctrl_ctrl_name_str(ctrl->name)); > +               seq_printf(s, "%*s:", max_name_width, name); > +       } >         list_for_each_entry(dom, &ctrl->domains, hdr.list) { >                 if (sep) >                         seq_puts(s, ";"); > diff --git a/fs/resctrl/rdtgroup.c b/fs/resctrl/rdtgroup.c > index c1aac0dcd332..916bf6a8eab4 100644 > --- a/fs/resctrl/rdtgroup.c > +++ b/fs/resctrl/rdtgroup.c > @@ -1654,6 +1654,7 @@ static int rdtgroup_size_show(struct kernfs_open_file *of, >         struct rdtgroup *rdtgrp; >         struct rdt_resource *r; >         unsigned int size; > +       char name[20]; >         u32 ctrl_val; >         int ret = 0; >         u32 closid; > @@ -1693,11 +1694,11 @@ static int rdtgroup_size_show(struct kernfs_open_file *of, >                 type = f->conf_type; >                 for_each_resource_ctrl(ctrl, r) { >                         sep = false; > -                       seq_printf(s, "%*s", max_name_width, f->name); > -                       if (!resctrl_ctrl_is_default(ctrl)) > -                               seq_printf(s, "_%s:", resctrl_ctrl_name_str(ctrl->name)); > -                       else > -                               seq_putc(s, ':'); > +                       snprintf(name, sizeof(name), "%s%s%s", f->name, > +                                resctrl_ctrl_is_default(ctrl) ? "" : "_", > +                                resctrl_ctrl_is_default(ctrl) ? > +                                 "" : resctrl_ctrl_name_str(ctrl->name)); > +                       seq_printf(s, "%*s:", max_name_width, name); >                         list_for_each_entry(d, &ctrl->domains, hdr.list) { >                                 if (sep) >                                         seq_putc(s, ';'); > > > > And it becomes: > [ resctrl]# cat schemata >             MB:0=100 > MB_REGION0_OPT:0=255 > MB_REGION0_MIN:0=255 > MB_REGION0_MAX:0=255 > MB_REGION1_OPT:0=255 > MB_REGION1_MIN:0=255 > MB_REGION1_MAX:0=255 >             L2:0=ffff;2=ffff;4=ffff >             L3:0=3ff > Thank you for the report and the proposed fix. I'll look into making the fix generic. Reinette