From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752454AbdJ0S0X (ORCPT ); Fri, 27 Oct 2017 14:26:23 -0400 Received: from mail-cys01nam02on0072.outbound.protection.outlook.com ([104.47.37.72]:7555 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751393AbdJ0S0W (ORCPT ); Fri, 27 Oct 2017 14:26:22 -0400 Subject: Re: [PATCH] init/main.c: check for null pointer before calling initcall To: Thomas Gleixner Cc: Abderrahmane Benbachir , linux-kernel@vger.kernel.org, mingo@kernel.org, akpm@linux-foundation.org, keescook@chromium.org, jeyu@redhat.com, rostedt@goodmis.org, mhocko@suse.com, viresh.kumar@linaro.org, thomas.lendacky@amd.com References: <1509122847.11787.5.camel@polymtl.ca> <7fc6e471-3ff9-83ea-f0c8-638959395494@caviumnetworks.com> From: David Daney Message-ID: Date: Fri, 27 Oct 2017 11:26:14 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [50.233.148.156] X-ClientProxiedBy: SN4PR0701CA0002.namprd07.prod.outlook.com (10.161.192.140) To BN6PR07MB3490.namprd07.prod.outlook.com (10.161.153.29) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 42f305f7-dde9-44d7-74c9-08d51d6837ae X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(2017052603238);SRVR:BN6PR07MB3490; X-Microsoft-Exchange-Diagnostics: 1;BN6PR07MB3490;3:dSnH4WskUn6sxdePldWYnVduE4X/+M/a60i69c/vazdNqDCUaiEsXwNKWaL+to0IuVsIN/oe6Os7/cIWVzo4K8VC19bjiBOEedMWerIx7Ojay8kd3veRjNP/GJaTqAsRwFlgacOnF9UKrmkms6dA0gFNCDkB2JzRaxfBkkhQWzeKBxiW0JnxpJZb/zAu+U1HhrQikQ3lfpmUeReebqaopTGymrDYnoN0LVMWKatddWEa71wF/mrUF41OeqROivPz;25:hcWsmSeonUyqQWML0jQceefO3a7GKvnKhlY2omTgSXS+nR0KmQSSrj4O7w4uWNWxhJWy4Lq/1IjvhGM1Z80PdTPVK5sAZurfex+NFwrr7lPcWY8ajCxvCFHssgWRGZb9JVypcFsyGdcwSZRXqsM04xvz5KgMSyxwqK1vxXLzfuv4ADhAIj6LfmmgrlA8P/WgefRW68nbTj6M0ECFR3sB52qvGhPkz8klIsdBtufuS239nroh38oQUaHV0o30evnvtlA5weycpbRsdfR3BL1oiPUNXuwjxr4D3VVicEQiQIv1LHaIx2kC09Xz8F7PSbvf+5GLhOux+XgqzAcZ8LVKVQ==;31:RjVp0EzxowNIyLD3UrZSzjT0ppIuN4V0FBXJwASydRtFjI557utqFY4hYBdJl/Ehuu6WDGsRfZi/zRwbSLPStNQ7fm3jeVFwrbFX3ncoHMcxve3ZCCpBnqzTUnr+A4htL+U8fLr2vH3xNw1iV314GyVQ1YvJmrEkx/DIYvilFz/WNy/HFgfD5vq9OWllcuDmnittn2wqvSDgeZCDl7/VkgTKaNzWHXhF9KfthbwcTFE= X-MS-TrafficTypeDiagnostic: BN6PR07MB3490: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=David.Daney@cavium.com; X-Microsoft-Exchange-Diagnostics: 1;BN6PR07MB3490;20:ebiGF/5Wcng417CnQW1QWENar7gSXqUT0XHcWkDSbM6FvuY14t2q+xPLwVDTR0iGlhhmVFfd3lRFkhWFmuMP8EoGL6H0TfB5QPRnQK1XkcFwnBgfvlo+DymwPLlC86F6d2mD+KyBZtstdUJZTAXBtRV4NmifNB6//XXETgY5woL4tc8dfLGK0IfgDG4HRLyLtb3bqzljixW2YYdIV7lS4Y5clZNrg1QY+I/6y35RWAPGlaNHRGB+blZutWGxTKeuzL0jzexCd5P3ZpXbg1tSXHqyZfdRO2z6K8vxvf3BkeV5mGcm0HrK5ynWtH6j0mbrCBTFkjlshjLYGphXnhIgT47Ij6k1t4FkUhWL6s44TJT+VTrsms+93iNtuW38f3wKZ960Vh/W9HlnQB1PqORZTbqXJ2lbxD3rm+8XJVqPJ7Y5npvSm0BntG+zBdof7Inwb3/RZFdXc1wXNnpmy6nKsu5NQbsW0E0XC+2OuK0GuAntBrqNCQZhvCYCDmmF9A4iCdheqgOYQdKnopkkWCo3VZrutSykE/w1/rwRUfX5962xpblNNmltUfBaXtm2Bb/fVmuKtukB16V4j0kO2pub8ctmyQOz2J80NhJquDxVx9s=;4:WIAHiI9QwkWybck8HeNHRSKZF262w7yU3opdL1ViuHWWgU5kbris4dDgAY49aOlZaT0QHofKjxr6uaa+oXFKSf3oOoOsgHz7FK46WhOVF+56yFkEhOp8FR432DaUGjtvywqUdl6yEuYL+ukP7rB0YDlVGu5M7JlZlp6XwIE+210AXQ6yi391b0pzQnyVX/yS2Z2cHBt3H8zFs3LPUc1Xb9YVsNXvdBleVsi9gRYQJaakg5R3S0C7dAyu6j9GpUSUzkd5gtEfEUHTT78f7B3rE6FZ2W9O9gWwbz7mU+DyYYk= X-Exchange-Antispam-Report-Test: UriScan:(190756311086443); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(10201501046)(3002001)(3231020)(100000703101)(100105400095)(93006095)(6041248)(20161123560025)(20161123558100)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BN6PR07MB3490;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BN6PR07MB3490; X-Forefront-PRVS: 0473A03F3F X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(346002)(376002)(199003)(189002)(24454002)(54534003)(189998001)(54356999)(2906002)(76176999)(66066001)(33646002)(53416004)(106356001)(305945005)(7736002)(53936002)(53546010)(47776003)(65956001)(8676002)(229853002)(65806001)(81166006)(5660300001)(478600001)(6506006)(69596002)(97736004)(4326008)(68736007)(230700001)(8936002)(81156014)(65826007)(316002)(58126008)(8666007)(105586002)(6666003)(42882006)(50466002)(2950100002)(101416001)(6916009)(3846002)(50986999)(6512007)(6246003)(23676002)(6486002)(25786009)(36756003)(31686004)(72206003)(83506002)(7416002)(6116002)(31696002)(64126003)(16526018);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR07MB3490;H:ddl.caveonetworks.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjZQUjA3TUIzNDkwOzIzOjU2UW5iVllWUlVpTGtadzRxa0x4MThtU0tm?= =?utf-8?B?L2JEMjdSdVQxdU00WUwyUm8xeWticmh4czBBaStOL05QaTZvR1Y2NlNpUDlm?= =?utf-8?B?bWlTN01kYi9RS2hJNWc3QkdkdE0rMkV2VlRqaGdYNjVETXEzZzZoYzliY0Vx?= =?utf-8?B?RmpzcDlvVWZEOGpYOGQyYzZGTUdpOGZVd1pKS2NhMWIrNUxWcDNReklNWVNw?= =?utf-8?B?T0kwYmRMUTM5SGFXUHdPb2tNREJMZndoTElQNWN6a210M2lqY0cvWWIrbEph?= =?utf-8?B?RVVERTZLcmIvUnpZR0pZUWg1VHdnaXhab3dpODJHd2g1ZUw1cGQvNTVVc0pE?= =?utf-8?B?VUxuaVdkL0VONjFUUm5SL3RBSXp6V0RTRE9Ld3lNYVAvWTl5cWh6MTJXQ1JE?= =?utf-8?B?NFpKQ3hLNnlYejlyNTl3Q2hSVklSeWFkaTErZlBqdmRXQ1R3d1NaL1hpYTN1?= =?utf-8?B?a2NnUWt2Q2Fjc0JFbnVYczRJSzhtd05sb0g5eGpuUVFjajdrNkN6WlJGdlRt?= =?utf-8?B?WngrQW1EUEF5c0gwQTRZQ1lwWGwvVkFBak5FZGs2dWs3eDRYNGNuWWY3VEFB?= =?utf-8?B?SXRnSTdEM3praWx5MXpBTkhjaVl1U1RpbHRMb3VUV09kWlJVOXBzVnNYQVU0?= =?utf-8?B?S1Z5anRkTFNRQnhpMjE2R0NUQmdTZ2k1RThHWSs5SzgvQkNxWmtyYWhZcU9E?= =?utf-8?B?OUlROTUzZzlxWVFMM2h2UWZWUWZ5K0xkdC9VZUpBSC9KUlAyUW4yVW9mb0U0?= =?utf-8?B?b0g4b0xMbnV0YmtWTFFLdEpEQm5MVU1mN2tLWTk2Uk5QemhFckxnOHJ3L2Q2?= =?utf-8?B?Q3EreWNqZmw2TlE3Z0tVcksxRjJINzVaVGdjUjRlTFBSUDQ2NFpXT00zNExT?= =?utf-8?B?QytJU00zUWRwd2dNd2RKVHBsNkg2MDNKUFg3ODdwaU9jaFlDVkZSZWh3eExn?= =?utf-8?B?RU9hUzExMC9KUjAvZk4vbStLbGVkL0xSSW9tdlpBZjVYbERWdmJkaFNrOFVM?= =?utf-8?B?bjVmRDUwWk1pamY4S1lxVS9iY2k1Y1lmcFExWlk0SVA4NGlPdzFXRjV4Vnln?= =?utf-8?B?cm41bWZ4MVBwMEZ2aFU0d2E3Vk5FYUlHYkV1WGJId0YyNlUzRmtUU1JOTXk0?= =?utf-8?B?OXE4bVdubGNKMTdRK1E2VWVIL2hMYkMrV1RkQWJKdTIwSVRraW5vbTloc3F2?= =?utf-8?B?NHArdFQ2MXkrSjd5cUJvL2RVM3loVEptRTcwK2h6eFdpTTM5a2pOdUNOWmxo?= =?utf-8?B?L0o3eTE3NjdzWG5qVm9LU1VCY0JUanU2OHl5YnlNWFhIU3lzUFp6aGY3VTJj?= =?utf-8?B?NGVQS04xQ1pjdXZkdTNVOTgrWjYweGoyR2tJcEp0WmkxejZWMVBDNlA1L3oz?= =?utf-8?B?Ukw1RHYzV21XNDliT2ZnVEJzSXl6VjdjR3NjUWhXNENsT1JmcDdyVmVZVWFx?= =?utf-8?B?SmV4Q0tVVHpjS3NlVkdQam5KNFQ1OFJNUnFacC9FNG83WnQyclZnejFLemgy?= =?utf-8?B?dDVhNDhERTJPTmVzemYzdWxiQWIzQ0Z5bkRuWFpENVZFYTNZcmNiRzZGWmcv?= =?utf-8?B?aElrd3lBTWY1dzR5RGlVbzVQRkxxUXBVajVyQi92VCtIQnFickMyRlZOSmU3?= =?utf-8?B?RjVHSkpNclNxQ2gxUDduSmJnMGVFMEIxVStCbVpOVVhWZENndWEvYlAwd211?= =?utf-8?B?NkVOcFBHQXNkVzVwTTlDUm1QNEg4R3dRMExTK2ljMkVidEpYcW5NRzJMRFpi?= =?utf-8?B?Q1lOQndIWkNaSzUxcUN2RVBQWkVFMTZpMjgwKzBYTkZXSTlJd3lKN1JSRUFJ?= =?utf-8?B?WjNEbDQ4MHM3UTM2bjRxMG50dXVOd1E1dGNlVnJqR3hWUi9Pb2tFb3dFdzhw?= =?utf-8?B?eDR2cnZVaTV0dzJ1Ukt4aTlpT25ZM284SXdKUXJYVk1jelJzOERCanI1ODR1?= =?utf-8?B?U05rQ0dia1FBPT0=?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR07MB3490;6:tgpPOXUZa+L2UkIdmeo8AzPh7Iqzl9JLixhaMSve6U2OkzinnIDnaP2W6pkiZYfr3/2Pq2pDNTB+yw6GMboMEpBQsuFAhdsXox0EIEMeJpCN9Xs/ukBRUOlOag8Lqc4N3EPfCUSJQGMP+83A+OrVikZjpiYnc2lWVnzY0qi4CUIbKj7quIu41SO2cbRSrKetPU8wbDqaHX8zGE9v4/7U1KJ5vwv0+1yXJfHKWXmFi0e7pXdeXrIsvN8xYTDxsIlvkWTlLkwW4fhvxUtiT4VZZj1ihBJrThyHtbQbFO5Smz1yIywmKdjaPBLHxzvyxO631YRl9b6sQEVATCu6YB5GIQ==;5:CiBNa+zeVpgIR817wutBCxyeqkWjAj/RyEf9wOtzmV8zMgADMBg94egsDeTE7+NaPObgaJGC7GTIE+7w4Ez+vR/5PMWEo1ZlQMOtkXc5mW+NYcgM4GPiLFAtIxGhLm/7xUyb2MAWcI0f7qGC2TUUWA==;24:y0XOwuBnduEfbTah55MUh6dXZScSRYsV2G4YwwVEnqlQ0WcDZ5HM4g4zZeEoVgtpM8a78JAhu2lF9UFgkGpOSXPUllXNRJcfQaJ7w8ATW+E=;7:2Yx/cSSWhoYxA9PKLsx4SHdGxWQqZY8gq3Qps6lpXLhK2MurKMmT62TVY1ZtA6l/i36cCNt7V62dPYU6dX46/3q2E2Cd9p8YtlQ9NwG+LRoZjqZtLxT2bhSDq7Ik2ODN0dtCn2eGqyRE3N7nv3fpxC+A2s4rkdOqDj4R3PeZ1ZHZLwU2d/94zQzIFPyP1IPwwnUfLiOsyfeIBI33h80mH+xl2vDXMO9/mIg/H4emduM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2017 18:26:17.7027 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 42f305f7-dde9-44d7-74c9-08d51d6837ae X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR07MB3490 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/27/2017 11:22 AM, Thomas Gleixner wrote: > On Fri, 27 Oct 2017, David Daney wrote: > >> On 10/27/2017 09:47 AM, Abderrahmane Benbachir wrote: >>> Simple check to prevent kernel panic when initcall does not exit >> >> Interesting, under what circumstances do you observe the panic? >> >> It would be best to include this information in the patch changelog. > > device_initcall(NULL); > > might do that, but then it rightfully crashes on boot. > That was kind of my point. The module loader case already checks for a non-NULL pointer, and any NULLs in the in-kernel initializer tables would indicate a bigger problem that should be fixed instead. David Daney