From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751186AbdA3J6f (ORCPT ); Mon, 30 Jan 2017 04:58:35 -0500 Received: from mailout3.w1.samsung.com ([210.118.77.13]:8835 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750997AbdA3J6C (ORCPT ); Mon, 30 Jan 2017 04:58:02 -0500 X-AuditID: cbfec7f1-f793f6d000007796-be-588f0e25012b Subject: Re: [PATCH v2 0/8] Pad retentions support for Exynos5433 To: Krzysztof Kozlowski Cc: linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sylwester Nawrocki , Linus Walleij , Tomasz Figa , Lee Jones , Bartlomiej Zolnierkiewicz From: Marek Szyprowski Message-id: Date: Mon, 30 Jan 2017 10:57:55 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-version: 1.0 In-reply-to: <20170127194612.44dmadsqw6vv5f23@kozik-lap> Content-type: text/plain; charset=utf-8; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrBKsWRmVeSWpSXmKPExsWy7djP87qqfP0RBtf+G1tsnLGe1WL+kXOs FufPb2C3uP/1KKPFlD/LmSw2Pb7GarF5/h9Gi8u75rBZzDi/j8ni8Jt2VotVu/4wOnB77Jx1 l91j06pONo871/aweWxeUu/Rt2UVo8fnTXIBbFFcNimpOZllqUX6dglcGb/f/2cuuCtccXxb J1MD4zf+LkZODgkBE4lfX2+wQthiEhfurWfrYuTiEBJYyijx/203E0hCSOAzo8TrK9wwDc3f 5zNBFC1jlDi4+iULhPOcUeLR2j6wDmEBR4k51zvYQWwRAU2J63+/s4IUMQv8Z5LYMmsqWIJN wFCi620XG4jNK2AnMXXfKhYQm0VAVeJd/35GEFtUIEbi9by/7BA1ghI/Jt8Dq+EUsJA4/+Ql WA2zgJXEs3+trBC2vMTmNW+ZQZZJCJxil9j35guQwwHkyEpsOsAM8YKLRMv5tUwQtrDEq+Nb 2CFsGYnLk7tZIOx+RommVm0IewajxLm3vBC2tcTh4xehdvFJTNo2HWo8r0RHmxBEiYfE0r/X mCDCjhLzztZCwucUo8TM38eZJjDKz0LyzSwkH8xC8sECRuZVjCKppcW56anFRnrFibnFpXnp esn5uZsYgenn9L/jH3cwvj9hdYhRgINRiYf3hnBfhBBrYllxZe4hRgkOZiUR3nU8/RFCvCmJ lVWpRfnxRaU5qcWHGKU5WJTEefcsuBIuJJCeWJKanZpakFoEk2Xi4JRqYFwU3/1y+4LcH8ek lB+qux/SceizyVpf0RBlqm1dlDvv0vGQ52dZv537O+lRhuaDG1XJz/59/jhPqVWes+1J9+7K 9A9iEqnqfV7ZE40mxTLvjerb6s3Ab1ZypMzyQaac98zzYncLv6t+yuj6dWHNizfT8z//mcjW LWyUse/z/H05Wduf+t3T/a/EUpyRaKjFXFScCAC+ivcZOwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrNIsWRmVeSWpSXmKPExsVy+t/xy7oqfP0RBr92MllsnLGe1WL+kXOs FufPb2C3uP/1KKPFlD/LmSw2Pb7GarF5/h9Gi8u75rBZzDi/j8ni8Jt2VotVu/4wOnB77Jx1 l91j06pONo871/aweWxeUu/Rt2UVo8fnTXIBbFFuNhmpiSmpRQqpecn5KZl56bZKoSFuuhZK CnmJuam2ShG6viFBSgpliTmlQJ6RARpwcA5wD1bSt0twy/j9/j9zwV3hiuPbOpkaGL/xdzFy ckgImEg0f5/PBGGLSVy4t56ti5GLQ0hgCaPEmTV32SGc54wSzY09LCBVwgKOEnOud7CD2CIC mhLX/35nhSg6wyjxbv50RhCHWeA/k8TJN5cYQarYBAwlut52sYHYvAJ2ElP3rQKbxCKgKvGu fz9YjahAjMTLPRBxXgFBiR+T74HZnAIWEuefvASrYRYwk/jy8jArhC0vsXnNW+YJjAKzkLTM QlI2C0nZAkbmVYwiqaXFuem5xUZ6xYm5xaV56XrJ+bmbGIERue3Yzy07GLveBR9iFOBgVOLh vSHcFyHEmlhWXJl7iFGCg1lJhHcdT3+EEG9KYmVValF+fFFpTmrxIUZToCcmMkuJJucDk0Ve SbyhiaG5paGRsYWFuZGRkjjv1A9XwoUE0hNLUrNTUwtSi2D6mDg4pRoYu6cuz/QoWpawWCxQ oPaisE7vfIZDxScu//ststZk9Ybyq7/cZZ7485nz1HlwCVXo3bDoMXhZcikg0rXw4/8bNTv2 RrPzye2VM3q0/e4E5RevjxzQevrU7CbPjaXXTh+7k8oezLAvXZA1+LOArOOnwz5Zy/rrF65u ClscfvJaySX91Pe14aytSizFGYmGWsxFxYkA1DZd794CAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170130095757eucas1p2e0b8f2f57194b709b5dbb296a1e7798e X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?TWFyZWsgU3p5cHJvd3NraRtTUlBPTC1LZXJuZWwgKFRQKRs=?= =?UTF-8?B?7IK87ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?TWFyZWsgU3p5cHJvd3NraRtTUlBPTC1LZXJuZWwgKFRQKRtT?= =?UTF-8?B?YW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170126083401eucas1p20b4794fe46ccf2189bf734f0d8e3c536 X-RootMTR: 20170126083401eucas1p20b4794fe46ccf2189bf734f0d8e3c536 References: <1485419634-28331-1-git-send-email-m.szyprowski@samsung.com> <20170127194612.44dmadsqw6vv5f23@kozik-lap> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, On 2017-01-27 20:46, Krzysztof Kozlowski wrote: > On Thu, Jan 26, 2017 at 09:33:46AM +0100, Marek Szyprowski wrote: >> This patchset is a first step to add support for all power domains on >> Exynos5433 SoCs. This patchset contains patches for Exynos pin control >> driver and Exynos LPASS MFD driver, which are needed to make the >> platform ready for adding power domains support. >> >> Patches in this patchset depends on each other. They are order in such a >> way to make the changes bisectable. >> >> Patch #3 has runtime dependency on #1. >> Patch #5 has runtime dependency on #3. >> Patch #6 has runtime dependency on #4. >> >> This patchset also directly depends on the "Move pad retention control to >> Exynos pin controller driver" patchset: >> https://www.spinics.net/lists/arm-kernel/msg556074.html >> >> Patches have been generated on top of linux-next from 25th January 2017. >> >> This is a part of a larger task, which goal is to add support for power >> domains on Exynos5433 SoCs / TM2 boards. All patches needed to get it >> working have been pushed to the following git repo: >> https://git.linaro.org/people/marek.szyprowski/linux-srpol.git v4.10-next-tm2-pd >> > I tried your branch above on Odroid U3 and it fails to boot. > next-20170125 works fine. exynos_defconfig, booting from microSD. > > Board hangs (silently) on: > [ 2.283437] usb 1-3: new high-speed USB device number 3 using exynos-ehci > [ 2.473786] usb 1-3: New USB device found, idVendor=0424, idProduct=3503 > [ 2.474856] usb 1-3: New USB device strings: Mfr=0, Product=0, SerialNumber=0 > [ 2.482656] hub 1-3:1.0: USB hub found > [ 2.486017] hub 1-3:1.0: 3 ports detected > [ 55.037205] random: crng init done > > Full log attached. Huh... Reproduced. This is another reincarnation of the prepare_mutex in clock's core related deadlock, now caused by Exynos Audio Subsystem clock's driver, Exynos I2S driver and Samsung SDHCI driver. It looks that this issue becomes even more problematic now and urgently needs a proper fix, because it gets really hard to make more workarounds everywhere else. For now I will probably drop Exynos AudioSS patch from this series and send a revert for commit 9b41da80e09128574f09bed8dc5a5fc6f72a8239 ("ASoC: samsung: i2s: Provide I2S device for registered clocks"), which has to wait until the deadlock gets proper generic fix. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland