From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57BB0C433EF for ; Tue, 1 Feb 2022 15:10:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240102AbiBAPK5 (ORCPT ); Tue, 1 Feb 2022 10:10:57 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:43977 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234200AbiBAPK4 (ORCPT ); Tue, 1 Feb 2022 10:10:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643728255; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Xahi6KlHV6F4VQ/xZVlvC1YTaLt1tqgz8laoIFbavo4=; b=RqOx28FSGCcq0Xo7JydAaKelt2OOOep3/VV0ZkRy3ZSDdSHA8w1FD6Gr/iGMzfpGq5QxXo CW3uhPUHNRi2FKg1uqbo4R44rN9LkW8ou/lrw2Lqx3zY/0lt5HeIkayrgo3boVNrFw0b99 7hTEIVHWEiF1iOBDMf2pWV+AzfEQdBU= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-166-sDGJIDrxOLOFZBnLpga0Cg-1; Tue, 01 Feb 2022 10:10:54 -0500 X-MC-Unique: sDGJIDrxOLOFZBnLpga0Cg-1 Received: by mail-wm1-f72.google.com with SMTP id i132-20020a1c3b8a000000b0035399bb7e85so1523151wma.4 for ; Tue, 01 Feb 2022 07:10:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Xahi6KlHV6F4VQ/xZVlvC1YTaLt1tqgz8laoIFbavo4=; b=yphZvIBqGr/lX58VND3wQjVQRRLfKH5vTed+8h4Wg+4NXrBrj/9MhJfBFDEAF541T/ u6xS+a5J+5cy4URvp7+m3JcYvl+yppHe7/K8eeKSe797+b7lu38wPclN0/Wev9Wki0zj /DClMZMuooJJW1pVboJ1It/ZXJIxwqLaO3ZN/pBQpqmC7WHkXR+RdryEYQ7n/THFUq4B pAHCbmBUUuB3N3DWtCw6ckymmk9rPlVCb7gks6Pq3CLFJNDOgH1WA52S/QpSmCpLxwmo cqMw1BMtwmpqxRhto9v5eHZXPfjdf1yn88tzn3Q2Rj64YJNXoEeJ5l5ShARqraMBpXZe rD4A== X-Gm-Message-State: AOAM532o+at+g+kQg0QN8J1LDlw0c+XG+insEzT8Bcc9xjCKoray7FB0 PanSCTAOKDsV83n8ej6igmxykXLK6gF6hO/6L37Si+dtsrKS5XWM405n99BudCVueZIFDQDcIgd AOh210wGGPvZRi42bZMdKF+un X-Received: by 2002:a05:6000:1a8c:: with SMTP id f12mr11663237wry.153.1643728250668; Tue, 01 Feb 2022 07:10:50 -0800 (PST) X-Google-Smtp-Source: ABdhPJxdwGp2Pak+qnkxqFSHlJ5WHAuF3l8gqYjbIl9n8aNA5CLl+rlgxDBFzggA+hPhyEXVYtJztA== X-Received: by 2002:a05:6000:1a8c:: with SMTP id f12mr11663221wry.153.1643728250430; Tue, 01 Feb 2022 07:10:50 -0800 (PST) Received: from [192.168.1.102] ([92.176.231.205]) by smtp.gmail.com with ESMTPSA id x4sm15296308wrp.13.2022.02.01.07.10.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Feb 2022 07:10:50 -0800 (PST) Message-ID: Date: Tue, 1 Feb 2022 16:10:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 3/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays Content-Language: en-US To: Andy Shevchenko Cc: Sam Ravnborg , linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, Daniel Vetter , dri-devel@lists.freedesktop.org, =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= , Geert Uytterhoeven , Maxime Ripard References: <20220131202916.2374502-1-javierm@redhat.com> <3aac291a-b30e-2775-336f-66dd08d634e2@redhat.com> <9ddd8a8c-4aa9-bc4a-5637-66197a7342d1@redhat.com> From: Javier Martinez Canillas In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/1/22 15:02, Andy Shevchenko wrote: > On Tue, Feb 01, 2022 at 12:45:53PM +0100, Javier Martinez Canillas wrote: >> On 2/1/22 10:44, Andy Shevchenko wrote: >>> On Tue, Feb 01, 2022 at 01:14:22AM +0100, Javier Martinez Canillas wrote: > > ... > >>> The problem with no backward compatibility means that removal of old driver >>> makes users unhappy since DT is kinda ABI and we do not break it. >>> >> >> I think that's the crux of the issue. Do we want people to update their >> kernel but using their existing Device Tree and be able to switch to the >> DRM driver ? >> >> My take is that we should and that's why I kept the backward compatibility. >> >> Maybe we could do that in the meantime and at some point introduce new DT >> bindings (with a different compatible string) that would use the latest >> and greatest conventions in DT ? That seems to be a good compromise. > > I have over-read in this discussion that current binding is not fully > correct from hw perspective. If it's indeed the case (and I believe it's), > then probably we should come with brand new driver with ssd130x name and > incompatible bindingas (*). > > Otherwise in this driver we continue to be incorrect in them. > See the comment from Geert. I believe we should use the existing binding. > *) But even though I think it would be good if you take the old one under your > maintainership. > Sure, now that I got familiar with the ssd130x devices, I'll be happy to help with the ssd1307fb driver maintainership. Best regards, -- Javier Martinez Canillas Linux Engineering Red Hat