mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: <Eugen.Hristev@microchip.com>
To: <Ludovic.Desroches@microchip.com>, <Nicolas.Ferre@microchip.com>,
	<alexandre.belloni@bootlin.com>, <robh+dt@kernel.org>
Cc: <devicetree@vger.kernel.org>, <Tudor.Ambarus@microchip.com>,
	<linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<Codrin.Ciubotariu@microchip.com>,
	<Cristian.Birsan@microchip.com>
Subject: Re: [PATCH 1/5] ARM: dts: at91: sama5d2_ptc_ek: fix sdmmc0 node description
Date: Thu, 2 Apr 2020 09:20:16 +0000	[thread overview]
Message-ID: <b4fe14af-a812-8798-187e-704541a6a75f@microchip.com> (raw)
In-Reply-To: <20200401221504.41196-1-ludovic.desroches@microchip.com>

On 02.04.2020 01:15, Ludovic Desroches wrote:
> Remove non-removable and mmc-ddr-1_8v properties from the sdmmc0
> node which come probably from an unchecked copy/paste.
> 
> Signed-off-by: Ludovic Desroches <ludovic.desroches@microchip.com>
> Fixes:42ed535595ec "ARM: dts: at91: introduce the sama5d2 ptc ek board"
> Cc: stable@vger.kernel.org # 4.19 and later
> ---
>   arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts b/arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts
> index 1c24ac8019ba7..772809c54c1f3 100644
> --- a/arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts
> +++ b/arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts
> @@ -125,8 +125,6 @@ sdmmc0: sdio-host@a0000000 {
>   			bus-width = <8>;
>   			pinctrl-names = "default";
>   			pinctrl-0 = <&pinctrl_sdmmc0_default>;
> -			non-removable;
> -			mmc-ddr-1_8v;

Hi Ludovic,

I am not sure about the removal of mmc-ddr-1_8v; this means eMMCs 
connected on this slot won't work in high speed mode, some people use 
eMMC to SD-Card adapters and stick them into SD-Card slots.
Would it be a problem to keep this property here ?

Thanks,
Eugen

>   			status = "okay";
>   		};
>   
> 


  parent reply	other threads:[~2020-04-02  9:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-01 22:15 Ludovic Desroches
2020-04-01 22:15 ` [PATCH 2/5] ARM: dts: at91: sama5d2_ptc_ek: fix vbus pin Ludovic Desroches
2020-04-01 22:19   ` [RESEND PATCH " Ludovic Desroches
2020-04-01 22:15 ` [PATCH 3/5] ARM: dts: at91: sama5d2_ptc_ek: add PB_USER as wakeup source Ludovic Desroches
2020-04-01 22:15 ` [PATCH 4/5] ARM: dts: at91: sama5d27_som1_ek: enable i2c0 Ludovic Desroches
2020-04-01 22:15 ` [PATCH 5/5] ARM: dts: at91: sama5d27_som1_ek: add an alias for i2c0 Ludovic Desroches
2020-04-02  7:49 ` [PATCH 1/5] ARM: dts: at91: sama5d2_ptc_ek: fix sdmmc0 node description Alexandre Belloni
2020-04-02  9:20 ` Eugen.Hristev [this message]
2020-04-02 10:07   ` Ludovic.Desroches
2020-04-02 10:27     ` Eugen.Hristev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4fe14af-a812-8798-187e-704541a6a75f@microchip.com \
    --to=eugen.hristev@microchip.com \
    --cc=Codrin.Ciubotariu@microchip.com \
    --cc=Cristian.Birsan@microchip.com \
    --cc=Ludovic.Desroches@microchip.com \
    --cc=Nicolas.Ferre@microchip.com \
    --cc=Tudor.Ambarus@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®