From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751185AbdE3HaO (ORCPT ); Tue, 30 May 2017 03:30:14 -0400 Received: from mail-wm0-f47.google.com ([74.125.82.47]:35283 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751107AbdE3HaN (ORCPT ); Tue, 30 May 2017 03:30:13 -0400 Subject: Re: [PATCH v5 09/10] drm/atmel-hlcdc: Use crtc->mode_valid() callback To: Jose Abreu , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <95fd6c06c58bd0b957e36a8d7068e6a74b581304.1495720737.git.joabreu@synopsys.com> Cc: Daniel Vetter , Carlos Palminha From: Neil Armstrong Organization: Baylibre Message-ID: Date: Tue, 30 May 2017 09:30:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <95fd6c06c58bd0b957e36a8d7068e6a74b581304.1495720737.git.joabreu@synopsys.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/25/2017 04:19 PM, Jose Abreu wrote: > Now that we have a callback to check if crtc supports a given mode > we can use it in atmel-hlcdc so that we restrict the number of probbed > modes to the ones we can actually display. > > Also, remove the mode_fixup() callback as this is no longer needed > because mode_valid() will be called before. > > NOTE: Not even compiled tested > > Signed-off-by: Jose Abreu > Cc: Carlos Palminha > Cc: Daniel Vetter > Cc: Boris Brezillon > Cc: David Airlie > --- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c > index 53bfa56..bdfe74e 100644 > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c > @@ -140,13 +140,12 @@ static void atmel_hlcdc_crtc_mode_set_nofb(struct drm_crtc *c) > cfg); > } > > -static bool atmel_hlcdc_crtc_mode_fixup(struct drm_crtc *c, > - const struct drm_display_mode *mode, > - struct drm_display_mode *adjusted_mode) > +static enum drm_mode_status atmel_hlcdc_crtc_mode_valid(struct drm_crtc *c, > + const struct drm_display_mode *mode) > { > struct atmel_hlcdc_crtc *crtc = drm_crtc_to_atmel_hlcdc_crtc(c); > > - return atmel_hlcdc_dc_mode_valid(crtc->dc, adjusted_mode) == MODE_OK; > + return atmel_hlcdc_dc_mode_valid(crtc->dc, mode); > } > > static void atmel_hlcdc_crtc_disable(struct drm_crtc *c) > @@ -315,7 +314,7 @@ static void atmel_hlcdc_crtc_atomic_flush(struct drm_crtc *crtc, > } > > static const struct drm_crtc_helper_funcs lcdc_crtc_helper_funcs = { > - .mode_fixup = atmel_hlcdc_crtc_mode_fixup, > + .mode_valid = atmel_hlcdc_crtc_mode_valid, > .mode_set = drm_helper_crtc_mode_set, > .mode_set_nofb = atmel_hlcdc_crtc_mode_set_nofb, > .mode_set_base = drm_helper_crtc_mode_set_base, > Reviewed-by: Neil Armstrong