On Sun, 2025-03-30 at 12:39 -0300, Kurt Borja wrote: > Some subdrivers make use of the global reference tpacpi_pdev during > initialization, which is called from the platform driver's probe. > However, after > > commit 38b9ab80db31 ("platform/x86: thinkpad_acpi: Move subdriver > initialization to tpacpi_pdriver's probe.") > > this variable is only properly initialized *after* probing and this > can > result in a NULL pointer dereference. > > In order to fix this without reverting the commit, register the > platform > bundle in two steps, first create and initialize tpacpi_pdev, then > register the driver synchronously with platform_driver_probe(). This > way > the benefits of commit 38b9ab80db31 are preserved. > > Additionally, > > commit 43fc63a1e8f6 ("platform/x86: thinkpad_acpi: Move HWMON > initialization to tpacpi_hwmon_pdriver's probe") > > introduced a similar problem, however tpacpi_sensors_pdev is only > used > once inside the probe, so replace the global reference with the one > given by the probe. > > ... > base-commit: 1a9239bb4253f9076b5b4b2a1a4e8d7defd77a95 > change-id: 20250330-thinkpad-fix-98db0d8c3be3 > Fixed problem seen here on thinkpad. Tested on mainline commit 4e82c87058f45e79eeaa4d5bcc3b38dd3dce7209 Tested-by: Gene C -- Gene