From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Hammer Hsieh <hammerh0314@gmail.com>,
gregkh@linuxfoundation.org, robh+dt@kernel.org,
linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, jirislaby@kernel.org,
p.zabel@pengutronix.de
Cc: wells.lu@sunplus.com, hammer.hsieh@sunplus.com
Subject: Re: [PATCH v8 1/2] dt-bindings:serial:Add bindings doc for Sunplus SoC UART Driver
Date: Tue, 15 Feb 2022 15:53:47 +0100 [thread overview]
Message-ID: <b50bf9ef-eb38-8e86-70f9-7a9a959be67b@canonical.com> (raw)
In-Reply-To: <1644917065-23168-2-git-send-email-hammerh0314@gmail.com>
On 15/02/2022 10:24, Hammer Hsieh wrote:
> Add bindings doc for Sunplus SoC UART Driver
>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Hammer Hsieh <hammerh0314@gmail.com>
> ---
> Changes in v8:
> - no change.
>
> .../bindings/serial/sunplus,sp7021-uart.yaml | 56 ++++++++++++++++++++++
> MAINTAINERS | 5 ++
> 2 files changed, 61 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/serial/sunplus,sp7021-uart.yaml
>
> diff --git a/Documentation/devicetree/bindings/serial/sunplus,sp7021-uart.yaml b/Documentation/devicetree/bindings/serial/sunplus,sp7021-uart.yaml
> new file mode 100644
> index 0000000..894324c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/serial/sunplus,sp7021-uart.yaml
> @@ -0,0 +1,56 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (C) Sunplus Co., Ltd. 2021
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/serial/sunplus,sp7021-uart.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: Sunplus SoC SP7021 UART Controller Device Tree Bindings
> +
> +maintainers:
> + - Hammer Hsieh <hammerh0314@gmail.com>
> +
> +allOf:
> + - $ref: serial.yaml#
> +
> +properties:
> + compatible:
> + const: sunplus,sp7021-uart
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + resets:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - resets
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + aliases {
> + serial0 = &uart0;
Incorrect indentation. With this fixed:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-02-15 14:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 9:24 [PATCH v8 0/2] Add UART driver for Suplus SP7021 SoC Hammer Hsieh
2022-02-15 9:24 ` [PATCH v8 1/2] dt-bindings:serial:Add bindings doc for Sunplus SoC UART Driver Hammer Hsieh
2022-02-15 14:53 ` Krzysztof Kozlowski [this message]
2022-02-16 1:51 ` hammer hsieh
2022-02-15 9:24 ` [PATCH v8 2/2] serial:sunplus-uart:Add " Hammer Hsieh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b50bf9ef-eb38-8e86-70f9-7a9a959be67b@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hammer.hsieh@sunplus.com \
--cc=hammerh0314@gmail.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=wells.lu@sunplus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®