From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 268962EB10 for ; Mon, 30 Mar 2026 10:00:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774864831; cv=none; b=V+nt7VD4PV4QMRDWmJrKAUaury6GQao29yhIUGznj92Y4FlnLRaQqOmEHMWzgvAwVV8M2Jm/rFslFCLIfvf5AsZHmZThrFahLthfkLzP3U5pQMhV397N6s55sYvLIpqGK8nl19grTcnTvxv8zq1yNqpQ4un/wgdRvNGXCqBnKa8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774864831; c=relaxed/simple; bh=PLmEpJqP7s1KUMkKzqcQ6tDKvPVq7wNz9tz2kuo6qfo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=o77VaScZ2lcXCrPiANyyw1tdrs3oN1XWLBtvSBQ6cXb0Ly3TMI4WT0J38db5RG4uAFDZEvWGgTKbYfcbmgTOo1DHzn/WwdDziUqkTG1cpwWZcgDxoioG22z30DPusTtixDrrhHbMqlRmEvuaNePqBjD2pspqKQ0x1gzI3SPLa0M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Zm/8akS+; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=kk+90iOi; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Zm/8akS+"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="kk+90iOi" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62U7fkWW350298 for ; Mon, 30 Mar 2026 10:00:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= JR6tXdbAULbez3ydP74JlxQJzcCNgilbHvA1DDCMvzE=; b=Zm/8akS+/M7jn33Y 2B7vnKrJ09R8Lri90TLdTg8P/XkYMeNufulpr2RkYP3VG7xhYkCDH/TPLplf0+9i PK7BdK03ufSOl/cnlCd9KXsyg9nHSY7KKh9WUEhqlCJY12P53RBP6tbbdB8DhecS wjrFaxhThDDD1FayNcXqGPL8j509z+wqsmegqGj4mMRzCh40QwNRkvzOgHpDQj0K jBZR/5SvH4f+ElA9Bl8sNA3TvjCVb+gjvaFDSF1+cD90goneeD8GOAhjZjhqb5yF 3kM+HUSOsxYUiJAm4UnuF7CXAaXneTWAt/sLHiRqCF2uVu69jgHxJd1Qxx9MvxsI T8gvdw== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d6wqekf8y-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 30 Mar 2026 10:00:29 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-82c83bd48afso2121659b3a.3 for ; Mon, 30 Mar 2026 03:00:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774864828; x=1775469628; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JR6tXdbAULbez3ydP74JlxQJzcCNgilbHvA1DDCMvzE=; b=kk+90iOiKDieZFcFQPuUGmwbayqZAbUln3oFxyHNzn73f9UQG8+nafh3bD936zCsxM DS4xQ5lQwWBaN+aqIlUDJuqcfnaLKEihFcvBwZJi18EYSnOZi+K/kdhqUBEYzyQdG9dU tDyS7/wtzPjLJgtK6OgYUeiZN5jqajgwI5UhrXugdaa8Jnvg7fxjJkGqUQgo/0au34xs VJH35BSh/YKrCjKJPUlg7XTnTnEURIPs2WEynrfdk/F2U2+OztRZumZpzniC8yzZ17C9 ee9wgyk46LX8nHd8BQqZB9C9w2BU5GJyVMcrFLYBy8v075s0E3HDQ3llfOvuj2ZCy+EK IiJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774864828; x=1775469628; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JR6tXdbAULbez3ydP74JlxQJzcCNgilbHvA1DDCMvzE=; b=i2GyXuqLAFIHZZYQKfD3OjB9pRb7VFPweGzVe2nIKpuuusxxwQwkPgbJ/ZqIHq7Dkf L9RYmHNkaXQoV3EvE3lASmPa8wST5Ulz6WqTFJa7sj7JPtGv3Cwy9pfoOsc4eMwwzAcC E+VoiNzDKW71RcI/ORDM/NvLiEMhBA9kGze5BMFw0swkzNSZ1yBQoUOSGSCvX36fcZ2k OHKYprzbGe7sykbYmt7jQrn2ah9l15HCwXGgiIRJdjwG+TMOcW5rxoI7tPvkC0mCBaEM VPpcUDhCpwf6BauJ6SyB/930pTWzzARk0t/SthNrE9NbmfP/6+/nu3dt6t/6uwRAtjbd OrAQ== X-Forwarded-Encrypted: i=1; AJvYcCWl7q56FKOW8q8zsUGLt2tdHW840giEend051RK99aH4UXyrPBAVx98vhYv/FBrW9xWPGGtlXIAI5R+iJA=@vger.kernel.org X-Gm-Message-State: AOJu0Yyjo5kDlUFnb1Lw+S7aRm4pHlQhAmVAe1Ywlv/R9Fpz/pbkQisp YKeFpy2gUKj5or0U+Is3TdFWy+ppcpAHX4iDpvYcGHHJRldrCfTBZgr+1gCJL8Dz/zx6nGAbqdC cMesmnAeFqt2DGVMcQzWdGh1A7POr6NGyqOBH/nKEF8j3xdSQrHMUK7vbAa3aABtLzG0= X-Gm-Gg: ATEYQzzNv5CEuyNq4OrY6NE75bTRuPl1CQg4Lycq+QS0LlCZktClgPXJqtgkWxBTvH1 wTe56Vklt7CE38oG6s9qblb+7JoKExSzxJNPehjZ9BcPxtFXRc2rbeYRaG2/NVWwY1GIlXKLVZa 9xHWglko165L2YDrtw9hzu3avIvnc5YZXvWYSRY2aZHk8niSR0aHajkGo4PEKLhZVCYASGrMyOH mCcLtjEjyVpUqkuWmORhRznTW3M2aZ5XDueekEh5PjRAxAd2ydmQO86e3frXV+7JVzKofmCiAJg sTgXu99PMQD4L/BQsLAnMbNUc7/ssN68rJpWxQo8MbtcdAcNpcmFOWRHG483pf4RC7CyAnJaAKd yfqeqxKI+Sr8KBJulLNSCpm+k0mlFwuUDDwgMwvzwHbvYLieQ X-Received: by 2002:a05:6a00:2884:b0:823:9e5:855e with SMTP id d2e1a72fcca58-82c95691acfmr10648385b3a.0.1774864828196; Mon, 30 Mar 2026 03:00:28 -0700 (PDT) X-Received: by 2002:a05:6a00:2884:b0:823:9e5:855e with SMTP id d2e1a72fcca58-82c95691acfmr10648319b3a.0.1774864827387; Mon, 30 Mar 2026 03:00:27 -0700 (PDT) Received: from [10.64.69.173] ([114.94.8.21]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82ca8466e01sm6900120b3a.20.2026.03.30.03.00.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Mar 2026 03:00:26 -0700 (PDT) Message-ID: Date: Mon, 30 Mar 2026 18:00:19 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 13/38] drm/msm/dp: introduce stream_id for each DP panel To: Dmitry Baryshkov Cc: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Abhinav Kumar References: <20250825-msm-dp-mst-v3-0-01faacfcdedd@oss.qualcomm.com> <20250825-msm-dp-mst-v3-13-01faacfcdedd@oss.qualcomm.com> Content-Language: en-US From: Yongxing Mou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=Jo78bc4C c=1 sm=1 tr=0 ts=69ca49bd cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=Uz3yg00KUFJ2y2WijEJ4bw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=l0Ss5M_0uoGcHLo4SdsA:9 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-GUID: 1jhGaOjotDEVSK41fkxucoptZ0yMNGxM X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzMwMDA3OCBTYWx0ZWRfX1mO9NCVZV3u3 3Kp5knGpf3Yovciw6cGHAEx5earypVkUiIL7HiA1CbWqB3uMt3b2Bzirxf/a4VDqBTVhjcks9St OlMDCcspr/XB4dkLGa7M8KyI1IYyVHnm+b9+sR28n3KYHYG1KSQODNL2FClOBF8mP9IcjSJJPy8 aQpm+d26SeEOZdRoOZFUF/yOMtsV0NhNFNJ0vHp+LwW/FpRsjR9gH2RIb+qgyioMBiX9PlXdJwI RFtUu66MmtKiKR61xRVJ0dTtqJuMxJWhBrF6BZAiuct0exZw2s849yxNaduxBVS3v6Zh57HCVUJ UmL1I3L343wCqwuW/nE7VNOFzB2Pj8OZ5aswwDJhu7MPiiQgNXjO0QbJHLul9ri8MswvX8mpj+S KNKQmMyTDIH0pUctBRBybiwa3BS7LAlKTX1IS5bBZktALiJq5mc3lepOh4PV32NElgmbvb5cco9 Vds45KkHhjU8yP8SP1w== X-Proofpoint-ORIG-GUID: 1jhGaOjotDEVSK41fkxucoptZ0yMNGxM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-29_05,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 phishscore=0 bulkscore=0 malwarescore=0 suspectscore=0 impostorscore=0 adultscore=0 priorityscore=1501 spamscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603300078 On 8/26/2025 1:56 AM, Dmitry Baryshkov wrote: > On Mon, Aug 25, 2025 at 10:15:59PM +0800, Yongxing Mou wrote: >> From: Abhinav Kumar >> >> With MST, each DP controller can handle multiple streams. >> There shall be one dp_panel for each stream but the dp_display >> object shall be shared among them. To represent this abstraction, >> create a stream_id for each DP panel which shall be set by the >> MST stream. For SST, default this to stream 0. >> >> Use the stream ID to control the pixel clock of that respective >> stream by extending the clock handles and state tracking of the >> DP pixel clock to an array of max supported streams. The maximum >> streams currently is 4. >> >> Signed-off-by: Abhinav Kumar >> Signed-off-by: Yongxing Mou >> --- >> drivers/gpu/drm/msm/dp/dp_ctrl.c | 58 ++++++++++++++++++++++--------------- >> drivers/gpu/drm/msm/dp/dp_ctrl.h | 3 +- >> drivers/gpu/drm/msm/dp/dp_display.c | 27 +++++++++++++++-- >> drivers/gpu/drm/msm/dp/dp_display.h | 2 ++ >> drivers/gpu/drm/msm/dp/dp_panel.h | 11 +++++++ >> 5 files changed, 73 insertions(+), 28 deletions(-) > >> @@ -2677,10 +2675,11 @@ static const char *ctrl_clks[] = { >> "ctrl_link_iface", >> }; >> >> -static int msm_dp_ctrl_clk_init(struct msm_dp_ctrl *msm_dp_ctrl) >> +static int msm_dp_ctrl_clk_init(struct msm_dp_ctrl *msm_dp_ctrl, int max_stream) >> { >> struct msm_dp_ctrl_private *ctrl; >> struct device *dev; >> + char stream_id_str[15]; > > A comment would be nice. Or better replace this with the array lookup, > it's much easier than snprintf. > Thanks, will replace this with the array lookup. >> int i, rc; >> >> ctrl = container_of(msm_dp_ctrl, struct msm_dp_ctrl_private, msm_dp_ctrl); >> @@ -2710,9 +2709,19 @@ static int msm_dp_ctrl_clk_init(struct msm_dp_ctrl *msm_dp_ctrl) >> if (rc) >> return rc; >> >> - ctrl->pixel_clk = devm_clk_get(dev, "stream_pixel"); >> - if (IS_ERR(ctrl->pixel_clk)) >> - return PTR_ERR(ctrl->pixel_clk); >> + ctrl->pixel_clk[DP_STREAM_0] = devm_clk_get(dev, "stream_pixel"); >> + if (IS_ERR(ctrl->pixel_clk[DP_STREAM_0])) >> + return PTR_ERR(ctrl->pixel_clk[DP_STREAM_0]); >> + >> + for (i = DP_STREAM_1; i < max_stream; i++) { >> + sprintf(stream_id_str, "stream_%d_pixel", i); >> + ctrl->pixel_clk[i] = devm_clk_get(dev, stream_id_str); >> + >> + if (IS_ERR(ctrl->pixel_clk[i])) { >> + DRM_DEBUG_DP("failed to get stream %d pixel clock", i); >> + break; >> + } >> + } >> >> return 0; >> } >