From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A284D426EA3 for ; Thu, 9 Jul 2026 15:52:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783612348; cv=none; b=G1AiNO4ZHsf8CPhk3Wz2/49umnH+erECMsdPwtzFFUH9etnvyMvO0fxHnG++eqr2ADc4JLlhBwvMywsrCwsBYsXbTpF6APZ/Ek240dw0I3Op/95ewdYL52441RSv3CcKLWcCgZOReNuIsWz7b+aN/cpHUV0LSY09QALvznhZcvI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783612348; c=relaxed/simple; bh=3dZndHpLPoHdprw6LicCelHE4XQLVrOgIL4aLvWWTd0=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=aiyGnrL3fFQWcOJ7mWFQENPFhEbR/pkiIabtyCVrOT9B2FNjroqmntcZA52ipDf3ZdUFWrMDbiOH4HvHGIKXxvMEUOe97eb7g7rnSFmqzlRsNYbQ4BHj1rJ+JFEgn24Y8OBE9FZ54dJCvipK3F06/oY5J2DRbr4A9xrmd6NyS9E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=gVY9QgXu; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=RQoA0pWs; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gVY9QgXu"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="RQoA0pWs" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783612345; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=3dZndHpLPoHdprw6LicCelHE4XQLVrOgIL4aLvWWTd0=; b=gVY9QgXu3COnZl1OFmPXXzTFMqoZ6kDzx4yS+EGaDnsWCdyAnnvn3z3Ax/ofwkbkTmevyA dPeSwEbekjd0HbH+9eQXRc7nS7jbc0lZc10keHwlptESxuIhfVAnm+U2XhbpZe51EEpE4S JqPmw51GNzuYnh+Wsvo0B3OrpPYdvCw= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-526-jLjfHwoIPz-o11I9qRjqNQ-1; Thu, 09 Jul 2026 11:52:24 -0400 X-MC-Unique: jLjfHwoIPz-o11I9qRjqNQ-1 X-Mimecast-MFC-AGG-ID: jLjfHwoIPz-o11I9qRjqNQ_1783612343 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-4731a357b0aso27008f8f.2 for ; Thu, 09 Jul 2026 08:52:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1783612343; x=1784217143; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:content-type :autocrypt:references:in-reply-to:date:cc:to:from:subject:message-id :from:to:cc:subject:date:message-id:reply-to:content-type; bh=3dZndHpLPoHdprw6LicCelHE4XQLVrOgIL4aLvWWTd0=; b=RQoA0pWsHGGluR69KmcKH53ojy8+HXlyAqeXve8jkLRcOnUzGVv1lUiHpKbcGAJFbA SY1JpUJ5nauVTDq6cwKKPg89l9NjnNADc7Fx22vBHTnlJq7vzsoRqEOUMibm3PRmydYm 8Z0PuS8CiHikx6obeWhm2oVSGPJgbMCdUoFf+hU6kkCglhnVQW9rXZnUYPxyogEdyO9H ORbyXCrcUPkComE3ZzRDwa08G+Ryf2rV8BO/fbICFN6qnbUVKFLa2AfW9005d6RMMVdN wttLVEJyF/Ozebz7ecm4lfJR5awCDi5cKEitdx8pbQZ2wTq+7LDP6VRZKiZBsVg2+p8T qUqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783612343; x=1784217143; h=mime-version:user-agent:content-transfer-encoding:content-type :autocrypt:references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=3dZndHpLPoHdprw6LicCelHE4XQLVrOgIL4aLvWWTd0=; b=GamkT/FeHYq9Cg+RZuAT3fccHbEHlgSFbWatGkII4sRGiY2S1pk2TqLCUIqXHNl8st j0X73Y4psG0F1qRFD/z8Et9ORnb8Qig2tHukAMITM2KQHdjEirQA11mWGInD3cDUWi7+ CXNjAA7TKiM2FjI/Bqt8gLTR9PukHYC4pHdZf66s/o/NkUSBE9WChtLfZ4q2dOSJqs49 HTxlGrwMhrME+7XuUZwgoSFDMtOzUXSavLWqrYacvNvIduTBdithWfNp7OpDPtsuPGrg Uo3jkL+IEE9flGqt5rLLnoEspfXDCrWo3FEzCK1aYYncISvccthPfrBFOJRDf64wQe6S HV1A== X-Forwarded-Encrypted: i=1; AHgh+RqrQGiTvEBTMXeAGGi6KA7pAfWMIMzvwTOI5BDxrydCsDcgtKWSxFGJSY7ORExd/poF4RfUQ9YQLVN1wQk=@vger.kernel.org X-Gm-Message-State: AOJu0YyFrRK4kd+6DAcbJ/zmHmPUVWYNS6wSVtxJEH3Lvpm3ce/3iszK 89ilFjycrcyAS4OjnNS8amOSEAE1xeNsMQjKusuEFaU/fECJJ/pcCeLyRVohReN4d9EQ3ZaB1Pm UWpqIV1R7CioBp59JYR7V/Cm0pftQDeFLUJdOM6tVsjajoQowEuWgTfCn/IpxhDnMOwDoCzCyYn mW X-Gm-Gg: AfdE7ckHyC2/Bp3ERm53fXkyo479aFNmXoxwI4QqHGLlEz74nzH/U2UC1Ia/0Ot1Z1b jdzJeo4xqJRfh1+K7ZWfXl9x3ZVC1GcJ2def5uGIUEvmZgr7wqPugB/rClFKx2/pZ6d98r7RX2x L1xul2fRr89b1rNsghel01L0Bj7zeDbyGUCf5Yc2DthdVbs0LqGAk8Z14FbTG7bRAUko+q9PU8n TUIouXW5KMvMy42/M/4f0dvWOdEHh1NBNEhjL4xrluOtY+M837399XdhJcEL7LPIWmG+gkXlrBM pe3nUkoZp2TdwXFc2wIqnBsZ/a8Z3qICU4BEV2LDR4skr2S0UucNkNJRIoNtOScYbb0D55BTijl 8OzSTxHOD6ey51jfDMbPCewTmUT1fD/3E3BFMHqza4rgK8qyViRbO0s5LcsaCFZANJUQEIsvibH R2cKGA X-Received: by 2002:a05:6000:27cd:b0:47e:4b05:2c8c with SMTP id ffacd0b85a97d-47e4b052ebbmr857914f8f.15.1783612343244; Thu, 09 Jul 2026 08:52:23 -0700 (PDT) X-Received: by 2002:a05:6000:27cd:b0:47e:4b05:2c8c with SMTP id ffacd0b85a97d-47e4b052ebbmr857888f8f.15.1783612342700; Thu, 09 Jul 2026 08:52:22 -0700 (PDT) Received: from gmonaco-thinkpadt14gen3.rmtit.csb (212-8-243-115.hosted-by-worldstream.net. [212.8.243.115]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47aa0f214d2sm51056545f8f.33.2026.07.09.08.52.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2026 08:52:22 -0700 (PDT) Message-ID: Subject: Re: [PATCH v3 14/17] verification/rvgen: Add selftests for rvgen kunit From: Gabriele Monaco To: Nam Cao , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Thomas Weissschuh , Tomas Glozar , John Kacur , Wen Yang , Steven Rostedt Date: Thu, 09 Jul 2026 17:52:20 +0200 In-Reply-To: <87a4s0fuqx.fsf@yellow.woof> References: <20260625121440.116317-1-gmonaco@redhat.com> <20260625121440.116317-15-gmonaco@redhat.com> <87a4s0fuqx.fsf@yellow.woof> Autocrypt: addr=gmonaco@redhat.com; prefer-encrypt=mutual; keydata=mDMEZuK5YxYJKwYBBAHaRw8BAQdAmJ3dM9Sz6/Hodu33Qrf8QH2bNeNbOikqYtxWFLVm0 1a0JEdhYnJpZWxlIE1vbmFjbyA8Z21vbmFjb0BrZXJuZWwub3JnPoiZBBMWCgBBFiEEysoR+AuB3R Zwp6j270psSVh4TfIFAmjKX2MCGwMFCQWjmoAFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgk Q70psSVh4TfIQuAD+JulczTN6l7oJjyroySU55Fbjdvo52xiYYlMjPG7dCTsBAMFI7dSL5zg98I+8 cXY1J7kyNsY6/dcipqBM4RMaxXsOtCRHYWJyaWVsZSBNb25hY28gPGdtb25hY29AcmVkaGF0LmNvb T6InAQTFgoARAIbAwUJBaOagAULCQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgBYhBMrKEfgLgd0WcK eo9u9KbElYeE3yBQJoymCyAhkBAAoJEO9KbElYeE3yjX4BAJ/ETNnlHn8OjZPT77xGmal9kbT1bC1 7DfrYVISWV2Y1AP9HdAMhWNAvtCtN2S1beYjNybuK6IzWYcFfeOV+OBWRDQ== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.60.2 (3.60.2-1.fc44) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Thu, 2026-07-09 at 10:11 +0200, Nam Cao wrote: > Gabriele Monaco writes: > > The rvgen kunit command patches monitor files and adds necessary > > definitions for kunit tests. > >=20 > > Add a test case validating its behaviour on dummy generated files and > > comparing it against reference files, like it's done for rvgen monitor. > >=20 > > Signed-off-by: Gabriele Monaco >=20 > I am not entirely sure about this. In the future, when the generation > output is changed, all the references files also need to be updated. So > it's not clear to me if this really saves future development effort. Yeah that's an issue with all this testing with golden files. At least unle= ss we change the output drastically, changes to those should be easy to apply and= to review (and LLMs can help here too). > But well, we will see. For now: >=20 > Reviewed-by: Nam Cao Thanks, Gabriele