From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9AB7025392F for ; Fri, 2 May 2025 12:28:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746188909; cv=none; b=Klamfpo2yoDLCYM0hTXSPG94fIWoymuMsy7KsCsMx2S1CGDAFBO5Ig22VXwZK1dghW9v8WsdXMUZkudFlgRt/SprOeIzX1imI5GZwZktPjp8NTy0cgcmMbVbhUZxT71ZzksJTd1ifklvfYLbia7ZbiCecgPHSRPorOQEho3JpqI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746188909; c=relaxed/simple; bh=uC44g044KcShpYumwGzfPKaaQH0BoggRjBL8awNC4zU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MUOSi3IcbsuXZd+fxI7DsQMaqv5T469LNL+y6/dW2TbwxEIkllav4ZkvobtVTUg0x8CGvaUIOtPi12dJrOLZWzaxEo+hILFfdlqj/m29j+9WzdfJw/GC4+LwRKNJ6lQTT79zPjuzXj5UQgGpYnKg2LdQbMSWzOdGkQBmhrnBVj0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=uZmGfClC; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="uZmGfClC" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-43cf06eabdaso14967355e9.2 for ; Fri, 02 May 2025 05:28:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746188906; x=1746793706; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XFKlbhYbOYEqU3Hx7LL1L8k4PnOc/LhcaLrz8KQ4fp4=; b=uZmGfClCc6k6ztUAMU3yvHwOaaFLzKN82E85imeept29LiiO9eOAAWDVECLmx7Ke8+ ebT1bKwCSzl9Gnhn9yWL5MlY4rOD0XUUK3YEgEWAq9hSdvjfwOEeZ3ajevZWlAFZX61M 3H+RdQMLTwpiGy7la5kLIsNQzANTtf7PxQ+s+X2syiwF0N57IDQzUa2EnbZdrteDDvQo NphFQvpSL5ClWP4cR6F+sF2vLFw3ZvsIAOP7xwkZbF4VLiG57/V/iOC8GE9R2helPMAz ZYsUMcqvYDbQzNoARKoJLINwIi3OPxSJ9tTKU8C/h3u60z086khAjEZurFNo/05+EkpB zSrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746188906; x=1746793706; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XFKlbhYbOYEqU3Hx7LL1L8k4PnOc/LhcaLrz8KQ4fp4=; b=Ou+VKL6vZJqa3XGKGx6JgoFQ+SVAFe6DlArX42+FnfKk/IlnKzFtwSEJnd3GCJz7LR CoMtg3PhqPj5PX7FOqHLJe6lxn8xxdxJistBNeV5WoiS/aCdAH5oqla66be8/2Lo4XHX pdW7rdgAVyDPEgPNV195lsUmZFFO7vT0NGWe380FbB90HO4suQUjc9p8pSagp5qV+m87 6BV66UvQEwlsLmbzhoeDd1RGuMq8ezPeH2seinnisM58RGpKHev0pwWl1zwAdT3sZCRC wGQ07yPBuMAXtYMb1v00qk28S+uRJL5/Xj6wXVLasMTyDTmsmE6XrbZ+F6JuLVQiAvQF A4mg== X-Forwarded-Encrypted: i=1; AJvYcCUyQiWkY/HrcaGKk80z8nZ6XvClqM/Vask//4uJPf8+/Vrdf9Ka3cbj3kEpLHyswLYybjFV7UNfBczBBVM=@vger.kernel.org X-Gm-Message-State: AOJu0YyHuRDd+y7CAv95nm9NmPn2gIBpy7HBRYV2lg6MsB1Fjq6MueF/ iqiRhxvM6A3e/pD8+IdyuciULN2HdolhFi4zD0nWO+WOdgfmzuPyYxgD7Pst1pw= X-Gm-Gg: ASbGncvcsCZw8pRsryAxLxgWiNuuXgl+t80li4+eLEjE7gltyoiVAZAyU+QM3RY2ogz DDy6Ui/UtZCxa6DfkHnEdKRELH3pfgf8QAS08+zpQG6bkh7fBbup2IxAgydYytct0+acZVEER/Q +07sLQIiscKj4NaM0Q+Yd01dfTtY+4zuJ4KuL85mv46oMtI7Ccuim1OTnXOfsA1A/ebiCdivOQU QMJ3bOcroxDbalAowG5ZrEVnZYR2RhoMI1FW7hEfE9al4mIx2t9h5/m4y0jAiWzDJH6M1cEmFOA Yg8ELLFI3bT7XH+AF3mylqF7TbKHhO9/fH0X7bWwXFEbSOVenDr295y6ZFWumh2hlig6BKwRM8G 9O1HPRQ== X-Google-Smtp-Source: AGHT+IEkYYqC5HLJDXAnW5gzwBKk2/Wl+3ak0P8p7yEpFGbDPHanEhrJN2oVaPxj/s406NWQ0lakDw== X-Received: by 2002:a05:600c:1f0a:b0:43c:efed:732d with SMTP id 5b1f17b1804b1-441bbec629emr22778825e9.16.1746188905909; Fri, 02 May 2025 05:28:25 -0700 (PDT) Received: from [192.168.0.35] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-441b8a31695sm43591945e9.40.2025.05.02.05.28.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 May 2025 05:28:25 -0700 (PDT) Message-ID: Date: Fri, 2 May 2025 13:28:24 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 07/23] media: iris: Fix missing function pointer initialization To: Dikshita Agarwal , Vikash Garodia , Abhinav Kumar , Mauro Carvalho Chehab , Stefan Schmidt , Hans Verkuil , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Dmitry Baryshkov , Neil Armstrong , Nicolas Dufresne , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, 20250417-topic-sm8x50-iris-v10-v7-0-f020cb1d0e98@linaro.org, 20250424-qcs8300_iris-v5-0-f118f505c300@quicinc.com, stable@vger.kernel.org References: <20250502-qcom-iris-hevc-vp9-v3-0-552158a10a7d@quicinc.com> <20250502-qcom-iris-hevc-vp9-v3-7-552158a10a7d@quicinc.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20250502-qcom-iris-hevc-vp9-v3-7-552158a10a7d@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 01/05/2025 20:13, Dikshita Agarwal wrote: > The function pointers responsible for setting firmware properties were > never initialized in the instance capability structure, causing it to > remain NULL. As a result, the firmware properties were not being set > correctly. > > Fix this by properly assigning the function pointers from the core > capability to the instance capability, ensuring that the properties are > correctly applied to the firmware. > > Cc: stable@vger.kernel.org > Fixes: 3a19d7b9e08b ("media: iris: implement set properties to firmware during streamon") > Acked-by: Vikash Garodia > Signed-off-by: Dikshita Agarwal > --- > drivers/media/platform/qcom/iris/iris_ctrls.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/platform/qcom/iris/iris_ctrls.c b/drivers/media/platform/qcom/iris/iris_ctrls.c > index 915de101fcba..13f5cf0d0e8a 100644 > --- a/drivers/media/platform/qcom/iris/iris_ctrls.c > +++ b/drivers/media/platform/qcom/iris/iris_ctrls.c > @@ -157,6 +157,7 @@ void iris_session_init_caps(struct iris_core *core) > core->inst_fw_caps[cap_id].value = caps[i].value; > core->inst_fw_caps[cap_id].flags = caps[i].flags; > core->inst_fw_caps[cap_id].hfi_id = caps[i].hfi_id; > + core->inst_fw_caps[cap_id].set = caps[i].set; > } > } > > Reviewed-by: Bryan O'Donoghue