From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751224AbeCJVPP (ORCPT ); Sat, 10 Mar 2018 16:15:15 -0500 Received: from mail-wr0-f193.google.com ([209.85.128.193]:37945 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751135AbeCJVPN (ORCPT ); Sat, 10 Mar 2018 16:15:13 -0500 X-Google-Smtp-Source: AG47ELt/hQd/59QI7bVu0VWYJ/KXyFjlbF0fKysWh3kQ6UxEh73anWCdemh2EErifzgnZV892ztVog== Subject: Re: [PATCH] leds: fix wrong dmi_match on PC Engines APU LEDs To: Hans Ulli Kroll , Alan Mizrahi , Richard Purdie , Pavel Machek References: <20180305170910.8905-1-ulli.kroll@googlemail.com> Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, "platform-driver-x86@vger.kernel.org" From: Jacek Anaszewski X-Enigmail-Draft-Status: N1110 Message-ID: Date: Sat, 10 Mar 2018 22:13:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20180305170910.8905-1-ulli.kroll@googlemail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Hans, Thank you for the patch. On 03/05/2018 06:09 PM, Hans Ulli Kroll wrote: > APU has compared to APU2 no DMI_BOARD_NAME. > Use DMI_PRODUCT_NAME instead. Could we have the commit message more expressive? Is it that now this driver doesn't work for APU board? > Signed-off-by: Hans Ulli Kroll > --- > drivers/leds/leds-apu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/leds/leds-apu.c b/drivers/leds/leds-apu.c > index 74820aab9497..5bbf5c31413e 100644 > --- a/drivers/leds/leds-apu.c > +++ b/drivers/leds/leds-apu.c > @@ -206,7 +206,7 @@ static int __init apu_led_probe(struct platform_device *pdev) > > apu_led->pdev = pdev; > > - if (dmi_match(DMI_BOARD_NAME, "APU")) { > + if (dmi_match(DMI_PRODUCT_NAME, "APU")) { > apu_led->profile = apu1_led_profile; > apu_led->platform = APU1_LED_PLATFORM; > apu_led->num_led_instances = ARRAY_SIZE(apu1_led_profile); > If it fails here, then how it is possible that it succeeds in the apu_led_init() ? -- Best regards, Jacek Anaszewski