From: Markus Elfring <Markus.Elfring@web.de>
To: Alper Ak <alperyasinak1@gmail.com>,
linux-media@vger.kernel.org,
Daniel Scally <dan.scally@ideasonboard.com>,
Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Hans Verkuil <hverkuil+cisco@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Nayden Kanchev <nayden.kanchev@arm.com>
Subject: Re: [PATCH] media: malic55: Fix possible ERR_PTR deference in enable_streams
Date: Sat, 14 Feb 2026 15:36:53 +0100 [thread overview]
Message-ID: <b525c449-652b-4557-9517-ae695ffc3105@web.de> (raw)
In-Reply-To: <20260207091822.601255-1-alperyasinak1@gmail.com>
…
> pointer or an ERR_PTR() on failure …
error pointer
> Add proper error checking with IS_ERR() before dereferencing the
> pointer. Also set isp->remote_src to NULL on error to maintain
> consistency with other error paths in the function.
…
* See also once more:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/stable-kernel-rules.rst?h=v6.19#n34
* Were any source code analysis tools involved here?
* Would a summary phrase like “Prevent error pointer dereference
in mali_c55_isp_enable_streams()” be more appropriate?
Regards,
Markus
next prev parent reply other threads:[~2026-02-14 14:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-07 9:18 Alper Ak
2026-02-09 8:49 ` Jacopo Mondi
2026-02-09 11:40 ` Dan Scally
2026-02-14 14:36 ` Markus Elfring [this message]
2026-03-06 6:31 ` Alper Ak
2026-03-06 6:46 ` Markus Elfring
2026-03-06 8:56 ` [PATCH] " Jacopo Mondi
2026-03-06 9:06 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b525c449-652b-4557-9517-ae695ffc3105@web.de \
--to=markus.elfring@web.de \
--cc=alperyasinak1@gmail.com \
--cc=dan.scally@ideasonboard.com \
--cc=hverkuil+cisco@kernel.org \
--cc=jacopo.mondi@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nayden.kanchev@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®