From: Krzysztof Kozlowski <krzk@kernel.org>
To: Igor Belwon <igor.belwon@mentallysanemainliners.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
David Wronek <davidwronek@gmail.com>,
Sibi Sankar <quic_sibis@quicinc.com>,
Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/6] dt-bindings: arm: cpus: Add Samsung Mongoose M5
Date: Wed, 16 Oct 2024 08:17:18 +0200 [thread overview]
Message-ID: <b5267106-27a3-48e5-9fd3-912b4c62155c@kernel.org> (raw)
In-Reply-To: <20241015210205.963931-2-igor.belwon@mentallysanemainliners.org>
On 15/10/2024 23:02, Igor Belwon wrote:
> Add a compatible for the Samsung Mongoose M5 cores, found in
> the Exynos 990.
>
> Signed-off-by: Igor Belwon <igor.belwon@mentallysanemainliners.org>
> Acked-by: Rob Herring (Arm) <robh@kernel.org>
I am not going to review untested code, sorry.
<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.
Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.
You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time.
Please kindly resend and include all necessary To/Cc entries.
</form letter>
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-10-16 6:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-15 21:01 [PATCH v2 0/6] Add minimal Exynos990 SoC and SM-N981B support Igor Belwon
2024-10-15 21:02 ` [PATCH v2 1/6] dt-bindings: arm: cpus: Add Samsung Mongoose M5 Igor Belwon
2024-10-16 6:17 ` Krzysztof Kozlowski [this message]
2024-10-15 21:02 ` [PATCH v2 2/6] dt-bindings: hwinfo: exynos-chipid: Add compatible for Exynos 990 chipid Igor Belwon
2024-10-15 21:02 ` [PATCH v2 3/6] dt-bindings: arm: samsung: samsung-boards: Add bindings for Exynos 990 boards Igor Belwon
2024-10-15 21:02 ` [PATCH v2 4/6] soc: samsung: exynos-chipid: Add support for Exynos 990 chipid Igor Belwon
2024-10-15 21:02 ` [PATCH v2 5/6] arm64: dts: exynos: Add initial support for the Exynos 990 SoC Igor Belwon
2024-10-15 21:02 ` [PATCH v2 6/6] arm64: dts: exynos: Add initial support for Samsung Galaxy Note20 5G (c1s) Igor Belwon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5267106-27a3-48e5-9fd3-912b4c62155c@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=davidwronek@gmail.com \
--cc=igor.belwon@mentallysanemainliners.org \
--cc=ivo.ivanov.ivanov1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=quic_sibis@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®