From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECC7C1EB5B for ; Wed, 4 Feb 2026 16:31:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770222710; cv=none; b=IuEjayTZoLJnszxtVQYJsGBOyVRbZQhqZg63aqAVburz7JEuRjqyN+fKRO8t9YstnUvt9CPYtPv9j1ANvmsiPaIab8fn1YlZ1JOvppN4/CDMkATzZsCi2a9amNSwCyV3a5IpAZFxqzlP+ACmDbPpL8wsHwBT0E2ijA1pzgYcXbQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770222710; c=relaxed/simple; bh=Z8BUtmy4vYqnP2Sl5b6PxGQmlvFe0zk8gqNCmj62HYc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VIOc06Y7thCwcXc3N/aZsTBAFtayM2W6DTF85JSXiY4fo191RS7fFI32dOE9WH9l6R1mRQAGKmUwRQqLKyQwQN3njguxUGGCsOLZGuS3ue1KBczQzEGjN8hWc4RcuTKdwcu1krncYfTavCD7mmkkL5ApPe/hqn1UKgFXoCGsUJY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Q0ee8ae5; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=JLSFdkcp; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Q0ee8ae5"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="JLSFdkcp" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 614CIS8B200139 for ; Wed, 4 Feb 2026 16:31:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= WjYc5v8giEANpBvp2Y4mcpR13v9pfhNpJMCgPZbtUk0=; b=Q0ee8ae50UtoqGGa R2v6W1rJPrLg3l4sWL1wctkXamo5+He8/EYxl73ihR4oqW8GS8cuwanl2J3cLHrH N52+KD/StqvyYs21ddSYnOKXxxkmOB2dYAXZR/vfChOj9FNqBRh8x6ByxxSpB7r+ m0OMNXS1XRgQsICz5IrUrfS1fG8UDBdR7WKQKVaXcBSjieDpSKMQYyXvqi+aKOLa toTy/PeH1RfwmacIMWa4lyNbKZAvQCNOXtqa1MwtnZ8pUnf8VfOzJmf48DAxOjpY 3vwF09WGDY6MzIbRNkBXkeL9bt0PzkeNFmN3T9Inff+MHcpqMvvVZzqBEGPxBtQW fN0Gew== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c3yp5a1b6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 04 Feb 2026 16:31:48 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-34c314af2d4so5345114a91.3 for ; Wed, 04 Feb 2026 08:31:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770222708; x=1770827508; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WjYc5v8giEANpBvp2Y4mcpR13v9pfhNpJMCgPZbtUk0=; b=JLSFdkcpMIxSafbZ9ccKuJeL1FP29F4s9XHWVoK1Svq9ZXr7a2NWN49nYVD/ASHXH9 L3Htf38MwBR59BEVssB9NEZ3lRIpl8J/9+GwYWqPiwK9VXrfeKlw27HZCsf1feiJhy+O 87W9ZmR0qHBBcwi8jFMN3OVQcPcttq1X3qYmyejhljavzhnuPNNlHOmr/phdURyAuWBC eAJHma6eqMa/wtDnEGlHSVcD3VONcfLucuByB0uuLnRMZCg6mMUeZxkogSfjTGLo+iJ2 JlX/r1zrWvFyndXKS4BHjVNdpHfvN4G96DJqmXgzUp4TaMwOeUvrPBUv78XKbslE1tlB 9axA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770222708; x=1770827508; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WjYc5v8giEANpBvp2Y4mcpR13v9pfhNpJMCgPZbtUk0=; b=C71dlnW3eyOAI55JRaZvxJpktYtpPgOkVgDd504IQ4NWpMFslF7ObskfRNEqqjDgtR q2XY6Z634tSYc0yyAomQevcjDY0D40uGBYNZU++TTvAKvCiiFhqxQo9zRFpi8ZIfoEgV 9jh+to+w62wiWadKI1MbWm4dCbqBtlssGbpBx+LZkDtvcuhZpwP4VZZmCHF31xwFR6qP Tq43GO3Tcr4nidkF6HS+m6Hd4Cp0oow2MZ/uvu60nFVemL97j8c/Upr7ICuojzNT8gNU BtcWKUMwvzwFF3vXRr99XP5TqWwDsfDqCeUAZJ78LbdZ7MiTeUay2cIRxhfVmk5rwSnF /LEg== X-Forwarded-Encrypted: i=1; AJvYcCWpVsHuHt5aY8uei+q5kVLfh26cB+lfErbiZlevJBhJviw4eLgV7GzhtFxTyfdfiokJcOjHgm2CFzqo1PE=@vger.kernel.org X-Gm-Message-State: AOJu0Yxa+CmvRUHcQEMnjlDm6NIE+oF8+Eqb+Y6txozwjbX7fgdx9J6z Vqaj17LIJq8cq5camGQO0L5KS+RZHCYlzTju1OeaNwIAFY5mSrx97jGml1ddsXUHwWLG1HLNSQN wYFoElA3bl0FjZ+o4YGITCjfdSLn4MUmE/ospQ0Jxad+FIXETz0CCh08gZagCtmYMjTY= X-Gm-Gg: AZuq6aJzCfS/fldUlc8Zs4yWL/Xe9wYlT4mus/J/wZTWM/ht+5Kgn3IAFEnnGfcAtaT +FDEvj1325Foo3Aye2XCpujQY30ncv3HUyO0hQOgJTYq8JJQQDIZ9SXRNbu0eRBBgqDIX50tot8 PsBX97ICuXjp6jHh8ogmhmpxcC9xabFhdmjuLLVms5XEW6+L5D13ORuH39+alG3ktNtymGSuRrk 3XWSmACNX/rxn5nNUo8y3yNj49Mi60ggIfkiYgWXU0RPC/tT4X9QkY/+gy3fQ/VBFcKvPCZTs47 hf/jhY1FDQ7e10uZ1fcIdfkA/VbQIQO3rqc3jj/u88sshsvOOVor1UocBTu6neuvjUzAxuU7Zz/ 3lXNRL6enRcQAVQmHc3to+CAHYYtP44OVks+qL9/8 X-Received: by 2002:a17:90b:534e:b0:340:be44:dd0b with SMTP id 98e67ed59e1d1-3548722b3cfmr2875491a91.34.1770222707815; Wed, 04 Feb 2026 08:31:47 -0800 (PST) X-Received: by 2002:a17:90b:534e:b0:340:be44:dd0b with SMTP id 98e67ed59e1d1-3548722b3cfmr2875456a91.34.1770222707189; Wed, 04 Feb 2026 08:31:47 -0800 (PST) Received: from [192.168.1.4] ([49.204.107.72]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-354860bef61sm3266726a91.3.2026.02.04.08.31.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Feb 2026 08:31:46 -0800 (PST) Message-ID: Date: Wed, 4 Feb 2026 22:01:39 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 11/13] i2c: qcom-geni: Use resources helper APIs in runtime PM functions To: Konrad Dybcio , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mukesh Kumar Savaliya , Viken Dadhaniya , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com Cc: prasad.sodagudi@oss.qualcomm.com, quic_vtanuku@quicinc.com, aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, jyothi.seerapu@oss.qualcomm.com References: <20260202180922.1692428-1-praveen.talari@oss.qualcomm.com> <20260202180922.1692428-12-praveen.talari@oss.qualcomm.com> <7733eac7-8158-40f8-8887-44e458d33e9b@oss.qualcomm.com> <3466212b-802c-4ea3-8661-794da34c6c3e@oss.qualcomm.com> <34ecaa11-0d2c-4981-ba5d-4d3d46e41dbc@oss.qualcomm.com> Content-Language: en-US From: Praveen Talari In-Reply-To: <34ecaa11-0d2c-4981-ba5d-4d3d46e41dbc@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: h3YSQ8ruRr_8bEqUH7m5WO9vPHN_DSXp X-Authority-Analysis: v=2.4 cv=cquWUl4i c=1 sm=1 tr=0 ts=69837474 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=JMgISmeAsz0pT9/O8qDBbw==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=SbYDc_ivveej1R-7gkAA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjA0MDEyNiBTYWx0ZWRfX406yVOMKFi1l lDjoEbVFOz5+Av7ssoM00NSoBssEdcfNsL77brtAr/nkRVGo8AEnEcIFqK9T9ijG4Ana7wdptaw /EdiHab9++4IQn7KokSrlY5XAThf5UGXP7hoDZSsHliOUYsMy9H2tuixjR+iN65e2/cV2/tEBPf qr9QlOW2tbge5i2HSZZNwVR8udkEiUeIrpmg53O4tCFYJpLCOkN36EJIwMF2CPO90cNnTEBJcrc Z/pO/bG9Id25Cg+spXAsf1dXrDcYT39UHzFMJkbOpV3YokY6pLW1xkeUZN2f1fN/DRA8kOY9mC2 u3spRe7PE63EPm7j+33s2rArUM8Lcjh2L1EXXzNnndAleLUuzMt2pCxKgah0vXn/F/3TTjLDUHo e7dzoeFttEYlvKOtkxfUY1hyhzwXGrultQGyvDFdwQnDb6X2JC9Z0vfjqZRgImifQue08ZHeyf5 /i1YTHp93UlaDqtBKlQ== X-Proofpoint-GUID: h3YSQ8ruRr_8bEqUH7m5WO9vPHN_DSXp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-04_05,2026-02-04_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 bulkscore=0 malwarescore=0 impostorscore=0 priorityscore=1501 spamscore=0 suspectscore=0 clxscore=1015 phishscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602040126 Hi Konrad, On 2/4/2026 7:14 PM, Konrad Dybcio wrote: > On 2/4/26 6:06 AM, Praveen Talari wrote: >> Hi Konrad, >> >> On 2/3/2026 6:18 PM, Konrad Dybcio wrote: >>> On 2/2/26 7:09 PM, Praveen Talari wrote: >>>> To manage GENI serial engine resources during runtime power management, >>>> drivers currently need to call functions for ICC, clock, and >>>> SE resource operations in both suspend and resume paths, resulting in >>>> code duplication across drivers. >>>> >>>> The new geni_se_resources_activate() and geni_se_resources_deactivate() >>>> helper APIs addresses this issue by providing a streamlined method to >>>> enable or disable all resources based, thereby eliminating redundancy >>>> across drivers. >>>> >>>> Acked-by: Viken Dadhaniya >>>> Signed-off-by: Praveen Talari >>>> --- >>> >>> [...] >>> >>> >>>>       disable_irq(gi2c->irq); >>>> -    ret = geni_se_resources_off(&gi2c->se); >>>> + >>>> +    ret = geni_se_resources_deactivate(&gi2c->se); >>>>       if (ret) { >>>>           enable_irq(gi2c->irq); >>>>           return ret; >>>> - >>>> -    } else { >>>> -        gi2c->suspended = 1; >>>>       } >>>>   -    clk_disable_unprepare(gi2c->core_clk); >>> >>> I believe you can give gi2c->core_clk and desc->has_core_clk the boot >>> with this patch since they're no longer referenced anywhere >> >> Sorry i didn't get you. Please share more on this. > > I think you can remove these fields from i2c-qcom-geni.c as they seem > unused now Got it. will update in next version. Thanks, Praveen Talari > > Konrad