mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Slaby <jslaby@suse.cz>
To: Trevor Bourget <tgb.kernel@gmail.com>, gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vt: configurable number of console devices
Date: Wed, 29 May 2019 13:03:29 +0200	[thread overview]
Message-ID: <b52aaaed-5efb-ae1f-68c0-80b150388219@suse.cz> (raw)
In-Reply-To: <20190528043117.169987-1-tgb.kernel@gmail.com>

On 28. 05. 19, 6:31, Trevor Bourget wrote:
> --- a/include/uapi/linux/vt.h
> +++ b/include/uapi/linux/vt.h
> @@ -8,9 +8,13 @@
>   * resizing).
>   */
>  #define MIN_NR_CONSOLES 1       /* must be at least 1 */
> +#ifdef CONFIG_MAX_NR_CONSOLES
> +#define MAX_NR_CONSOLES CONFIG_MAX_NR_CONSOLES

This is an uapi header. Will the #ifdef work there? As I don't think
CONFIG_* (i.e. autoconf.h) is available in userspace...

Also, I am not sure if there is any consumer of this macro in userspace
at all -- so what are the possible effects of this being "incorrect"?

BTW having headers from one kernel and booting another with different
settings makes this definition also incorrect. The same as for e.g. the
HZ constant. Again, not sure if this is a problem at all.

thanks,
-- 
js
suse labs

  reply	other threads:[~2019-05-29 11:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-28  4:31 Trevor Bourget
2019-05-29 11:03 ` Jiri Slaby [this message]
2019-05-29 22:09   ` Trevor Bourget
2019-05-29 23:31     ` Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b52aaaed-5efb-ae1f-68c0-80b150388219@suse.cz \
    --to=jslaby@suse.cz \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tgb.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®