From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2FAA1ADC7E for ; Wed, 17 Dec 2025 02:57:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765940257; cv=none; b=NyaWIlSywVZIdViZTki1k2eb3gpSWPnCxRZhVd/R+NJBumDbEYdLqSGIfs9PeIWkcTruGPY/UnBwyo5NQJgFcU1IaSxO8QXnoS9NodZw9M7vgSXiaQ8hKu1zwEI3AC1IKMiceAM1b6VsESn4R5ov/dmBhTbHS4/+F5WpS5AnEyw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765940257; c=relaxed/simple; bh=ckEgDNKyq72EE0v5Sfv4+vjxpNCvzqgnA7zpO/rXnW4=; h=From:Message-ID:Date:MIME-Version:Subject:To:Cc:References: In-Reply-To:Content-Type; b=u7nj3TSHt60yl1MULHw1stErdCASiik1c2okaJwc6muM9wwccklG2CHPzHrgQgRzJGDT6FtUpN5h0juaE49Rc9YqlPBhODRCQYrWLRP6aScN9ohyDScIbf+VBwp1FOvHCVguNoMCi2DpEajhv+BPQvHac/fSL7HTBY/dqF2phZs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=LVtw3PGJ; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=DRHv/rhF; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LVtw3PGJ"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="DRHv/rhF" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1765940254; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aIL+3g9SqMd1LyXr+crDOqnZ4LKhJsbIrY7gSCbKeco=; b=LVtw3PGJbF2GphsdpgdQ8/mc5Sdpzd4Mo29UY6l67DUjTZ3P3f8G5GrKD0wEL1aZ8Q61rA kCT60anUCEchUs6SxS9TS9aM2ct/A9XkfiiHkcUgzMoBqk7vyyrgobWXpaZEfieCcz/PWM tEuzRp+Apj4VPZGpJyibExlBIgbjhrE= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-618-1ZE-iOyhNjS_ZrEjFypXzA-1; Tue, 16 Dec 2025 21:57:33 -0500 X-MC-Unique: 1ZE-iOyhNjS_ZrEjFypXzA-1 X-Mimecast-MFC-AGG-ID: 1ZE-iOyhNjS_ZrEjFypXzA_1765940253 Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4f1b7686f0fso99938341cf.0 for ; Tue, 16 Dec 2025 18:57:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1765940253; x=1766545053; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:from:to :cc:subject:date:message-id:reply-to; bh=aIL+3g9SqMd1LyXr+crDOqnZ4LKhJsbIrY7gSCbKeco=; b=DRHv/rhFoDCyP0m6Yop7CDOCk3f7LP6M/vD/oPOuU6WASk52OlQ8n7nBvpwvURn3VR okby4YveziBmctnYAzq15NebdTI+vgyVctLL4kC6ncLYkfDvAcw/sBB57R33gCMI7Cq7 HVSq04VSwVJ1e8RSp6e81UCiw12nxX9z5sYaeQgkU/044Ec1ukzD3g8n0rKIFLdik4xq oRfIUbnzk/hRcEscbqbeNteDfpOIdmvaklWVLAMImTgi+IaW8kHZ75dia0V7lvp04HWn EeZABnmkUbdTiNC8YTL1T88uRG4xsfv1qR9G1oJ2gzI1KqM6RyYaqGtoK2Q4+62NMHi9 qcoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765940253; x=1766545053; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aIL+3g9SqMd1LyXr+crDOqnZ4LKhJsbIrY7gSCbKeco=; b=umWxBBXKOqIaAjQQqzWZ+YwDz7xpKFCFMYT8Oi+srPem8lCp5EUsmaJaDSuP+NOmPq QCv+tJe0BeCBZdqdxGmRYufishL788MRJdBSP2gouK8TBUVGeUoLUpDTtfQgyuzbjiwz /J+X7pUeyYX14hkbVagy8jb2e9w/mpRXTKIrxnUKtQIIw6ihYuTPxKY1+/YaAwOPuOlP vAlzcVPC8m4K7DQyJdE83aJJbcNE0rAKsuOAUPPMulMa7LccWibT8Wn7SpAQYf1+x0Yg oSsMbSXaRbtPHQnUgXlA+8Im7jbVwGQbL2r2HIu8b8IvhxsYOCMSmoJqvd9DW98OHuWd 6YDA== X-Forwarded-Encrypted: i=1; AJvYcCVOkpvoPj65B7rRKuSnEvHYn8JwEKc0tWYkfVpOyZoxnEcpV0pOzqoypx7s1QeIw6CHcALQGxblhIe7hVY=@vger.kernel.org X-Gm-Message-State: AOJu0Yzx75Fqx5cd5mkZtoFEo2wLo1sX44ZeRR1eko9YWRWSRpiDf5Os frJH6amzSqPVxcM3TwjRtvqTmNkfTgIlLsHPbPXmTNcjsVqSWYfJAf+qNiskaNyU9h5DiJjtCfJ flO8kY46vzJM1Hv5gzISu4SpzM9xMCsbMsYDxvRbtJohUNyayJUQO7w+q1gbCKQoojg== X-Gm-Gg: AY/fxX4zj/OIxARnA9IfkgkYooitRGwE3aOZbdF8Ka1EqY11KdDlq1Hzh1CBOE2RmLa 5FMtOMbI+p7FB/3I83a8YvZ0Tx/toaGmzUSesD4wBXpPo/ABJV+hu5Cj0uRhbeJBLq1MblcijSV 9HGan7knhIZ+rWqy/vPae2QgtoQghllArgf5uemwFVTZwXx+PM4ejTihMugQV7jfokCRLFTrn3S +sZxD04J/BW6y+w8RRALIMLpgd9QSh3GAPMuuh495OfrTDgWPT5yu9Fk1LTC2C7PuHKAUlvAJU2 UqrYkDLK82lEvfcRrLZoKWbvWTbiLHRkW5lrMFoFPuBZN5Y60U+0wD8i0SydIm/h7peVas8fSZy 9Y8nu3Q4OQVKrZ6YqR3zWdYESU7kzoX43g3NfHIesPMBwaCdG0vixNSsm X-Received: by 2002:a05:622a:1dc9:b0:4ee:15b8:e9b with SMTP id d75a77b69052e-4f1d059d447mr204685401cf.42.1765940252944; Tue, 16 Dec 2025 18:57:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IGvLfGmBl88X2NZghAQPP2IephomEg/SdWdNt9iIkxql2JuNTR/XHEUjouPmUSaW4w4+zCfvw== X-Received: by 2002:a05:622a:1dc9:b0:4ee:15b8:e9b with SMTP id d75a77b69052e-4f1d059d447mr204685311cf.42.1765940252629; Tue, 16 Dec 2025 18:57:32 -0800 (PST) Received: from ?IPV6:2601:188:c102:b180:1f8b:71d0:77b1:1f6e? ([2601:188:c102:b180:1f8b:71d0:77b1:1f6e]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4f345b162f9sm25827451cf.4.2025.12.16.18.57.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Dec 2025 18:57:31 -0800 (PST) From: Waiman Long X-Google-Original-From: Waiman Long Message-ID: Date: Tue, 16 Dec 2025 21:57:30 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] lockdep: Add header and footer to surround warning reports To: Tzung-Bi Shih , Waiman Long Cc: Peter Zijlstra , Ingo Molnar , Will Deacon , Boqun Feng , linux-kernel@vger.kernel.org References: <20251215072640.2580384-1-tzungbi@kernel.org> <0ae3277b-bea5-40ce-8eaa-10bb8b47c46a@redhat.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/16/25 7:31 PM, Tzung-Bi Shih wrote: > On Tue, Dec 16, 2025 at 11:20:45AM -0500, Waiman Long wrote: >> On 12/15/25 2:26 AM, Tzung-Bi Shih wrote: >>> Add header and footer to improve log parsing and automated analysis. >>> This makes lockdep output easier to interpret. >>> >>> Signed-off-by: Tzung-Bi Shih >>> --- >>> v2: >>> - asm/bugs.h -> linux/bug.h. >>> >>> v1: https://lore.kernel.org/all/20251114062730.1828416-1-tzungbi@kernel.org/ >>> >>> kernel/locking/lockdep.c | 34 ++++++++++++++++++++++++++++++++++ >>> 1 file changed, 34 insertions(+) >>> >>> diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c >>> index 2d4c5bab5af8..adbc44c3808d 100644 >>> --- a/kernel/locking/lockdep.c >>> +++ b/kernel/locking/lockdep.c >>> @@ -58,6 +58,7 @@ >>> #include >>> #include >>> #include >>> +#include >>> #include >>> @@ -110,6 +111,11 @@ static __init int kernel_lockdep_sysctls_init(void) >>> late_initcall(kernel_lockdep_sysctls_init); >>> #endif /* CONFIG_SYSCTL */ >>> +static void print_footer(void) >>> +{ >>> + pr_warn("---[ end trace %016llx ]---\n", 0ULL); >> What is the purpose of putting 16 '0' in this "end trace" line? Is it >> related to how your parsing script works? > Mostly wanted to align to print_oops_end_marker() in kernel/panic.c. Before > e83a4472bf9f ("panic: remove oops_id"), it was an oops ID. My parsing script > doesn't rely on the 16 '0's but existing parsers might. > > I have no strong opinion. Should we just remove the 16 '0's here? These are warning messages, not panic. So I would prefer not to have them if they serve no useful purpose and can cause confusion. Cheers, Longman >