From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752413AbdHNNdS (ORCPT ); Mon, 14 Aug 2017 09:33:18 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:18310 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750994AbdHNNdQ (ORCPT ); Mon, 14 Aug 2017 09:33:16 -0400 Subject: Re: [v6 02/15] x86/mm: setting fields in deferred pages To: Michal Hocko Cc: linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-arm-kernel@lists.infradead.org, x86@kernel.org, kasan-dev@googlegroups.com, borntraeger@de.ibm.com, heiko.carstens@de.ibm.com, davem@davemloft.net, willy@infradead.org, ard.biesheuvel@linaro.org, will.deacon@arm.com, catalin.marinas@arm.com, sam@ravnborg.org References: <1502138329-123460-1-git-send-email-pasha.tatashin@oracle.com> <1502138329-123460-3-git-send-email-pasha.tatashin@oracle.com> <20170811090214.GD30811@dhcp22.suse.cz> <20170814114326.GH19063@dhcp22.suse.cz> From: Pasha Tatashin Message-ID: Date: Mon, 14 Aug 2017 09:32:01 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170814114326.GH19063@dhcp22.suse.cz> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/14/2017 07:43 AM, Michal Hocko wrote: >> register_page_bootmem_info >> register_page_bootmem_info_node >> get_page_bootmem >> .. setting fields here .. >> such as: page->freelist = (void *)type; >> >> free_all_bootmem() >> free_low_memory_core_early() >> for_each_reserved_mem_region() >> reserve_bootmem_region() >> init_reserved_page() <- Only if this is deferred reserved page >> __init_single_pfn() >> __init_single_page() >> memset(0) <-- Loose the set fields here! > OK, I have missed that part. Please make it explicit in the changelog. > It is quite easy to get lost in the deep call chains. Ok, will update comment.