From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752494AbcFIORh (ORCPT ); Thu, 9 Jun 2016 10:17:37 -0400 Received: from ducie-dc1.codethink.co.uk ([185.25.241.215]:51152 "EHLO ducie-dc1.codethink.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751815AbcFIORf (ORCPT ); Thu, 9 Jun 2016 10:17:35 -0400 Subject: Re: [PATCH] net: diag: add missing declarations To: Eric Dumazet References: <1465471048-13493-1-git-send-email-ben.dooks@codethink.co.uk> <1465481446.7945.40.camel@edumazet-glaptop3.roam.corp.google.com> Cc: linux-kernel@lists.codethink.co.uk, "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org From: Ben Dooks Organization: Codethink Limited. Message-ID: Date: Thu, 9 Jun 2016 15:17:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.1.0 MIME-Version: 1.0 In-Reply-To: <1465481446.7945.40.camel@edumazet-glaptop3.roam.corp.google.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/06/16 15:10, Eric Dumazet wrote: > On Thu, 2016-06-09 at 12:17 +0100, Ben Dooks wrote: >> The functions inet_diag_msg_common_fill and inet_diag_msg_attrs_fill >> seem to have been missed from the include/linux/inet_diag.h header >> file. Add them to fix the following warnings: >> >> net/ipv4/inet_diag.c:69:6: warning: symbol 'inet_diag_msg_common_fill' was not declared. Should it be static? >> net/ipv4/inet_diag.c:108:5: warning: symbol 'inet_diag_msg_attrs_fill' was not declared. Should it be static? >> >> Signed-off-by: Ben Dooks >> --- >> Cc: "David S. Miller" >> Cc: netdev@vger.kernel.org >> Cc: linux-kernel@vger.kernel.org >> --- >> include/linux/inet_diag.h | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/include/linux/inet_diag.h b/include/linux/inet_diag.h >> index 7c27fa1..feb04ea 100644 >> --- a/include/linux/inet_diag.h >> +++ b/include/linux/inet_diag.h >> @@ -52,6 +52,12 @@ struct sock *inet_diag_find_one_icsk(struct net *net, >> >> int inet_diag_bc_sk(const struct nlattr *_bc, struct sock *sk); >> >> +void inet_diag_msg_common_fill(struct inet_diag_msg *r, struct sock *sk); >> + >> +int inet_diag_msg_attrs_fill(struct sock *sk, struct sk_buff *skb, >> + struct inet_diag_msg *r, int ext, >> + struct user_namespace *user_ns); >> + >> extern int inet_diag_register(const struct inet_diag_handler *handler); >> extern void inet_diag_unregister(const struct inet_diag_handler *handler); >> #endif /* _INET_DIAG_H_ */ > > Please send a v2, deleting them from net/sctp/sctp_diag.c Ah, didn't spot those. Will send a second version thanks. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius