From: Javier Carrasco <javier.carrasco.cruz@gmail.com>
To: "Jonathan Cameron" <jic23@kernel.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"David Lechner" <dlechner@baylibre.com>,
"Antoniu Miclaus" <antoniu.miclaus@analog.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Cristian Pop" <cristian.pop@analog.com>,
"Mircea Caprioru" <mircea.caprioru@analog.com>,
"Alexandru Tachici" <alexandru.tachici@analog.com>,
"Marcus Folkesson" <marcus.folkesson@gmail.com>,
"Fabrice Gasnier" <fabrice.gasnier@st.com>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/8] iio: frequency: admv4420: add missing select REMAP_SPI in Kconfig
Date: Thu, 3 Oct 2024 21:30:26 +0200 [thread overview]
Message-ID: <b54239aa-9573-41e1-86f1-b38611443c46@gmail.com> (raw)
In-Reply-To: <20241003-ad2s1210-select-v1-4-4019453f8c33@gmail.com>
On 03/10/2024 18:49, Javier Carrasco wrote:
> This driver makes use of regmap_spi, but does not select the required
> module.
> Add the missing 'select REGMAP_SPI'.
>
> Fixes: b59c04155901 ("iio: frequency: admv4420.c: Add support for ADMV4420")
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
> ---
> drivers/iio/frequency/Kconfig | 17 +++++++++--------
> 1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/iio/frequency/Kconfig b/drivers/iio/frequency/Kconfig
> index 89ae09db5ca5..b90e1ac4b342 100644
> --- a/drivers/iio/frequency/Kconfig
> +++ b/drivers/iio/frequency/Kconfig
> @@ -92,14 +92,15 @@ config ADMV1014
> module will be called admv1014.
>
> config ADMV4420
> - tristate "Analog Devices ADMV4420 K Band Downconverter"
> - depends on SPI
> - help
> - Say yes here to build support for Analog Devices K Band
> - Downconverter with integrated Fractional-N PLL and VCO.
> -
> - To compile this driver as a module, choose M here: the
> - module will be called admv4420.
> + tristate "Analog Devices ADMV4420 K Band Downconverter"
> + depends on SPI
> + select REGMAP_SPI
> + help
> + Say yes here to build support for Analog Devices K Band
> + Downconverter with integrated Fractional-N PLL and VCO.
> +
> + To compile this driver as a module, choose M here: the
> + module will be called admv4420.
>
> config ADRF6780
> tristate "Analog Devices ADRF6780 Microwave Upconverter"
>
Note that I formatted the entry to use tabs instead of spaces, although
I forgot to add it to the commit message.
Best regards,
Javier Carrasco
next prev parent reply other threads:[~2024-10-03 19:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-03 16:49 [PATCH 0/8] iio: {amplifiers,dac,frequency,resolver}: add missing selects " Javier Carrasco
2024-10-03 16:49 ` [PATCH 1/8] iio: resolver: ad2s1210 add missing select REGMAP " Javier Carrasco
2024-10-03 22:44 ` David Lechner
2024-10-06 13:24 ` Jonathan Cameron
2024-10-03 16:49 ` [PATCH 2/8] iio: resolver: ad2s1210: add missing select (TRIGGERED_)BUFFER " Javier Carrasco
2024-10-03 22:44 ` David Lechner
2024-10-06 13:25 ` Jonathan Cameron
2024-10-03 16:49 ` [PATCH 3/8] iio: frequency: adf4377: add missing select REMAP_SPI " Javier Carrasco
2024-10-06 13:26 ` Jonathan Cameron
2024-10-03 16:49 ` [PATCH 4/8] iio: frequency: admv4420: " Javier Carrasco
2024-10-03 19:30 ` Javier Carrasco [this message]
2024-10-06 13:23 ` Jonathan Cameron
2024-10-03 16:49 ` [PATCH 5/8] iio: amplifiers: ada4250: add missing select REGMAP_SPI " Javier Carrasco
2024-10-06 13:29 ` Jonathan Cameron
2024-10-03 16:49 ` [PATCH 6/8] iio: dac: ad5770r: " Javier Carrasco
2024-10-06 13:28 ` Jonathan Cameron
2024-10-03 16:49 ` [PATCH 7/8] iio: dac: ltc1660: " Javier Carrasco
2024-10-06 13:30 ` Jonathan Cameron
2024-10-03 16:49 ` [PATCH 8/8] iio: dac: stm32-dac-core: add missing select REGMAP_MMIO " Javier Carrasco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b54239aa-9573-41e1-86f1-b38611443c46@gmail.com \
--to=javier.carrasco.cruz@gmail.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=alexandru.tachici@analog.com \
--cc=antoniu.miclaus@analog.com \
--cc=cristian.pop@analog.com \
--cc=dlechner@baylibre.com \
--cc=fabrice.gasnier@st.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcus.folkesson@gmail.com \
--cc=mircea.caprioru@analog.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®