From: "Nuno Sá" <noname.nuno@gmail.com>
To: David Lechner <dlechner@baylibre.com>,
Jonathan Cameron <jic23@kernel.org>
Cc: "Michael Hennerich" <michael.hennerich@analog.com>,
"Nuno Sá" <nuno.sa@analog.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: ad7944: add namespace to T_QUIET_NS
Date: Thu, 10 Oct 2024 10:32:44 +0200 [thread overview]
Message-ID: <b5427f9c7fdbd4b93ba7b355aaf44afde23b0026.camel@gmail.com> (raw)
In-Reply-To: <20241009-iio-adc-ad7944-add-namespace-to-t_quiet_ns-v1-1-a216357a065c@baylibre.com>
On Wed, 2024-10-09 at 16:26 -0500, David Lechner wrote:
> Add AD7944_ namespace to T_QUIET_NS. This is the preferred style. This
> way the bad style won't be copied when we add more T_ macros.
>
> Signed-off-by: David Lechner <dlechner@baylibre.com>
> ---
Reviewed-by: Nuno Sa <nuno.sa@analog.com>
> drivers/iio/adc/ad7944.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/adc/ad7944.c b/drivers/iio/adc/ad7944.c
> index 0f36138a7144..a5aea4e9f1a7 100644
> --- a/drivers/iio/adc/ad7944.c
> +++ b/drivers/iio/adc/ad7944.c
> @@ -80,7 +80,7 @@ struct ad7944_adc {
> };
>
> /* quite time before CNV rising edge */
> -#define T_QUIET_NS 20
> +#define AD7944_T_QUIET_NS 20
>
> static const struct ad7944_timing_spec ad7944_timing_spec = {
> .conv_ns = 420,
> @@ -150,7 +150,7 @@ static int ad7944_3wire_cs_mode_init_msg(struct device
> *dev, struct ad7944_adc *
> * CS is tied to CNV and we need a low to high transition to start
> the
> * conversion, so place CNV low for t_QUIET to prepare for this.
> */
> - xfers[0].delay.value = T_QUIET_NS;
> + xfers[0].delay.value = AD7944_T_QUIET_NS;
> xfers[0].delay.unit = SPI_DELAY_UNIT_NSECS;
>
> /*
>
> ---
> base-commit: 96be67caa0f0420d4128cb67f07bbd7a6f49e03a
> change-id: 20241009-iio-adc-ad7944-add-namespace-to-t_quiet_ns-a9ed69692718
>
> Best regards,
next prev parent reply other threads:[~2024-10-10 8:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 21:26 David Lechner
2024-10-10 8:32 ` Nuno Sá [this message]
2024-10-10 18:08 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5427f9c7fdbd4b93ba7b355aaf44afde23b0026.camel@gmail.com \
--to=noname.nuno@gmail.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®