From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96AE6382F1F for ; Thu, 16 Jul 2026 04:51:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784177513; cv=none; b=C1+ItfG1hUgIPKf1gJfqPE2wW8gRCh9npqIAywVPuQokhKoxCtRBawvPsaKj/iF+qn0iJNnLrMhE47bi24hE7Cm3c+IRylY1Wd5hX7H2J4cbYtuH1NUyFTcGiNN1e82TBYFzIJxcS/kQkxDCrlJJAOzM7oQUAANYh7qjtFTVX3g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784177513; c=relaxed/simple; bh=6aQWQo6sgVUPzOg+MljlyLS88DAAxWaIxb/1emP1IQM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HUWu7CvsAaOHQBJcJoODeptCp5JgWnU1LIwobwFAqFaOMuO3EqYnka8gLWFdgz2oZFxgtVUawn6O8pscnXd+pumFgHGDyXVikDB5K+Kpd3hT2lQ5YCo3ExHiFqjQVzSwXtHJ7Z3P6CvNEz4hcCd90vTOg6mNGF8S/W/9m5j+/7Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=cd3aCESd; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Chf1GMO7; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cd3aCESd"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Chf1GMO7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784177510; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pXVMGj2qEWMUPG1DsPQovOwGHTN54tYzirg/1nSfgGM=; b=cd3aCESdbErS4yAOOY8A1gy30YxSSFHxb5taIzsJcGswjyUncCM+n8uPrGhHRwzj0oTxOU RPGYXCw6RCB8hpcfJPC6gMLhyGAeg6Fkadl0sx8Y0jiaD6cHQLw0va9Xv83Srfc2WzAGi2 xmUDdGx25e4hgEhzdUrp8Qnpc0eLxKo= Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-613-_-k-G6hyPE-JlDfJmfSLrg-1; Thu, 16 Jul 2026 00:51:48 -0400 X-MC-Unique: _-k-G6hyPE-JlDfJmfSLrg-1 X-Mimecast-MFC-AGG-ID: _-k-G6hyPE-JlDfJmfSLrg_1784177508 Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2caf4173b1cso53674185ad.3 for ; Wed, 15 Jul 2026 21:51:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1784177508; x=1784782308; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=pXVMGj2qEWMUPG1DsPQovOwGHTN54tYzirg/1nSfgGM=; b=Chf1GMO7bvCxZrVFaCM8j5Y7zgjii9c7hWp1Xt90uLhqnr5KgqnfpnAoi/3JCinPho 7IiwkRT/3N7X0TrCdKw6wXwj59/PDekhgy8MCL3D3ruuAm/z6pnCPqED8f172zsdH50p bNJ8+oYBj9wbtZOPpoRWu7+nSS58rbqomTEsqWSIz8OparBvUg5EaePB9Og8t5TXmOjf eOpaE2zZJVUfiZw+/ecg2JCV1nAsaaCj9Jh4jkGqoYeHi/iCGuzfPIGj5gqUH57AAsGf x2r/xXll2VGUxQkCbOuI6dqpVXbSghafq+8z6nmzPifiNcfBCC0XAgujgiY2AmDL+Vs0 ph+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784177508; x=1784782308; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=pXVMGj2qEWMUPG1DsPQovOwGHTN54tYzirg/1nSfgGM=; b=EW95hQS4lONJBQWXbc9nOYnoNFUw0P+M9eRzNf92/DoeqIk9r8FzXOg3FLLyDbATBQ nttfMWelYGzSXcvtixjI10fXqXZVyl1hb5KMbohUtBbBJVli/K5pWBminQiZLy7gXz2Y pJa/SmGhEfDVyo3zIYZSz8o4SaPAwKtDGR7wWqchUWQGY9hC4qIqfT+X0zccjX6xy+X9 vuBacueGG5o/rNvTXEaIo6/XuwVl+jQwuKbAfLpgimYg51lk+Kq6RzR9HYeg0jsmc9qT lmrZsGTJN+J5OoLTFnnXfMx+UNVfvsXE6Fsw4psLe4HV3a+PRFnixR5ipCeHteGdv9ag Sn1g== X-Forwarded-Encrypted: i=1; AHgh+Ro7pr79WvJJWw4MsXDEyhWk0ka0nIdFmXjjWRyiEa9mJwqzoAwAe5eu1FTtU8KiestT5M/rkyQ8PX7H5SM=@vger.kernel.org X-Gm-Message-State: AOJu0YzjeUDwKhRicpT82NLcPFa3TrxuCCskAVZd1nX5L8aMWOWi7OTI L611/oEyf/hGtb0ASjlCmyYUuSCCgtDFfjLke3qAd1ks27tMkBsJg+0SYlzTONwEbxlmBBRrQh/ mrVerPWaRpg/kqZ5zfL5w1ai1ubAgvLMeFtZGm8XLUK8WYxkUFhkC6up93iWbCUu+VQ== X-Gm-Gg: AfdE7cltlvjN+kkWxULTURdZYdSqCjGCegDl9mbBvOIde1dEy5vRwNC6o1YiPgu+9Al FDHuVBv5ZCj/3zRn93ciNCpg+uizByQMx8315SqzE1BWOp3NgbFdJd3I+y9tYA7YTHjLSMjwTdf j46PSUKPcl4XOY6FxiECuDoRAZZYENxDNtJ70QzC5cdCFAcSQUH1y+Bp8QddIiY/K0OtWbn8hSY xVcEq11DY1CzIZ3/LSmuagPkAhZAZLilhz8TMHmZePZj2D3zYADuYGVNWA45eP9M0PGcpnVWw4a eCk20r+EzRUQahahOPVE9FYnGv5/7AR0FEG2Kf5FSqaeh2+jpaFfrdYescO1RKIJqehQ4Pu/tA0 4NMC3zc9QT3I0Q8SRWAIwLmNVQ9AuhyFXWxoWWUZyJtM= X-Received: by 2002:a17:903:2bcc:b0:2cc:77f3:a934 with SMTP id d9443c01a7336-2ce9f174650mr178857075ad.46.1784177507849; Wed, 15 Jul 2026 21:51:47 -0700 (PDT) X-Received: by 2002:a17:903:2bcc:b0:2cc:77f3:a934 with SMTP id d9443c01a7336-2ce9f174650mr178856915ad.46.1784177507406; Wed, 15 Jul 2026 21:51:47 -0700 (PDT) Received: from [192.168.68.51] (n175-34-8-244.mrk21.qld.optusnet.com.au. [175.34.8.244]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf100e44e1sm13300595ad.6.2026.07.15.21.51.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Jul 2026 21:51:46 -0700 (PDT) Message-ID: Date: Thu, 16 Jul 2026 14:51:41 +1000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 09/11] arm_mpam: resctrl: Make read_mon_cdp_safe() self consistent To: Ben Horgan Cc: james.morse@arm.com, reinette.chatre@intel.com, fenghuay@nvidia.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dave.martin@arm.com, andre.przywara@arm.com References: <20260710115546.29644-1-ben.horgan@arm.com> <20260710115546.29644-10-ben.horgan@arm.com> Content-Language: en-US From: Gavin Shan In-Reply-To: <20260710115546.29644-10-ben.horgan@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/10/26 9:55 PM, Ben Horgan wrote: > When read_mon_cdp_safe() is called with cdp_enabled equal to false then the > reading returned in val is the sum of the monitor values for the given > component. However, when cdp_enabled equal to true it is again the sum of > the monitor values but with the initial value of val also added. > > Change the cdp_enabled equals true case to match the false case. All > callers zero the val before calling and so no functional change is > anticipated. > > Signed-off-by: Ben Horgan > --- > drivers/resctrl/mpam_resctrl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Gavin Shan