From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: "AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Bernhard Rosenkränzer" <bero@baylibre.com>,
rafael@kernel.org, amitk@kernel.org, rui.zhang@intel.com,
matthias.bgg@gmail.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, rdunlap@infradead.org,
ye.xingchen@zte.com.cn, p.zabel@pengutronix.de,
"Alexandre Mergnat" <amergnat@baylibre.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org,
wenst@chromium.org, james.lo@mediatek.com,
rex-bc.chen@mediatek.com, nfraprado@collabora.com,
abailon@baylibre.com, amergnat@baylibre.com,
khilman@baylibre.com
Subject: Re: [PATCH v4 2/5] thermal/drivers/mediatek/lvts_thermal: Add suspend and resume
Date: Wed, 23 Aug 2023 09:48:19 +0200 [thread overview]
Message-ID: <b544e079-c9de-23d3-80f7-cff89293eeb5@linaro.org> (raw)
In-Reply-To: <371790cd-5a7c-8fa6-cc38-3a3680525092@collabora.com>
On 31/05/2023 10:05, AngeloGioacchino Del Regno wrote:
[ ... ]
>> static const struct lvts_ctrl_data mt8195_lvts_mcu_data_ctrl[] = {
>> {
>> .cal_offset = { 0x04, 0x07 },
>> @@ -1268,6 +1300,8 @@ MODULE_DEVICE_TABLE(of, lvts_of_match);
>> static struct platform_driver lvts_driver = {
>> .probe = lvts_probe,
>> .remove = lvts_remove,
>> + .suspend = lvts_suspend,
>
> Should we do that in noirq handlers?
> We're risking to miss a thermal interrupt.
I'm not sure missing a thermal interrupt is a problem in this context
but we may go in the irq routine with an undefined state sensor setup
(eg. the internal clock stopped in the suspend and then read the sensor
in the isr).
IMO, using suspend_noirq and resume_noirq may be required here.
Alexandre are you taking over the next iteration?
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2023-08-23 7:48 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 19:51 [PATCH v4 0/5] Add LVTS support for mt8192 Bernhard Rosenkränzer
2023-05-30 19:51 ` [PATCH v4 1/5] dt-bindings: thermal: mediatek: Add LVTS thermal controller definition " Bernhard Rosenkränzer
2023-05-30 19:51 ` [PATCH v4 2/5] thermal/drivers/mediatek/lvts_thermal: Add suspend and resume Bernhard Rosenkränzer
2023-05-31 8:05 ` AngeloGioacchino Del Regno
2023-08-23 7:48 ` Daniel Lezcano [this message]
2023-09-25 14:52 ` Alexandre Mergnat
2023-05-30 19:51 ` [PATCH v4 3/5] thermal/drivers/mediatek/lvts_thermal: Add mt8192 support Bernhard Rosenkränzer
2023-05-31 8:07 ` AngeloGioacchino Del Regno
2023-07-04 6:23 ` Chen-Yu Tsai
2023-07-04 6:22 ` Chen-Yu Tsai
2023-05-30 19:51 ` [PATCH v4 4/5] arm64: dts: mediatek: mt8192: Add thermal nodes and thermal zones Bernhard Rosenkränzer
2023-05-31 7:45 ` Chen-Yu Tsai
2023-05-31 8:03 ` AngeloGioacchino Del Regno
2023-05-30 19:51 ` [PATCH v4 5/5] thermal/drivers/mediatek/lvts_thermal: Update calibration data documentation Bernhard Rosenkränzer
2023-05-31 4:49 ` [PATCH v4 0/5] Add LVTS support for mt8192 Chen-Yu Tsai
2023-06-01 17:09 ` Nícolas F. R. A. Prado
2023-06-05 7:52 ` AngeloGioacchino Del Regno
2023-06-08 9:39 ` Daniel Lezcano
2023-06-15 19:17 ` Nícolas F. R. A. Prado
2023-06-16 14:14 ` Daniel Lezcano
2023-06-16 19:12 ` Nícolas F. R. A. Prado
2023-06-08 10:06 ` Daniel Lezcano
2023-08-16 19:57 ` Nícolas F. R. A. Prado
2023-08-16 20:49 ` Daniel Lezcano
2023-08-16 21:02 ` Nícolas F. R. A. Prado
2023-08-17 8:45 ` Chen-Yu Tsai
2023-08-17 11:39 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b544e079-c9de-23d3-80f7-cff89293eeb5@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=abailon@baylibre.com \
--cc=amergnat@baylibre.com \
--cc=amitk@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bero@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=james.lo@mediatek.com \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=nfraprado@collabora.com \
--cc=p.zabel@pengutronix.de \
--cc=rafael@kernel.org \
--cc=rdunlap@infradead.org \
--cc=rex-bc.chen@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=wenst@chromium.org \
--cc=ye.xingchen@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®