From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Forest Bond <forest@alittletooquiet.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH 1/7] staging: vt6655: Rename dwData to reg_value in four macros
Date: Mon, 18 Jul 2022 00:20:08 +0200 [thread overview]
Message-ID: <b54577316eebdbb54e478fc51473eeba9d7eacae.1658094708.git.philipp.g.hortmann@gmail.com> (raw)
In-Reply-To: <cover.1658094708.git.philipp.g.hortmann@gmail.com>
Fix name of a variable in four macros that use CamelCase which is not
accepted by checkpatch.pl
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
---
drivers/staging/vt6655/mac.h | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h
index b307161818a0..bfcbeb96f839 100644
--- a/drivers/staging/vt6655/mac.h
+++ b/drivers/staging/vt6655/mac.h
@@ -539,9 +539,9 @@
#define MACvReceive0(iobase) \
do { \
- unsigned long dwData; \
- dwData = ioread32(iobase + MAC_REG_RXDMACTL0); \
- if (dwData & DMACTL_RUN) \
+ unsigned long reg_value; \
+ reg_value = ioread32(iobase + MAC_REG_RXDMACTL0); \
+ if (reg_value & DMACTL_RUN) \
iowrite32(DMACTL_WAKE, iobase + MAC_REG_RXDMACTL0); \
else \
iowrite32(DMACTL_RUN, iobase + MAC_REG_RXDMACTL0); \
@@ -549,9 +549,9 @@ do { \
#define MACvReceive1(iobase) \
do { \
- unsigned long dwData; \
- dwData = ioread32(iobase + MAC_REG_RXDMACTL1); \
- if (dwData & DMACTL_RUN) \
+ unsigned long reg_value; \
+ reg_value = ioread32(iobase + MAC_REG_RXDMACTL1); \
+ if (reg_value & DMACTL_RUN) \
iowrite32(DMACTL_WAKE, iobase + MAC_REG_RXDMACTL1); \
else \
iowrite32(DMACTL_RUN, iobase + MAC_REG_RXDMACTL1); \
@@ -559,9 +559,9 @@ do { \
#define MACvTransmit0(iobase) \
do { \
- unsigned long dwData; \
- dwData = ioread32(iobase + MAC_REG_TXDMACTL0); \
- if (dwData & DMACTL_RUN) \
+ unsigned long reg_value; \
+ reg_value = ioread32(iobase + MAC_REG_TXDMACTL0); \
+ if (reg_value & DMACTL_RUN) \
iowrite32(DMACTL_WAKE, iobase + MAC_REG_TXDMACTL0); \
else \
iowrite32(DMACTL_RUN, iobase + MAC_REG_TXDMACTL0); \
@@ -569,9 +569,9 @@ do { \
#define MACvTransmitAC0(iobase) \
do { \
- unsigned long dwData; \
- dwData = ioread32(iobase + MAC_REG_AC0DMACTL); \
- if (dwData & DMACTL_RUN) \
+ unsigned long reg_value; \
+ reg_value = ioread32(iobase + MAC_REG_AC0DMACTL); \
+ if (reg_value & DMACTL_RUN) \
iowrite32(DMACTL_WAKE, iobase + MAC_REG_AC0DMACTL); \
else \
iowrite32(DMACTL_RUN, iobase + MAC_REG_AC0DMACTL); \
--
2.37.1
next prev parent reply other threads:[~2022-07-17 22:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-17 22:20 [PATCH 0/7] staging: vt6655: Convert four macros to one function Philipp Hortmann
2022-07-17 22:20 ` Philipp Hortmann [this message]
2022-07-18 6:07 ` [PATCH 1/7] staging: vt6655: Rename dwData to reg_value in four macros Joe Perches
2022-07-18 19:33 ` Philipp Hortmann
2022-07-17 22:20 ` [PATCH 2/7] staging: vt6655: Rename MACvReceive0 Philipp Hortmann
2022-07-17 22:20 ` [PATCH 3/7] staging: vt6655: Convert macro vt6655_mac_dma_ctl to function Philipp Hortmann
2022-07-17 22:20 ` [PATCH 4/7] staging: vt6655: Add parameter to function vt6655_mac_dma_ctl Philipp Hortmann
2022-07-17 22:20 ` [PATCH 5/7] staging: vt6655: Replace MACvReceive1 with " Philipp Hortmann
2022-07-18 12:41 ` Dan Carpenter
2022-07-18 20:00 ` Philipp Hortmann
2022-07-19 10:04 ` Dan Carpenter
2022-07-17 22:20 ` [PATCH 6/7] staging: vt6655: Replace MACvTransmit0 " Philipp Hortmann
2022-07-17 22:20 ` [PATCH 7/7] staging: vt6655: Replace MACvTransmitAC0 " Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b54577316eebdbb54e478fc51473eeba9d7eacae.1658094708.git.philipp.g.hortmann@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®