From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B4E1CCA48C for ; Sat, 23 Jul 2022 18:47:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233326AbiGWSrY (ORCPT ); Sat, 23 Jul 2022 14:47:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231370AbiGWSrU (ORCPT ); Sat, 23 Jul 2022 14:47:20 -0400 Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D56F918B33 for ; Sat, 23 Jul 2022 11:47:19 -0700 (PDT) Received: by mail-pf1-x431.google.com with SMTP id c3so7001291pfb.13 for ; Sat, 23 Jul 2022 11:47:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sudomaker-com.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=rsPZ3UqbP1l4DXR/Tzlf3U3kRDsFMBo5YFbvYGqZy2I=; b=bVkOWnq0tkioZ9fnbzZDHzlJG1CDmxY4gphW04FvQO8G7UWdyXyK5Jd+jg4CdK9zh9 PfjWs6VRu4RV0QjXvroA+QEpIA7QY30xpCN8T991BsrRxMFH9Sh39EBSxxCeuxGvAJzY UVJJic2IqkXRPyLKgzyyzxmvQg9bF5Vf/3eiAoRSZ1V9DXjwvMHFjVl7LH49Rel+JxGp pl8Z1vDW04v0twYFMijKhy3Jls37IAVV/jmtzur3c3jFBlQ5G6dJ4WiDF8GYVpfLs6TQ xsO1G2rk6yPQQ13LgWktZ6GBqadQ2vzWYDLJBHrPD0xSmuRZlEf6HUBJBkvCTSsr5rNF mrPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=rsPZ3UqbP1l4DXR/Tzlf3U3kRDsFMBo5YFbvYGqZy2I=; b=Wse+LKdZuYl2esRnGR5wAo2eFbhlY/JGPnDAjC/DHTV/yT3ud0XQ+Jhzc4JvRmDX47 Z0N7TlbZ1ExLu52H13sR+G4WuQ0cxY3JCjuKKEfx0amSm2OcNf3WRn+kTVDv1mnPnVQa fexVzPI+lgeMHe3ou4lkBShry6sX5aLv69iktOpFDOj5O6hkBZkXjczlj7L4zjyIl3UU NbpOZNa5xCsihLoW3iGsx6TUFZKarZUlM9iYGgqRUhYa7y008wDkYVuyFcCgAj4npm2O VooXpZ7IIKjvSELaIQ0HPPowriSbStmauqzhjEUq+Mn4AXSRZ+bkfwh52YCgM5VHCj/V C4Zg== X-Gm-Message-State: AJIora+k6YX27bGfTBeFJjkcfXmsfX62pdr5j/xeCWVN+dHzU3Apkasb Tx1hWhSTvOILsJv8Sr+IDYmJ/A== X-Google-Smtp-Source: AGRyM1vQleftizVLXtsyJEZpL+3neARgOltR9mQLjOc8T9CFophol9eh39QEwr/9Qs0tk1aR4aif4A== X-Received: by 2002:a63:eb02:0:b0:41a:716c:bfb1 with SMTP id t2-20020a63eb02000000b0041a716cbfb1mr4915469pgh.198.1658602039237; Sat, 23 Jul 2022 11:47:19 -0700 (PDT) Received: from [172.16.24.11] ([188.214.106.178]) by smtp.gmail.com with ESMTPSA id n9-20020a170903110900b0016be4d78792sm6054287plh.257.2022.07.23.11.47.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 23 Jul 2022 11:47:18 -0700 (PDT) Message-ID: Date: Sun, 24 Jul 2022 02:47:14 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 2/3] dt-bindings: SPI: Add Ingenic SFC bindings. Content-Language: en-US To: Krzysztof Kozlowski , Zhou Yanjie , tudor.ambarus@microchip.com, p.yadav@ti.com, michael@walle.cc, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, broonie@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, aidanmacdonald.0x0@gmail.com, tmn505@gmail.com, paul@crapouillou.net, dongsheng.qiu@ingenic.com, aric.pzqi@ingenic.com, rick.tyliu@ingenic.com, jinghui.liu@ingenic.com, sernia.zhou@foxmail.com References: <1658508510-15400-1-git-send-email-zhouyanjie@wanyeetech.com> <1658508510-15400-3-git-send-email-zhouyanjie@wanyeetech.com> <487a93c4-3301-aefd-abba-aabf4cb8ec90@linaro.org> <37062a5d-9da3-fbaf-89bd-776f32be36d9@wanyeetech.com> From: Mike Yang In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/24/22 01:43, Krzysztof Kozlowski wrote: > On 23/07/2022 18:50, Zhou Yanjie wrote: >> Hi Krzysztof, >> >> On 2022/7/23 上午1:46, Krzysztof Kozlowski wrote: >>> On 22/07/2022 18:48, 周琰杰 (Zhou Yanjie) wrote: >>>> Add the SFC bindings for the X1000 SoC, the X1600 SoC, the X1830 SoC, >>>> and the X2000 SoC from Ingenic. >>>> >>>> Signed-off-by: 周琰杰 (Zhou Yanjie) >>>> --- >>>> .../devicetree/bindings/spi/ingenic,sfc.yaml | 64 ++++++++++++++++++++++ >>>> 1 file changed, 64 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/spi/ingenic,sfc.yaml >>>> >>>> diff --git a/Documentation/devicetree/bindings/spi/ingenic,sfc.yaml b/Documentation/devicetree/bindings/spi/ingenic,sfc.yaml >>>> new file mode 100644 >>>> index 00000000..b7c4cf4 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/spi/ingenic,sfc.yaml >>>> @@ -0,0 +1,64 @@ >>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>>> +%YAML 1.2 >>>> +--- >>>> +$id: http://devicetree.org/schemas/spi/ingenic,sfc.yaml# >>> File name should be rather based on first compatible, so >>> ingenic,x1000-sfc.yaml >> >> >> No offense, does it really need to be named that way? >> I can't seem to find documentation with instructions on this :( >> >> The use of "ingenic,sfc.yaml" indicates that this is the documentation >> for the SFC module for all Ingenic SoCs, without misleading people into >> thinking it's only for a specific model of SoC. And there seem to be many >> other yaml documents that use similar names (eg. fsl,spi-fsl-qspi.yaml, >> spi-rockchip.yaml, spi-nxp-fspi.yaml, ingenic,spi.yaml, spi-sifive.yaml, >> omap-spi.yaml), maybe these yaml files that are not named with first >> compatible are also for the same consideration. :) > > We have many bad examples, many poor patterns and they are never an > argument to add one more bad pattern. Zhou already mentioned he was unable find the naming guidelines of these .yaml files. Apparently you think it's unacceptable for new contributors of a certain subsystem to use existing code as examples, and/or they're responsible for figuring out what's a good example and what's a bad one in the existing codebase. > > It might never grow to new devices (because they might be different), so > that is not really an argument. It is an argument. A very valid one. "they *might* be different". You may want to get your hands on real hardware and try another word. Or at least read the datasheets instead of believing your imagination. I would enjoy duplicating the st,stm32-spi.yaml into st,stm32{f,h}{0..7}-spi.yaml if I'm bored at a Sunday afternoon. > > All bindings are to follow this rule, so I don't understand why you > think it is an exception for you? Zhou didn't ask you to make an exception. They have a valid point and they're asking why. You may want to avoid further incidents of this kind by stop being bossy and actually writing a guideline of naming these .yaml files and publish it somewhere online. > > > Best regards, > Krzysztof Best regards, Mike Yang