From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DAAB211A19 for ; Fri, 10 Jan 2025 16:20:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736526006; cv=none; b=qQ7MwKJumT4fvHPghoOPzVeSa8g0VlegVGfQTqkkVOyzv4h6He9aphlXp39qZ0X5n6IjbFMH+EXT6ZzdbaHqcJvCGG3R/prNW+aYDXoHpR3rlN9wtUObKlg9xFOomvJWcciFfzVWcRYH8fzjLPfVap4PUAejzJgRBxArUYpHFlY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736526006; c=relaxed/simple; bh=LfO5NtmrRigh9PZ5WsKef2+DOUv+nqzrA0hyxGiq4LQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Y/qztPWIIcZ/NWdVPWtCJTxviTY1sQ6ObWjVw/Sz/Ke/8smK5546EH93Vq8al8Ps1AwTVttz1YMmqaguC4CMpouVIv5BLA8bpRUg7lW1ufEkvOyT9EN0AAWUT8s307+pKPupZuOvtPeJGeYKdNeN+pf9UpgIE9hiPrDseH4ZNLM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=jDXNps73; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="jDXNps73" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736526003; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=xrg4w41F8Fa4wXsT3QC0i8YlA5eRrP6zqdZYThRVB38=; b=jDXNps73ZOkjMOYqYLCHLXqcIekumHAcTcPOiwuVtEybfZHZ4+d1Kc/7EB0D7iTW+A84U6 I6VkNFjs/xNoft/SLTnj8rtzd8S015iLWq1o13SW8z+Ct+fYEvZyR4SbBGzdOsLimee3LQ NfJ+Ces1K3dVvdSFPs7XrL9Vm3erP5E= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-311-4U92nxFJPDmYLpP1hLpw9g-1; Fri, 10 Jan 2025 11:20:01 -0500 X-MC-Unique: 4U92nxFJPDmYLpP1hLpw9g-1 X-Mimecast-MFC-AGG-ID: 4U92nxFJPDmYLpP1hLpw9g Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3862e986d17so921826f8f.3 for ; Fri, 10 Jan 2025 08:20:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736526000; x=1737130800; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=xrg4w41F8Fa4wXsT3QC0i8YlA5eRrP6zqdZYThRVB38=; b=pvzVkfuFc0bRBYMdZ49/kttv71qJN68NB1gS71cGUc9KCNtak3OF07HyVl9/jZYEy6 MEDOLyYAVIEp/gZYI4RgYx+xfizSGFdoa+u1J662d0K7ZnsbHVzsRuuxgmWPOt1y8AYg +jxcvJzSSq9h4de81qWzr10fb1LXxZvYdoI4bTifAM+RQEdXgHZmtkr0Apk4En18dgBv mRqC+mZss23g4p6BQlsnvQTA5U4nGXrZSmn2w49lpp6mWlUYY2oMx8uYtWJuT4hz1GTo KKAPIpIR0E/7CA6Elhn5avlH8+MdRtS6M/3pI87NYLyEn2Sd8nRuVVfIewM2kL3GNAtf OK/g== X-Forwarded-Encrypted: i=1; AJvYcCVPcT6uY3gr1RJTLQKxyMj8qtO9I1j61vul/fFuUhA5FqFM5HdEqlyxRLy35BHULaTMw7R/Kj5zfjAA+0M=@vger.kernel.org X-Gm-Message-State: AOJu0Ywt3aXPFpbW6BgZA9xkIYp1whYs372IvBAGsH6ux8H4hXu9PilT bkxMnw6HIgcEEp9dx+QtxcpvQbOuQ6I7cxvpPiwbFC47+dyj/nPXZgOZkrlE6lVe4oexQI7dSQu n1ecl8eT6s8VNcjcl7ZqX0QT6oz5M0oGSJvl6jYm+5+enitNBovJGqBqaca0tfvgPlC49jNIT X-Gm-Gg: ASbGncurwz9ICIv8ibACbu6oOphic10pEPPdZzn4iPKa8jzkdD+ET9CGMAmhjSHFrno n6zBvrJ4q95oiuoR4d+vkjIW2254HBwZkVOaIsF+T0EnO2/Ppo5SMeRUcV9tFmjNFAAme2lMfhv Os45ekRha3r5VKSkVdOQCfNFbDV8g7dlM5t3guY9EVVliLgL174peF9DQiWpg4OBqyoNlViBJyk EVPkZXgK7W41Q0co8eTZ4FdWJ6/yG8m+SY6+FTzzSMyqpLmA/eCHKqij31I19nFZSB9FGK6ZSxj W1jO5r4hxvBQzbaH+DAJZEOgFKyNEkknLFFmLEKawBZvdazUmSEQPUSAIPauASnQre7yXdiBc+f rfc7fdYkb X-Received: by 2002:a5d:5886:0:b0:385:f840:e613 with SMTP id ffacd0b85a97d-38a87356509mr11333558f8f.51.1736525998572; Fri, 10 Jan 2025 08:19:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IFtxCS7/Q01iPcwNdGFYgyoc6QPzufvSf+XWiJsXom86jp7GTUL4gjTZorh65W20cVFC4gycQ== X-Received: by 2002:a5d:5886:0:b0:385:f840:e613 with SMTP id ffacd0b85a97d-38a87356509mr11333456f8f.51.1736525996644; Fri, 10 Jan 2025 08:19:56 -0800 (PST) Received: from ?IPV6:2003:cb:c708:e100:4f41:ff29:a59f:8c7a? (p200300cbc708e1004f41ff29a59f8c7a.dip0.t-ipconnect.de. [2003:cb:c708:e100:4f41:ff29:a59f:8c7a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a8e37d2f5sm4952880f8f.17.2025.01.10.08.19.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jan 2025 08:19:55 -0800 (PST) Message-ID: Date: Fri, 10 Jan 2025 17:19:54 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [syzbot] [mm?] WARNING in __folio_rmap_sanity_checks (2) To: Matthew Wilcox Cc: syzbot , akpm@linux-foundation.org, hdanton@sina.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com References: <676fee37.050a0220.2f3838.0497.GAE@google.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10.01.25 17:14, Matthew Wilcox wrote: > On Fri, Jan 10, 2025 at 04:48:03PM +0100, David Hildenbrand wrote: >> On 28.12.24 13:25, syzbot wrote: >>> syzbot has found a reproducer for the following issue on: >>> >>> HEAD commit: 8155b4ef3466 Add linux-next specific files for 20241220 >>> git tree: linux-next >>> console output: https://syzkaller.appspot.com/x/log.txt?x=1661050f980000 >>> kernel config: https://syzkaller.appspot.com/x/.config?x=9c90bb7161a56c88 >>> dashboard link: https://syzkaller.appspot.com/bug?extid=c0673e1f1f054fac28c2 >>> compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40 >>> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=17438af8580000 >>> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=101006df980000 >>> >>> Downloadable assets: >>> disk image: https://storage.googleapis.com/syzbot-assets/98a974fc662d/disk-8155b4ef.raw.xz >>> vmlinux: https://storage.googleapis.com/syzbot-assets/2dea9b72f624/vmlinux-8155b4ef.xz >>> kernel image: https://storage.googleapis.com/syzbot-assets/593a42b9eb34/bzImage-8155b4ef.xz >>> mounted in repro: https://storage.googleapis.com/syzbot-assets/5f780361c9ef/mount_0.gz >>> >>> IMPORTANT: if you fix the issue, please add the following tag to the commit: >>> Reported-by: syzbot+c0673e1f1f054fac28c2@syzkaller.appspotmail.com >>> >>> xfs_vn_setattr+0x25d/0x320 fs/xfs/xfs_iops.c:1065 >>> notify_change+0xbca/0xe90 fs/attr.c:552 >>> do_truncate+0x220/0x310 fs/open.c:65 >>> do_ftruncate+0x4a1/0x540 fs/open.c:192 >>> do_sys_ftruncate fs/open.c:207 [inline] >>> __do_sys_ftruncate fs/open.c:212 [inline] >>> __se_sys_ftruncate fs/open.c:210 [inline] >>> __x64_sys_ftruncate+0x94/0xf0 fs/open.c:210 >>> do_syscall_x64 arch/x86/entry/common.c:52 [inline] >>> do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 >>> entry_SYSCALL_64_after_hwframe+0x77/0x7f >>> ------------[ cut here ]------------ >>> WARNING: CPU: 1 PID: 11276 at ./include/linux/rmap.h:217 __folio_rmap_sanity_checks+0x369/0x590 include/linux/rmap.h:217 >>> Modules linked in: >>> CPU: 1 UID: 0 PID: 11276 Comm: syz-executor139 Not tainted 6.13.0-rc3-next-20241220-syzkaller #0 >>> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024 >>> RIP: 0010:__folio_rmap_sanity_checks+0x369/0x590 include/linux/rmap.h:217 >>> Code: 0f 0b 90 e9 e9 fd ff ff e8 64 cb ab ff 48 ff cb e9 34 fe ff ff e8 57 cb ab ff 4c 89 e7 48 c7 c6 e0 a7 15 8c e8 08 a4 f5 ff 90 <0f> 0b 90 e9 25 fe ff ff e8 3a cb ab ff 4c 89 e7 48 c7 c6 40 a9 15 >>> RSP: 0018:ffffc9000e67efd8 EFLAGS: 00010246 >>> RAX: 8577b516ce8a9400 RBX: ffffea0001a58080 RCX: ffffc9000e67eb03 >>> RDX: 0000000000000005 RSI: ffffffff8c0aaba0 RDI: ffffffff8c5fed00 >>> RBP: 00000000000024c0 R08: ffffffff901ab1f7 R09: 1ffffffff203563e >>> R10: dffffc0000000000 R11: fffffbfff203563f R12: ffffea0001a50000 >>> R13: ffffea0001a55c00 R14: 0000000000000000 R15: 0000000000000093 >>> FS: 00007f885c85f6c0(0000) GS:ffff8880b8700000(0000) knlGS:0000000000000000 >>> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 >>> CR2: 00007f88545b7000 CR3: 000000007fea2000 CR4: 00000000003526f0 >>> DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 >>> DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 >>> Call Trace: >>> >>> __folio_add_rmap mm/rmap.c:1170 [inline] >>> __folio_add_file_rmap mm/rmap.c:1489 [inline] >>> folio_add_file_rmap_ptes+0x82/0x380 mm/rmap.c:1511 >>> set_pte_range+0x30c/0x750 mm/memory.c:5136 >> >> If I would have to guess, I would assume that we have a refcount issue such >> that we succeed in splitting a folio while concurrently mapping it. > > That would seem hard to accomplish, because both hold the folio lock, > so it wouldn't be just a refcount bug but also a locking bug. Not sure > what this is though. Yeah, but we also have https://lkml.kernel.org/r/6774bf44.050a0220.25abdd.098a.GAE@google.com -- Cheers, David / dhildenb