From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752477AbdLUJTb (ORCPT <rfc822;w@1wt.eu>);
        Thu, 21 Dec 2017 04:19:31 -0500
Received: from foss.arm.com ([217.140.101.70]:60160 "EHLO foss.arm.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751608AbdLUJT1 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 21 Dec 2017 04:19:27 -0500
Subject: Re: [PATCH v2 2/2] sched/fair: Update blocked load from newly idle
 balance
To: Peter Zijlstra <peterz@infradead.org>,
        Brendan Jackman <brendan.jackman@arm.com>
Cc: Vincent Guittot <vincent.guittot@linaro.org>,
        Ingo Molnar <mingo@kernel.org>, linux-kernel@vger.kernel.org,
        Ingo Molnar <mingo@redhat.com>,
        Morten Rasmussen <morten.rasmussen@arm.com>
References: <20171201180157.18937-1-brendan.jackman@arm.com>
 <20171201180157.18937-3-brendan.jackman@arm.com>
 <20171220142202.2x7yx3w43wxfel7d@hirez.programming.kicks-ass.net>
From: Dietmar Eggemann <dietmar.eggemann@arm.com>
Message-ID: <b56fe5c1-c5f7-2a59-9f7c-8d0ac8e04cc2@arm.com>
Date: Thu, 21 Dec 2017 10:19:22 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <20171220142202.2x7yx3w43wxfel7d@hirez.programming.kicks-ass.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/20/2017 03:22 PM, Peter Zijlstra wrote:
> On Fri, Dec 01, 2017 at 06:01:57PM +0000, Brendan Jackman wrote:
>> @@ -7913,6 +7928,29 @@ static inline void update_sd_lb_stats(struct lb_env *env, struct sd_lb_stats *sd
>>   	if (child && child->flags & SD_PREFER_SIBLING)
>>   		prefer_sibling = 1;
>>   
>> +#ifdef CONFIG_NO_HZ_COMMON
>> +	if (env->idle == CPU_NEWLY_IDLE) {
>> +		int cpu;
>> +
>> +		/* Update the stats of NOHZ idle CPUs in the sd */
>> +		for_each_cpu_and(cpu, sched_domain_span(env->sd),
>> +				 nohz.idle_cpus_mask) {
>> +			struct rq *rq = cpu_rq(cpu);
>> +
>> +			/* ... Unless we've already done since the last tick */
>> +			if (time_after(jiffies, rq->last_blocked_load_update_tick))
>> +				update_blocked_averages(cpu);
>> +		}
>> +	}
>> +	/*
>> +	 * If we've just updated all of the NOHZ idle CPUs, then we can push
>> +	 * back the next nohz.next_update, which will prevent an unnecessary
>> +	 * wakeup for the nohz stats kick
>> +	 */
>> +	if (cpumask_subset(nohz.idle_cpus_mask, sched_domain_span(env->sd)))
>> +		nohz.next_update = jiffies + LOAD_AVG_PERIOD;
>> +#endif
>> +
>>   	load_idx = get_sd_load_idx(env->sd, env->idle);
>>   
>>   	do {
> 
> We're already going to be iterating all those CPUs through
> update_sg_lb_stats(), why not push it all the way down there and avoid
> the double iteration?

Brendan doesn't work for ARM anymore although he might still follow this 
discussion.

So you think that we can do the time_after(jiffies, 
rq->last_blocked_load_update_tick) check in update_sg_lb_stats() and 
possibly the update_blocked_averages() for all the cpus in the sd and 
then only update nohz.next_update in update_sd_lb_stats(). Let me try 
this ...