From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A2C7C433EF for ; Wed, 13 Jul 2022 14:51:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235163AbiGMOvX (ORCPT ); Wed, 13 Jul 2022 10:51:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234652AbiGMOvS (ORCPT ); Wed, 13 Jul 2022 10:51:18 -0400 Received: from alexa-out-sd-02.qualcomm.com (alexa-out-sd-02.qualcomm.com [199.106.114.39]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BB443C142; Wed, 13 Jul 2022 07:51:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1657723878; x=1689259878; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=usEfZWG3K+DfGjkb7INoXNmqgT2ynC9Rk8m0pztykNE=; b=G3bBANNsQFl/6rkTep8Od1gu3IbsEY8UjhpdGqkFi3imoB1sngbcRHOR xLGr80hS2SV0pFguyCmF7mu31IeWLVjTsJuLlInCS+DvHgQdedTYtya6Q 1ABFILm7IJVgJmSdNVE1bbGYf2ZAlyz6KoHszH9oQEAHaFd99shj8DxPb o=; Received: from unknown (HELO ironmsg01-sd.qualcomm.com) ([10.53.140.141]) by alexa-out-sd-02.qualcomm.com with ESMTP; 13 Jul 2022 07:51:18 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg01-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2022 07:51:17 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 13 Jul 2022 07:51:17 -0700 Received: from [10.216.22.132] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 13 Jul 2022 07:51:10 -0700 Message-ID: Date: Wed, 13 Jul 2022 20:21:07 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] soundwire: qcom: Update error prints to debug prints Content-Language: en-US To: Andrew Halaney CC: , , , , , , , , , , , , , , , , , References: <1657714921-28072-1-git-send-email-quic_srivasam@quicinc.com> <20220713135603.4vkyofw6x4mldxzp@halaneylaptop> From: Srinivasa Rao Mandadapu Organization: Qualcomm In-Reply-To: <20220713135603.4vkyofw6x4mldxzp@halaneylaptop> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/13/2022 7:26 PM, Andrew Halaney wrote: Thanks for your time Andrew. > A couple of drive by nits: > > On Wed, Jul 13, 2022 at 05:52:01PM +0530, Srinivasa Rao Mandadapu wrote: >> Upadte error prints to debug prints to avoid redundant logging in kernel >> boot time, as these prints are informative prints in irq handler. > s/Upadte/Update/ Okay. Will fix it. > >> Signed-off-by: Srinivasa Rao Mandadapu >> --- >> drivers/soundwire/qcom.c | 5 ++--- >> 1 file changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c >> index 9df970e..a4293d0 100644 >> --- a/drivers/soundwire/qcom.c >> +++ b/drivers/soundwire/qcom.c >> @@ -573,11 +573,10 @@ static irqreturn_t qcom_swrm_irq_handler(int irq, void *dev_id) >> break; >> case SWRM_INTERRUPT_STATUS_NEW_SLAVE_ATTACHED: >> case SWRM_INTERRUPT_STATUS_CHANGE_ENUM_SLAVE_STATUS: >> - dev_err_ratelimited(swrm->dev, "%s: SWR new slave attached\n", >> - __func__); >> + dev_dbg(swrm->dev, "%s: SWR new slave attached\n", __func__); > There's no need for __func__ usage with dev_dbg() when giving +f flag > when enabling adds this for you! Okay. Will remove __func__ and change dev_dbg() to dev_dbg_ratelimited(). > > With those changes feel free to add: > > Reviewed-by: Andrew Halaney > > Thanks, > Andrew > >> swrm->reg_read(swrm, SWRM_MCP_SLV_STATUS, &slave_status); >> if (swrm->slave_status == slave_status) { >> - dev_err(swrm->dev, "Slave status not changed %x\n", >> + dev_dbg(swrm->dev, "Slave status not changed %x\n", >> slave_status); >> } else { >> qcom_swrm_get_device_status(swrm); >> -- >> 2.7.4 >>