From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1161323AbdAFXnj (ORCPT <rfc822;w@1wt.eu>);
        Fri, 6 Jan 2017 18:43:39 -0500
Received: from mleia.com ([178.79.152.223]:49883 "EHLO mail.mleia.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S969904AbdAFXnf (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 6 Jan 2017 18:43:35 -0500
Subject: Re: [PATCH] i2c: core: helper function to detect slave mode
To: Andy Shevchenko <andy.shevchenko@gmail.com>
References: <f4ec62119145bc70c938800c91eb396d30457304.1483636071.git.lolivei@synopsys.com>
 <73246c4a-504c-52d7-dde4-970a45dca0bd@mleia.com>
 <CAHp75Ve87TE3y6hg1bMxSFAPVcY3wPifGuvtpXNhBw5-eOnPrg@mail.gmail.com>
Cc: Luis Oliveira <Luis.Oliveira@synopsys.com>,
        Wolfram Sang <wsa@the-dreams.de>, Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Jarkko Nikula <jarkko.nikula@linux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        linux-i2c@vger.kernel.org, devicetree <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Ramiro.Oliveira@synopsys.com, Joao Pinto <Joao.Pinto@synopsys.com>,
        CARLOS.PALMINHA@synopsys.com
From: Vladimir Zapolskiy <vz@mleia.com>
Message-ID: <b5788d1d-c951-0fc3-eed8-88457df1f27e@mleia.com>
Date: Sat, 7 Jan 2017 01:43:31 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Icedove/45.4.0
MIME-Version: 1.0
In-Reply-To: <CAHp75Ve87TE3y6hg1bMxSFAPVcY3wPifGuvtpXNhBw5-eOnPrg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-49551924 
X-CRM114-CacheID: sfid-20170106_234332_679455_FA623557 
X-CRM114-Status: GOOD (  14.65  )
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 01/07/2017 12:45 AM, Andy Shevchenko wrote:
> On Fri, Jan 6, 2017 at 11:46 PM, Vladimir Zapolskiy <vz@mleia.com> wrote:
>>> +     if (IS_BUILTIN(CONFIG_OF) && dev->of_node) {
>>
>> IS_BUILTIN(CONFIG_OF) looks excessive, check for non-NULL dev->of_node
>> should be sufficient.
> 
> Sorry, but you missed the point.
> This will enable compile time optimization and basically be collapsed to no-op.
> 

Good point, do you plan to add more "IS_BUILTIN(CONFIG_OF)" checks all
over the code to reduce the size of the built image? 

>>> +             }
>>> +     } else if (IS_BUILTIN(CONFIG_ACPI) && ACPI_HANDLE(dev)) {
>>> +             dev_dbg(dev, "ACPI slave is not supported yet\n");
>>> +     }
>>
>> If so, then it might be better to drop else-if stub for now.
> 
> Please, don't.
> 

Why do you ask for this stub to be added?

--
With best wishes,
Vladimir