From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f67.google.com (mail-ot1-f67.google.com [209.85.210.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 785CB3F23DC for ; Fri, 6 Feb 2026 14:28:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.67 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770388093; cv=none; b=iMlcLgGH48Yo6K0KtRWiyQ45624I1g3LwZ1a+KxcA+8x5djXgLAfDbczguuA61L7NScgrBAeL7i9GTrwHuTFuaHZPnLc62cJ7uUZy/BbzBBQDfZKSXhiZEfIBjD3aYNvr6WWyrO/boun4t15enWGN/BDAau095I8Ajhfwnlmc6I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770388093; c=relaxed/simple; bh=moATAORN3+qGPHy6a4MQ6AV2Ba/tlbL/itsYknkDtV0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qM89SXNIKPEeRxNHchEp9vS6kqtKqujFjZ9/CtH40pEBBMiEgy028nbEl65B+e7Fmmd2GNTHle0fsebdMKYN2uig3T9YpdrGxJnHuqXmB2TgaNRcIcJ9XF9eKPajFimIsRGE3pH4ZsG62yWAJBfjD90kxgLyg657OhAzIwuW4Q8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=ejl+QxhT; arc=none smtp.client-ip=209.85.210.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="ejl+QxhT" Received: by mail-ot1-f67.google.com with SMTP id 46e09a7af769-7d1959ba05cso994917a34.2 for ; Fri, 06 Feb 2026 06:28:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1770388091; x=1770992891; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DsBpUlxtFsyeEjeiWFAkqcdrMjz0lxaLUaFPl/YKamw=; b=ejl+QxhTkVjoms0YoK0XnZFkTcRUa6HZpPOZV+cWsfNvgxymUZ2sVasm4CqptYVoY1 NljouhUUWPbqYe5qehHeTprNa/g6CO19ngvO1ot7acwttMNWrvYyZKULYfN2qr39/Lp0 3hwksWdW8dGBvsLfXRLflUv6gEP1WYWj9Sd8Q9a/GH/MvKZOo19fs4QUk+tHVjv3p3rv gyuHDn/GMspgulVmcziaQdycCMujOziiJAEz3yo2g9rDCncTjCP05MnYjkDoRZIm1WmL yDUqBfBt22r76i82J1ozH/U9McePnk1gJoXrAHB5H9EfaOl+KSWDT2aTWb48ybcb54Ch njeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770388091; x=1770992891; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DsBpUlxtFsyeEjeiWFAkqcdrMjz0lxaLUaFPl/YKamw=; b=ktQmgBvPGImaD6zvb4+ayfigZ3LXv2virpvSHXNDmRbMnp8b7Uvi0GX6+phWn2JjbL TASwTVtF+bIy81yqf+yHwpAXw1K2hdqj7KM6XcEDjUiz7TBsya5a18kA1pkWaZMC+eUA bTswf/Vmxkous85n1EU4BUDxckgQbxpiLo5sAQENzk8gYYCmt02vmGNq7UgX3mKraSQ9 3Fb9xCHlpwtlkgBXLS+/23xETNn2WreN5otll/HeMTCRAR0j4ccT2NbRmTHki8j+aFGt 03zKMLcZ7y5mArChk3Ie3JwKZEF7Osjw+IJOw1VnuozwtVf/cnbrJ6iVQGBuEFILVKTZ HxOQ== X-Forwarded-Encrypted: i=1; AJvYcCU+TnkXDHG3CDauP1B//CguQJTaBuMHu2sYgOrohwl4q+VwFIrD3kjlQePfb8VG4st9ArsacxiwHjrdsT0=@vger.kernel.org X-Gm-Message-State: AOJu0YyxS7yEnN82rqp9wNmVd91CRGyGYZ1C+xAz17bOTYV2j8AWah1a S57l8xHxP7Wx+vJ80VYs6UiU32GPpHacWdx5lbNfFZQjPVGC6/9EQfty7qgjJppX/Ms= X-Gm-Gg: AZuq6aLnf42+C3UU9obPrGfcjC8TcUgJauLFWC/bwMUBO34VMpbrtMhc1weGEc2YD4w Qz7Fu0AJbU+JMdsXK8Id2Zq5N/lG5AbfTWTXwFDIAD3bUvb+L/U252tzKwDejI+YlH6wbT+/4gT vIqTfaJGQh9BEY+ICz5dBg3Chn7lqqjOig/G8i0WG/0r1mtauhYtDibTTmAwco0otscKC85v1sL g9JrBMPEj6fbAFIKCwjTdp/F6dBZJ8FIXtaLpy/2g+8hrCE17d1KugLciRAu+NvxYFpcZ4pYAof t845bHFHWsmQsXzNpzFQJVHUP4YDephd62Go6ct4S6kR4+5UkQQz5w8ckK7k6YpO75Tpmqoczxt aF47rHnz1aAxp+1oXNegXVmcogeqNHgmXMAYzitArqYrbuzDYUrYNzlB+fX1X49RfxWASk8qwqy Ec/gj7tSERmdTN79bpaZ0/FhBFSKFiYPA0KO6Lbrv4evy6qN6Pp3+BW3QETKMCs4moQBt01hm6i NpTL58= X-Received: by 2002:a05:6830:2585:b0:7cf:d191:2a50 with SMTP id 46e09a7af769-7d4643f38damr1225567a34.13.1770388090976; Fri, 06 Feb 2026 06:28:10 -0800 (PST) Received: from [192.168.1.102] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7d4646fca4asm1663267a34.2.2026.02.06.06.28.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Feb 2026 06:28:10 -0800 (PST) Message-ID: Date: Fri, 6 Feb 2026 07:28:09 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [bug report] io_uring: add task fork hook To: Dan Carpenter Cc: Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , linux-mm@kvack.org, linux-kernel References: Content-Language: en-US From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/6/26 6:40 AM, Dan Carpenter wrote: > [ Smatch checking is paused while we raise funding. #SadFace > https://lore.kernel.org/all/aTaiGSbWZ9DJaGo7@stanley.mountain/ -dan ] > > Hello Jens Axboe, > > Commit 4f08520591a2 ("io_uring: add task fork hook") from Jan 16, > 2026 (linux-next), leads to the following Smatch static checker > warning: > > kernel/fork.c:2544 copy_process() > warn: passing zero to 'ERR_PTR' > > kernel/fork.c > 2128 #ifdef CONFIG_IO_URING > 2129 p->io_uring = NULL; > 2130 retval = io_uring_fork(p); > > The patch added this assignment. > > 2131 if (unlikely(retval)) > 2132 goto bad_fork_cleanup_delayacct; > 2133 #endif > 2134 > 2135 p->default_timer_slack_ns = current->timer_slack_ns; > 2136 > 2137 #ifdef CONFIG_PSI > 2138 p->psi_flags = 0; > 2139 #endif > 2140 > 2141 task_io_accounting_init(&p->ioac); > 2142 acct_clear_integrals(p); > 2143 > 2144 posix_cputimers_init(&p->posix_cputimers); > 2145 tick_dep_init_task(p); > 2146 > 2147 p->io_context = NULL; > 2148 audit_set_context(p, NULL); > 2149 cgroup_fork(p); > 2150 if (args->kthread) { > 2151 if (!set_kthread_struct(p)) > 2152 goto bad_fork_cleanup_delayacct; > > So now retval is success where previously it had been -EAGAIN > > 2153 } Thanks, fixed up. -- Jens Axboe