From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D25E2DB794 for ; Thu, 29 Jan 2026 05:54:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769666099; cv=none; b=rxSCiPseHUaF2QOuMq2muqLhueomvU1xqZRTRYkLD24BamnUwy1Xgra7kCzdfGc4E2AQGe5QxbCc7E6QRZE+tO2F43nA4nZN5z/EjgwKJ0ZyWr2axrUR491M0MkOiJL2HuhVYCdxmTqq83YcW+WCydpI2rD4FwKS/SF7hj/btQE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769666099; c=relaxed/simple; bh=r3XA5Og69LNwTAiWa13ToEZC9YnQgaU5zqvoo8NeXdc=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=L34i9mzwzNatP1HDtXAmUmxb5lfJ3KEvw/14tqvyN8J8sVnwPM+/xK2PoIPNe+VjKu0IEwM3/nOvhWfGYbeo/iSdl3PBy08FlmzPfoIgvczuUvjgqFp1kWqIr3I09D9UB7YEUDxbczOYCvpyyFbG3gPfrGZrjWtDfjwU6BeX2gQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KHRbICd1; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=W07s7npN; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KHRbICd1"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="W07s7npN" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60T2ouwF2150627 for ; Thu, 29 Jan 2026 05:54:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 7s/3ecR4fInHAhmiie0O8GBVJeP++a9f0MC03yZDWZY=; b=KHRbICd1t1a0+C2Y 0q9aNBEWALAkxWRUHtHGFxeo0LXzJYmUT/UTySP8SmDWsjdu2uVY3xLrtgnxPvMl MwGhHL+ID9McXdSBUNda7LVT0sDJ0THSmfIFkU9EbRw4x6RProIzBPmXVqb9VPTo ueNuKeTC1FJyRsIhZ0O9uxtd9CosFGyw32pntlYGPyyIaeIdqMVpCrxdhQakcO+n AID3ANK1rxhjjikAfC3emnDJYRsPiiLlBfLxIazeKXEXw3v9fPIoFvmqaLzViqxv q7wBCVwG5kRGqCkK5XT2OQebWCKbs8ssUvmaANVaB5tidZSDkyOW++BWKyKif9dN 6fRr2g== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4byph3a5c9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 29 Jan 2026 05:54:57 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-81f5381d17dso542269b3a.1 for ; Wed, 28 Jan 2026 21:54:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769666097; x=1770270897; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=7s/3ecR4fInHAhmiie0O8GBVJeP++a9f0MC03yZDWZY=; b=W07s7npNKcVuZ0E+nIj5R6x1J1lZv4QeaKIKsVy8yFnMdQ7GxHXOZElL4wTocswLwn X8N2YRbZF80c4hraHjTCZXjgRscaiRS21WEhFjPnHxOjE81bV5myOy8bRxtN9i8FAhHg pFj25tfCVQel6Z6Xrv2+ilEVRngzqlNbEm1GDjURxB/H/XXoUR/N+mE3c3Rz4PO1nSlw I26vKqUIi/95QG2EhV4G0wqZjR2qXb4JbjHiApONO5SPFFIVWy6uFHMCZ4VX7Tz+9VdC FdwBelY6ew6SETPloOwNMSCOvARCQ8IXIK9/T8A8bkxkRb6J9wbRFBjivP0wGJMUPwxw ByWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769666097; x=1770270897; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7s/3ecR4fInHAhmiie0O8GBVJeP++a9f0MC03yZDWZY=; b=TdPVnZSQJRVeEr4ZzpT/gkc5TdLiRp1tScj7Pl5FYMqkToMCUAiKlFyI0kAIyIQbRN EKqeXk/5hzcUYZE8STJvH+GAV4fpQjT5uD+KxbeCziVT2j6hHUwxdbSzR/S7+igURNeI +Yv7RxocPPC3GLyfcqbBMNErx9v//7ZO1FtNfQcGUGX0cZS2MyqWJrQvKWC/g8MvS2Ce l5JyWJYZwmpiGGnZWIkYl7Dqgi4b63aK6QtcgG31oeSbZ7LXQePYA/yQ2noVWVFqY+HG VpBPPU9zoUgEch9qEhmaQAYDCcJD3a5Ea2xsnEF69BuvnbbEF0tCAas9lG4m8Mk3B3ZL b+3Q== X-Forwarded-Encrypted: i=1; AJvYcCVdWKZt2bTlqjYY9gjjpgWUuP6kXM7RwbEjR+1pjrlfZDEIGGxXYIot27OGhX6dkpNg0KptYm1Te3GrgIc=@vger.kernel.org X-Gm-Message-State: AOJu0YxjTPGoAX9RyQQAKRfC4HosZ1oykkLchu3xbbd7UGhw85njW4yN bl1+qN536tMytSwzWVfQ0doVG3Vb880VqNlCSxzOyUnGi9NpGxkDxDcSApHc6dZ0o8nZt7fEECj 7BR1Neub706wDRZ1rSngr6kPpAOUvh3tTkYCkgU4cQH6Kd0tpIxWop9ptuvCnJxGMBo0= X-Gm-Gg: AZuq6aJv268CpgvRkdAx7KZYqFuHu/2bDuxOzTUTsx/INsBoF1dixXz4XG5XQqg50KC tweL7kUwM0HAAOxicvbRUVcALypg32F34/eiB8RTwgOyXCeyQ3Pr4XKA3lXG2wVGYynanZup9ga V2hi3bd6AIBDQHyamg/UYw1teXBKWTT0lfoWREOfUJfa9zDu4FS00H506M5a2hquda7AZNad2r+ kFymBKvq3JZNIM2xlD/ydNLTPvLDYQhypmjAHyToP4ZFXvrDCCIHvE7eHq8/LZVrKleP/Zg0WYZ uqWqUaMiVy/zTy9lY9wJVCKTdNuyeni2LvpIGcfkkDBmCqE2wLaIo5xDfmS5OcHKVrG11e6e0mG xPpKCpQoJw/C7PdwYLkrBcVIkxMKt/eGGvhve X-Received: by 2002:a05:6a00:9515:b0:81f:9b0a:812a with SMTP id d2e1a72fcca58-8236914d103mr8247029b3a.14.1769666097005; Wed, 28 Jan 2026 21:54:57 -0800 (PST) X-Received: by 2002:a05:6a00:9515:b0:81f:9b0a:812a with SMTP id d2e1a72fcca58-8236914d103mr8247009b3a.14.1769666096548; Wed, 28 Jan 2026 21:54:56 -0800 (PST) Received: from [10.218.16.122] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82379c22672sm4148529b3a.51.2026.01.28.21.54.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Jan 2026 21:54:56 -0800 (PST) Message-ID: Date: Thu, 29 Jan 2026 11:24:50 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Fw: [PATCH 2/2] Bluetooth: hci_qca: QCC2072 enablement From: Vivek Sahu To: Dmitry Baryshkov Cc: Marcel Holtmann , Luiz Augusto von Dentz , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bartosz Golaszewski , "Balakrishna Godavarthi (QUIC)" , "Rocky Liao (QUIC)" , "Mohammed Sameer Mulla (QUIC)" , "Harish Bandi (QUIC)" , "linux-bluetooth@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , quic_janathot@quicinc.com References: <20251217112850.520572-1-vivesahu@qti.qualcomm.com> <20251217112850.520572-2-vivesahu@qti.qualcomm.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=Z93h3XRA c=1 sm=1 tr=0 ts=697af631 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=Dei6p5SHAAAA:8 a=pGLkceISAAAA:8 a=VwQbUJbxAAAA:8 a=COk6AnOGAAAA:8 a=cVxSA6WL1EjVwi2A-scA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 a=M-Yerj1wOn-OpK7r_3ei:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-ORIG-GUID: wm8twUW3_U8Q82Pzj1mtQ2hmlL4jSmjt X-Proofpoint-GUID: wm8twUW3_U8Q82Pzj1mtQ2hmlL4jSmjt X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI5MDAzNCBTYWx0ZWRfX5Cy+as3tUUF0 pVaYwRSEHvAP0rq0HIXpl0kyu03CFxxotcL9mNCA+Ye6RDP39oXVcIt1u+HDLQ/894asKy2aMoX CM5VLSRak7XoVJ/FZEwHyw7YNye1jTCPXm7moyw06xaV16G2yoIElXbsgoQca0WJmAIpMDuDTDZ fWVbInLsLnRC5wMhMdVxGYbDPu88L5iJaFWW9aGA6fdL+zd8HzBDxfFKlUNQTePyupsYNKwfwj3 vbJ8/uC/d4s3n2lXQD7WhWkRKzJeeH55MDYk1JKfy75BeL+F+R2JZyHKKBF8Vgrsz7U9Nnj8QhT J8V/LnqDO29djalhljQqN6mx34h5LOAR9Jr/Gvu/456lFn/3obqMmrY1tNg1CPLh2OUdhdAlKyd FTDbxV5pigvaoYamu8Op4tRGJ/1L18gaFTXXRQ7UsCetta8h7Tnvml693fffoEe1CHXUd4+UhRs nsr33Z4D125sANko0uA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-28_06,2026-01-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 impostorscore=0 adultscore=0 clxscore=1015 phishscore=0 spamscore=0 suspectscore=0 malwarescore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601290034 On 1/7/2026 12:50 PM, Vivek Sahu wrote: >> From: Dmitry Baryshkov >> Sent: 17 December 2025 19:59 >> To: Vivek Sahu >> Cc: Marcel Holtmann ; Luiz Augusto von Dentz >> ; Rob Herring ; Krzysztof >> Kozlowski ; Conor Dooley ; >> Bartosz Golaszewski ; Balakrishna Godavarthi (QUIC) >> ; Rocky Liao (QUIC) >> ; Mohammed Sameer Mulla (QUIC) >> ; Harish Bandi (QUIC) >> ; linux-bluetooth@vger.kernel.org >> ; devicetree@vger.kernel.org >> ; linux-kernel@vger.kernel.org >> ; linux-arm-msm@vger.kernel.org >> >> Subject: Re: [PATCH 2/2] Bluetooth: hci_qca: QCC2072 enablement >> >> On Wed, Dec 17, 2025 at 04:58:50PM +0530, Vivek Kumar Sahu wrote: >>> Adding support for BT SoC QCC2072. >>> Set appropriate configurations for BT UART >>> transport. >> Read Documentation/process/submitting-patches.rst > > > I'll make the commit message more clear in the next patch set of this > commit. > > >> >>> Signed-off-by: Vivek Kumar Sahu >>> --- >>>   drivers/bluetooth/btqca.c   |  8 ++++++++ >>>   drivers/bluetooth/btqca.h   |  1 + >>>   drivers/bluetooth/hci_qca.c | 17 +++++++++++++++++ >>>   3 files changed, 26 insertions(+) >>> >>> diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c >>> index 7c958d6065be..7eb095db4a1d 100644 >>> --- a/drivers/bluetooth/btqca.c >>> +++ b/drivers/bluetooth/btqca.c >>> @@ -854,6 +854,10 @@ int qca_uart_setup(struct hci_dev *hdev, >>> uint8_t baudrate, >>>                         snprintf(config.fwname, sizeof(config.fwname), >>>                                  "qca/hmtbtfw%02x.tlv", rom_ver); >>>                         break; >>> +             case QCA_QCC2072: >> Please keep the file sorted. Find a correct place to insert your changes >> rather than randomly sticking them to the end. This applies to _all_ the >> changes you've made here. > > > I'll address this in the next patch set of this commit. I just checked that "qca_btsoc_type" enum contains all the soc type which need to be enabled for BT enablement on the target device. There are few places where logic of framing packets transferring between SoC  and Host depends on the which generation of the chip it is, refer api "qca_read_soc_version". And this applies to all the places in the file where i made the changes. So can we not sort it ? or you want me to sort in the switch cases where this chip set is added. > >> >>> + snprintf(config.fwname, sizeof(config.fwname), >>> +                              "qca/ornbtfw%02x.tlv", rom_ver); >> I hope to see the firmware being submitted to linux-firmware. > > > "YES", firmware is being submitted. We have up-streamed the firmware. > > >> >>> +                     break; >>>                 default: >>>                         snprintf(config.fwname, sizeof(config.fwname), >>>                                  "qca/rampatch_%08x.bin", soc_ver); >>> @@ -929,6 +933,10 @@ int qca_uart_setup(struct hci_dev *hdev, >>> uint8_t baudrate, >>> qca_get_nvm_name_by_board(config.fwname, sizeof(config.fwname), >>>                                  "hmtnv", soc_type, ver, rom_ver, >>> boardid); >>>                         break; >>> +             case QCA_QCC2072: >>> +                     snprintf(config.fwname, sizeof(config.fwname), >>> +                              "qca/ornnv%02x.bin", rom_ver); >> No board-specific NVMEM dumps? > > > "NO", for this BT SoC there is no board specific NVM. > > >> >>> +                     break; >>>                 default: >>>                         snprintf(config.fwname, sizeof(config.fwname), >>>                                  "qca/nvm_%08x.bin", soc_ver); >> -- >> With best wishes >> Dmitry