From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D24D4C7C8A1 for ; Mon, 27 Apr 2020 13:17:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AECA220656 for ; Mon, 27 Apr 2020 13:17:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="CkD/p2YT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727842AbgD0NRf (ORCPT ); Mon, 27 Apr 2020 09:17:35 -0400 Received: from hqnvemgate24.nvidia.com ([216.228.121.143]:5673 "EHLO hqnvemgate24.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726953AbgD0NRd (ORCPT ); Mon, 27 Apr 2020 09:17:33 -0400 Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Mon, 27 Apr 2020 06:15:32 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Mon, 27 Apr 2020 06:17:33 -0700 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Mon, 27 Apr 2020 06:17:33 -0700 Received: from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 27 Apr 2020 13:17:33 +0000 Received: from [10.26.73.54] (10.124.1.5) by DRHQMAIL107.nvidia.com (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 27 Apr 2020 13:17:21 +0000 Subject: Re: [PATCH] backlight: lp855x: Ensure regulators are disabled on probe failure To: Daniel Thompson , Lee Jones CC: Milo Kim , Jingoo Han , , , References: <20200224140748.2182-1-jonathanh@nvidia.com> <20200224143732.rreev3ypou26hvx3@holly.lan> <6ec74817-968b-ab5e-6566-56bbb9b67599@nvidia.com> <20200316090546.5eufi423ahstz6v3@holly.lan> From: Jon Hunter Message-ID: Date: Mon, 27 Apr 2020 14:17:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200316090546.5eufi423ahstz6v3@holly.lan> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To DRHQMAIL107.nvidia.com (10.27.9.16) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1587993332; bh=PWx8n+kYRA1n2vodVtlcl5MSgTdEhqLiiBItjXVs/nA=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=CkD/p2YTdNlyTddyE4uATk7emVK+mMQlRmf80wOjePk8J8B+ueUTzoMvVB7PLQXuo g/QXkFsyAPpDPOV35S7mZ5eMG4M7kgwDwBM4COJeOzO/Cn0np4hQBGWR43y1VwYJNz PDuiYuyNsBPd0A93YpPj7xqhM50Dk4MrkMIPrT+5vZL+G8nHzxpu77Um5w9dx29y/m NaKV9q0/e4ssVmWBd8u7R8J9jlVNGRmiDPS3c81vZO5fg3N/yQpJFzIt/TGp0NivH1 bEG8ZC/FdDe6RMspv+7QFzEuOnOS0CoRobI7uP9xj6vQqNbgkramjx7F48lkg0rdmR FYgjRnNBKQQnA== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lee, On 16/03/2020 09:05, Daniel Thompson wrote: > On Fri, Mar 13, 2020 at 02:16:16PM +0000, Jon Hunter wrote: >> Hi Lee, Daniel, >> >> On 24/02/2020 14:37, Daniel Thompson wrote: >>> On Mon, Feb 24, 2020 at 02:07:48PM +0000, Jon Hunter wrote: >>>> If probing the LP885x backlight fails after the regulators have been >>>> enabled, then the following warning is seen when releasing the >>>> regulators ... >>>> >>>> WARNING: CPU: 1 PID: 289 at drivers/regulator/core.c:2051 _regulator_put.part.28+0x158/0x160 >>>> Modules linked in: tegra_xudc lp855x_bl(+) host1x pwm_tegra ip_tables x_tables ipv6 nf_defrag_ipv6 >>>> CPU: 1 PID: 289 Comm: systemd-udevd Not tainted 5.6.0-rc2-next-20200224 #1 >>>> Hardware name: NVIDIA Jetson TX1 Developer Kit (DT) >>>> >>>> ... >>>> >>>> Fix this by ensuring that the regulators are disabled, if enabled, on >>>> probe failure. >>>> >>>> Finally, ensure that the vddio regulator is disabled in the driver >>>> remove handler. >>>> >>>> Signed-off-by: Jon Hunter >>> >>> Reviewed-by: Daniel Thompson >> I received a bounce from Milo's email and so I am not sure that his >> email address is still valid. >> >> Can either of you pick this up? > > Lee generally starts to hoover up patches about this stage in the dev > cycle so I'd expect this to move fairly soon. Does not look like this ever got picked up. Please let me know if you can queue this one. Note it still applies cleanly to -next. Jon -- nvpublic