From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E2BB3BB4A for ; Mon, 17 Aug 2026 22:05:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787004327; cv=none; b=lVRWdiqgyTBdfvrGopJnvgmT0MwEmLVvVyGCPHBPnkZ83dAiohoUyXIKVQk/HuUu2XOqlVmNQjSV2s2zTKRUbjC/GBSQe2T56OqU4kJowkvvVaL7bcppW70JeRdq7xTcNMNPRSW0c2LwvuRrrSfKFefgW4QEOKF4wIYQ7Hbm2gM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787004327; c=relaxed/simple; bh=Q1haxLxDfznHl7+pHV8qpXCIveWzodD4r8D9EU4Q+Kg=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=a5LHeqlsL4tuWoX/CyyS0/yNUQW3+u1/A8xuxXsvFGoNY4X+hbThbB/bSuy8Iv8EnxeUrB3/PsK+oLFeEgW4Ag6BlT5esowhrGMky+MdGgq3Rw5sdM+4VJppYK7tcAnuqPScUnQIs80hfO3b0Sx8VS8YRO6HYqKSKEc138T3twA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=WwrDvHoC; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=A9zoitsZ; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WwrDvHoC"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="A9zoitsZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787004322; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E766Td4gI7Jjb64efynVnNkp8ShDWVNTDmV+hJtlk18=; b=WwrDvHoCRjXGd6FpHY4JFPc0t0CRPWSlSH33Kyf9RW7x4Xyl4uojKuimp8FAiXVS7fcDzj X87OMm4WqWLp/oV8bqXA3OJDwlunY0O9itrOycC7qpg24z2i0uJ5xOJJVqEtByDfQUACta LVC8oHr8FXAkXBz2ZwdYP46KzNiBpOc= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-436-26T3YeDsONiiKGsrvkcIRw-1; Mon, 17 Aug 2026 18:05:20 -0400 X-MC-Unique: 26T3YeDsONiiKGsrvkcIRw-1 X-Mimecast-MFC-AGG-ID: 26T3YeDsONiiKGsrvkcIRw_1787004320 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-9349c5af52bso659078485a.0 for ; Mon, 17 Aug 2026 15:05:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1787004320; x=1787609120; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to:content-type; bh=E766Td4gI7Jjb64efynVnNkp8ShDWVNTDmV+hJtlk18=; b=A9zoitsZx+ivftrNLHVWZyEAk8eOCnxyxrC7E6TICUieSFEfVhoYHQtBZJMPNGOQ8S Cez0NS8s1f/U5Lpz2szIvaJIC1bLrRhNJCcjl84xc9M10PgAZivFE6LRwNOfd9rJ/xwX QB80ZoogVwJizhEPeWc3ehcd/Ztl/+aiztFdBemrYQWzkC7/iUdNtdmn6YijooD66tvR v5120fgHoM67mwXXU/cxzG+noXu/HcrOueWmftkJ5FOfrW1JanhXGCQwfUEair5o8z3H 2Dp4V7AuNIBg+th9gqRXSHgY/Tp36EulmdkYUFpzIpYc72HGnEVpgZMy+tClNHivH6lW Y8LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787004320; x=1787609120; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=E766Td4gI7Jjb64efynVnNkp8ShDWVNTDmV+hJtlk18=; b=X0xIF08gzw6Lghvk82FrA12xIHWAf0nFGBSqAvSYihWb0UOYgrrLy6BA6Lmc12ABUJ U8IpuTkvee7hCJmU2l+nN3nXG4vjhvrW/EA5xzRWKq8QMDywjkAplhgQ9L16dVCyT8ql uBjTQpcOMCnXjEt9c5wPTQGmKR0OhyVzlgWnkOXfSBUM6D7ijs2RerPNCgBc08/u0KCc cY8mM2fFbNsqRUPRcSKBB+q3Ch8IVz/7/o4wYHB8xt33NDaWhwQ1tiITvk77NLxYLJsC 30K1XDetwIHkROZTn59rkWXv2tTPCzrA7x/Lf8lS/lVbRNRiimHIp4oT8KV4v2d7aJQC 6FIg== X-Forwarded-Encrypted: i=1; AHgh+RoSG763FopXflSgoSemB5kfCVjNzckHNFyIujD2WHXDdo0Fb4+fULDmn5LmvrCwBqMP5Di0LnIO+MqNdcw=@vger.kernel.org X-Gm-Message-State: AOJu0YzYQJf+nbbBRvKMC4IcGuEWihuCObD7PU5z7R2B0i5FkUQXvnR3 q/+VIDttvTO6B6A2pmNcmMu8+ASTLIyhL+6CnmTpgiNTa/ik4OC4JI8RhUFyrUlLCy+h9geUXGS Rf7H9QyFhZjW+bNAAdIpPcY6gOBCIsIFhc/7DvDvM4bGiycwOItYKHP67OFKFvHhLyXQieE3Nwg == X-Gm-Gg: AR+sD10uyeBK5vckwTFFCuCNGJOV2GV23llJP/oWm4Hv4FzNK79ee5P+A4SHguBetoq jUbjJeXz05d01/togLnhDK2G9lSc2kl7O8ONFTDoEScy3BlIRdQYcT2AhMeytuKkq+Id0/j/t0/ MSZBv9yy23CZPiVB6I9UZ9+W4kF8ROB0YeJV5RyXo/hpMPfBHgP9Pq/xlkez7Nz/+6me801Jr9P 5FD7X80A/bNjZk0ZNzvY5T/tvdErfjVG5PtdtfLlWXB0YTcLEX+ZDkbW0TqTesevxntZLJDfBOX i6BjRpJu11SV13Qb5FwW1wnz4MsskUTAeX3hTyjqtk+Pnoaa+mbEN1wQU3EBHY2Sr70nC4sI X-Received: by 2002:a05:620a:5698:b0:926:e8e6:3c34 with SMTP id af79cd13be357-936d22aa9e8mr2397228885a.21.1787004320053; Mon, 17 Aug 2026 15:05:20 -0700 (PDT) X-Received: by 2002:a05:620a:5698:b0:926:e8e6:3c34 with SMTP id af79cd13be357-936d22aa9e8mr2397223685a.21.1787004319557; Mon, 17 Aug 2026 15:05:19 -0700 (PDT) Received: from [192.168.8.4] ([100.0.180.93]) by smtp.gmail.com with ESMTPSA id af79cd13be357-937033ce024sm145372885a.25.2026.08.17.15.05.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2026 15:05:18 -0700 (PDT) Message-ID: Subject: Re: [PATCH 4/7] nouveau/gsp: use per-version DP_CONFIG_STREAM params on r570 firmware From: lyude@redhat.com To: Mohamed Ahmed , linux-kernel@vger.kernel.org Cc: dri-devel@lists.freedesktop.org, Danilo Krummrich , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Mary Guillemard , nouveau@lists.freedesktop.org Date: Mon, 17 Aug 2026 18:05:17 -0400 In-Reply-To: <20260814235705.59132-5-mohamedahmedegypt2001@gmail.com> References: <20260814235705.59132-1-mohamedahmedegypt2001@gmail.com> <20260814235705.59132-5-mohamedahmedegypt2001@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Sat, 2026-08-15 at 03:57 +0400, Mohamed Ahmed wrote: > NVIDIA removed the deprecated actualPclkHz/linkClkFreqHz fields and > the > whole Legacy{activeCnt, activeFrac, activePolarity, mvidWarEnabled, > MvidWarParams} block from the SST sub-struct of > NV0073_CTRL_CMD_DP_CONFIG_STREAM_PARAMS between the 535 and 570 > releases > (compared in OpenRM tags 535.113.01 vs 570.144), shrinking the > struct. >=20 > Everything nouveau writes sits at identical offsets in both layouts > but > the size is wrong on r570, which means r535_sor_dp_sst() and > r535_sor_dp_vcpi() are sent with an incorrect size. >=20 > Route the .sst/.vcpi IOR functions through nvkm_rm_api_disp the same > way > bl_ctrl and dp.get_caps/set_indexed_link_rates already are. Keep the > existing implementation for r535 and add an r570 implementation built > against the 570.144 layout, which already exists in r570/nvrm/disp.h > but > was unused until now. Also add the NV0073_CTRL_CMD_DP_CONFIG_STREAM > define that was missing from the layout. >=20 > Other DP controls sent through shared r535 code did not change layout > between the tags. >=20 > Signed-off-by: Mohamed Ahmed > --- > =C2=A0.../nouveau/nvkm/subdev/gsp/rm/r535/disp.c=C2=A0=C2=A0=C2=A0 | 25 += ++++++- > =C2=A0.../nouveau/nvkm/subdev/gsp/rm/r570/disp.c=C2=A0=C2=A0=C2=A0 | 64 > +++++++++++++++++++ > =C2=A0.../nvkm/subdev/gsp/rm/r570/nvrm/disp.h=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 |=C2=A0 2 + > =C2=A0.../gpu/drm/nouveau/nvkm/subdev/gsp/rm/rm.h=C2=A0=C2=A0 |=C2=A0 5 += + > =C2=A04 files changed, 93 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/disp.c > b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/disp.c > index f51ad7c754d8..dd632767aea5 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/disp.c > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/disp.c > @@ -403,7 +403,7 @@ r535_sor_dp_audio(struct nvkm_ior *sor, int head, > bool enable) > =C2=A0} > =C2=A0 > =C2=A0static void > -r535_sor_dp_vcpi(struct nvkm_ior *sor, int head, u8 slot, u8 > slot_nr, u16 pbn, u16 aligned_pbn) > +r535_dp_vcpi(struct nvkm_ior *sor, int head, u8 slot, u8 slot_nr, > u16 pbn, u16 aligned_pbn) > =C2=A0{ > =C2=A0 struct nvkm_disp *disp =3D sor->disp; > =C2=A0 struct NV0073_CTRL_CMD_DP_CONFIG_STREAM_PARAMS *ctrl; > @@ -434,9 +434,17 @@ r535_sor_dp_vcpi(struct nvkm_ior *sor, int head, > u8 slot, u8 slot_nr, u16 pbn, u > =C2=A0 WARN_ON(nvkm_gsp_rm_ctrl_wr(&disp->rm.objcom, ctrl)); > =C2=A0} > =C2=A0 > +static void > +r535_sor_dp_vcpi(struct nvkm_ior *sor, int head, u8 slot, u8 > slot_nr, u16 pbn, u16 aligned_pbn) > +{ > + const struct nvkm_rm_api *rmapi =3D sor->disp- > >engine.subdev.device->gsp->rm->api; > + > + rmapi->disp->dp.vcpi(sor, head, slot, slot_nr, pbn, > aligned_pbn); > +} > + > =C2=A0static int > -r535_sor_dp_sst(struct nvkm_ior *sor, int head, bool ef, > - u32 watermark, u32 hblanksym, u32 vblanksym) > +r535_dp_sst(struct nvkm_ior *sor, int head, bool ef, > + =C2=A0=C2=A0=C2=A0 u32 watermark, u32 hblanksym, u32 vblanksym) > =C2=A0{ > =C2=A0 struct nvkm_disp *disp =3D sor->disp; > =C2=A0 struct NV0073_CTRL_CMD_DP_CONFIG_STREAM_PARAMS *ctrl; > @@ -463,6 +471,15 @@ r535_sor_dp_sst(struct nvkm_ior *sor, int head, > bool ef, > =C2=A0 return nvkm_gsp_rm_ctrl_wr(&disp->rm.objcom, ctrl); > =C2=A0} > =C2=A0 > +static int > +r535_sor_dp_sst(struct nvkm_ior *sor, int head, bool ef, > + u32 watermark, u32 hblanksym, u32 vblanksym) > +{ > + const struct nvkm_rm_api *rmapi =3D sor->disp- > >engine.subdev.device->gsp->rm->api; > + > + return rmapi->disp->dp.sst(sor, head, ef, watermark, > hblanksym, vblanksym); > +} > + > =C2=A0static const struct nvkm_ior_func_dp > =C2=A0r535_sor_dp =3D { > =C2=A0 .sst =3D r535_sor_dp_sst, > @@ -1828,6 +1845,8 @@ r535_disp =3D { > =C2=A0 .dp =3D { > =C2=A0 .get_caps =3D r535_dp_get_caps, > =C2=A0 .set_indexed_link_rates =3D > r535_dp_set_indexed_link_rates, > + .sst =3D r535_dp_sst, > + .vcpi =3D r535_dp_vcpi, > =C2=A0 }, > =C2=A0 .chan =3D { > =C2=A0 .set_pushbuf =3D r535_disp_chan_set_pushbuf, > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r570/disp.c > b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r570/disp.c > index a96e31c2d80b..61f82e15ff39 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r570/disp.c > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r570/disp.c > @@ -5,6 +5,7 @@ > =C2=A0#include > =C2=A0 > =C2=A0#include > +#include > =C2=A0#include > =C2=A0 > =C2=A0#include "nvhw/drf.h" > @@ -74,6 +75,67 @@ r570_disp_chan_set_pushbuf(struct nvkm_disp *disp, > s32 oclass, int inst, struct > =C2=A0 return nvkm_gsp_rm_ctrl_wr(&gsp->internal.device.subdevice, > ctrl); > =C2=A0} > =C2=A0 > +static void > +r570_dp_vcpi(struct nvkm_ior *sor, int head, u8 slot, u8 slot_nr, > u16 pbn, u16 aligned_pbn) > +{ > + struct nvkm_disp *disp =3D sor->disp; > + NV0073_CTRL_CMD_DP_CONFIG_STREAM_PARAMS *ctrl; > + > + ctrl =3D nvkm_gsp_rm_ctrl_get(&disp->rm.objcom, > + =C2=A0=C2=A0=C2=A0 > NV0073_CTRL_CMD_DP_CONFIG_STREAM, sizeof(*ctrl)); > + if (WARN_ON(IS_ERR(ctrl))) > + return; > + > + ctrl->subDeviceInstance =3D 0; > + ctrl->head =3D head; > + ctrl->sorIndex =3D sor->id; > + ctrl->dpLink =3D sor->asy.link =3D=3D 2; > + ctrl->bEnableOverride =3D 1; > + ctrl->bMST =3D 1; > + ctrl->hBlankSym =3D 0; > + ctrl->vBlankSym =3D 0; > + ctrl->colorFormat =3D 0; > + ctrl->bEnableTwoHeadOneOr =3D 0; > + ctrl->singleHeadMultistreamMode =3D 0; > + ctrl->MST.slotStart =3D slot; > + ctrl->MST.slotEnd =3D slot + slot_nr - 1; > + ctrl->MST.PBN =3D pbn; > + ctrl->MST.Timeslice =3D aligned_pbn; > + ctrl->MST.sendACT =3D 0; > + ctrl->MST.singleHeadMSTPipeline =3D 0; > + ctrl->MST.bEnableAudioOverRightPanel =3D 0; > + WARN_ON(nvkm_gsp_rm_ctrl_wr(&disp->rm.objcom, ctrl)); > +} Should we maybe just update this function so that it has a return value rather than doing the WARN_ONs explicitly under the HAL? Seems more in line with what we do elsewhere, even if the only action the caller ends up taking in response is printing a kernel warning. > + > +static int > +r570_dp_sst(struct nvkm_ior *sor, int head, bool ef, > + =C2=A0=C2=A0=C2=A0 u32 watermark, u32 hblanksym, u32 vblanksym) > +{ > + struct nvkm_disp *disp =3D sor->disp; > + NV0073_CTRL_CMD_DP_CONFIG_STREAM_PARAMS *ctrl; > + > + ctrl =3D nvkm_gsp_rm_ctrl_get(&disp->rm.objcom, > + =C2=A0=C2=A0=C2=A0 > NV0073_CTRL_CMD_DP_CONFIG_STREAM, sizeof(*ctrl)); > + if (IS_ERR(ctrl)) > + return PTR_ERR(ctrl); > + > + ctrl->subDeviceInstance =3D 0; > + ctrl->head =3D head; > + ctrl->sorIndex =3D sor->id; > + ctrl->dpLink =3D sor->asy.link =3D=3D 2; > + ctrl->bEnableOverride =3D 1; > + ctrl->bMST =3D 0; > + ctrl->hBlankSym =3D hblanksym; > + ctrl->vBlankSym =3D vblanksym; > + ctrl->colorFormat =3D 0; > + ctrl->bEnableTwoHeadOneOr =3D 0; > + ctrl->SST.bEnhancedFraming =3D ef; > + ctrl->SST.tuSize =3D 64; > + ctrl->SST.waterMark =3D watermark; > + ctrl->SST.bEnableAudioOverRightPanel =3D 0; > + return nvkm_gsp_rm_ctrl_wr(&disp->rm.objcom, ctrl); > +} > + > =C2=A0static int > =C2=A0r570_dp_set_indexed_link_rates(struct nvkm_outp *outp) > =C2=A0{ > @@ -255,6 +317,8 @@ r570_disp =3D { > =C2=A0 .dp =3D { > =C2=A0 .get_caps =3D r570_dp_get_caps, > =C2=A0 .set_indexed_link_rates =3D > r570_dp_set_indexed_link_rates, > + .sst =3D r570_dp_sst, > + .vcpi =3D r570_dp_vcpi, > =C2=A0 }, > =C2=A0 .chan =3D { > =C2=A0 .set_pushbuf =3D r570_disp_chan_set_pushbuf, > diff --git > a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r570/nvrm/disp.h > b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r570/nvrm/disp.h > index 06e972835d77..742b25a2a12d 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r570/nvrm/disp.h > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r570/nvrm/disp.h > @@ -256,6 +256,8 @@ typedef struct NV0073_CTRL_DP_CTRL_PARAMS { > =C2=A0=C2=A0=C2=A0=C2=A0 NvU32 eightLaneDpcdBaseAddr; > =C2=A0} NV0073_CTRL_DP_CTRL_PARAMS; > =C2=A0 > +#define NV0073_CTRL_CMD_DP_CONFIG_STREAM=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 > (0x731362U) /* finn: Evaluated from > "(FINN_NV04_DISPLAY_COMMON_DP_INTERFACE_ID << 8) | > NV0073_CTRL_CMD_DP_CONFIG_STREAM_PARAMS_MESSAGE_ID" */ > + > =C2=A0typedef struct NV0073_CTRL_CMD_DP_CONFIG_STREAM_PARAMS { > =C2=A0=C2=A0=C2=A0=C2=A0 NvU32=C2=A0 subDeviceInstance; > =C2=A0=C2=A0=C2=A0=C2=A0 NvU32=C2=A0 head; > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/rm.h > b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/rm.h > index a9af94adf9ef..e0c10a7e3452 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/rm.h > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/rm.h > @@ -6,6 +6,7 @@ > =C2=A0#ifndef __NVKM_RM_H__ > =C2=A0#define __NVKM_RM_H__ > =C2=A0#include "handles.h" > +struct nvkm_ior; > =C2=A0struct nvkm_outp; > =C2=A0struct r535_gr; > =C2=A0 > @@ -93,6 +94,10 @@ struct nvkm_rm_api { > =C2=A0 struct { > =C2=A0 int (*get_caps)(struct nvkm_disp *, int > *link_bw, bool *mst, bool *wm); > =C2=A0 int (*set_indexed_link_rates)(struct > nvkm_outp *); > + int (*sst)(struct nvkm_ior *, int head, bool > ef, > + =C2=A0=C2=A0 u32 watermark, u32 hblanksym, u32 > vblanksym); > + void (*vcpi)(struct nvkm_ior *, int head, > + =C2=A0=C2=A0=C2=A0=C2=A0 u8 slot, u8 slot_nr, u16 pbn, > u16 aligned_pbn); > =C2=A0 } dp; > =C2=A0 > =C2=A0 struct {