From: Neil Armstrong <neil.armstrong@linaro.org>
To: David Heidelberg <david@ixit.cz>, Sam Ravnborg <sam@ravnborg.org>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH v2] drm/panel: JDI LT070ME05000 simplify with dev_err_probe()
Date: Mon, 14 Aug 2023 14:40:05 +0200 [thread overview]
Message-ID: <b5878783-303c-410a-8542-3000e214bf78@linaro.org> (raw)
In-Reply-To: <20230812185239.378582-1-david@ixit.cz>
On 12/08/2023 20:52, David Heidelberg wrote:
> Use the dev_err_probe() helper to simplify error handling during probe.
> This also handle scenario, when EDEFER is returned and useless error is printed.
>
> Fixes error:
> panel-jdi-lt070me05000 4700000.dsi.0: cannot get enable-gpio -517
>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> resend:
> - applies cleanly on -next
> v2:
> - original v1 patch name "drm/panel: JDI LT070ME05000 remove useless warning"
> - use dev_err_probe function
>
> .../gpu/drm/panel/panel-jdi-lt070me05000.c | 36 ++++++++-----------
> 1 file changed, 14 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c b/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c
> index e94c98f00391..f9a69f347068 100644
> --- a/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c
> +++ b/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c
> @@ -400,38 +400,30 @@ static int jdi_panel_add(struct jdi_panel *jdi)
>
> ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(jdi->supplies),
> jdi->supplies);
> - if (ret < 0) {
> - dev_err(dev, "failed to init regulator, ret=%d\n", ret);
> - return ret;
> - }
> + if (ret < 0)
> + return dev_err_probe(dev, ret,
> + "failed to init regulator, ret=%d\n", ret);
>
> jdi->enable_gpio = devm_gpiod_get(dev, "enable", GPIOD_OUT_LOW);
> if (IS_ERR(jdi->enable_gpio)) {
> - ret = PTR_ERR(jdi->enable_gpio);
> - dev_err(dev, "cannot get enable-gpio %d\n", ret);
> - return ret;
> + return dev_err_probe(dev, PTR_ERR(jdi->enable_gpio),
> + "cannot get enable-gpio %d\n", ret);
> }
>
> jdi->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH);
> - if (IS_ERR(jdi->reset_gpio)) {
> - ret = PTR_ERR(jdi->reset_gpio);
> - dev_err(dev, "cannot get reset-gpios %d\n", ret);
> - return ret;
> - }
> + if (IS_ERR(jdi->reset_gpio))
> + return dev_err_probe(dev, PTR_ERR(jdi->reset_gpio),
> + "cannot get reset-gpios %d\n", ret);
>
> jdi->dcdc_en_gpio = devm_gpiod_get(dev, "dcdc-en", GPIOD_OUT_LOW);
> - if (IS_ERR(jdi->dcdc_en_gpio)) {
> - ret = PTR_ERR(jdi->dcdc_en_gpio);
> - dev_err(dev, "cannot get dcdc-en-gpio %d\n", ret);
> - return ret;
> - }
> + if (IS_ERR(jdi->dcdc_en_gpio))
> + return dev_err_probe(dev, PTR_ERR(jdi->dcdc_en_gpio),
> + "cannot get dcdc-en-gpio %d\n", ret);
>
> jdi->backlight = drm_panel_create_dsi_backlight(jdi->dsi);
> - if (IS_ERR(jdi->backlight)) {
> - ret = PTR_ERR(jdi->backlight);
> - dev_err(dev, "failed to register backlight %d\n", ret);
> - return ret;
> - }
> + if (IS_ERR(jdi->backlight))
> + return dev_err_probe(dev, PTR_ERR(jdi->backlight),
> + "failed to register backlight %d\n", ret);
>
> drm_panel_init(&jdi->base, &jdi->dsi->dev, &jdi_panel_funcs,
> DRM_MODE_CONNECTOR_DSI);
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
next prev parent reply other threads:[~2023-08-14 12:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-12 18:52 David Heidelberg
2023-08-14 12:40 ` Neil Armstrong [this message]
2023-08-14 12:46 ` Neil Armstrong
2023-08-14 12:50 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5878783-303c-410a-8542-3000e214bf78@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=david@ixit.cz \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®