From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51ECE320CAA for ; Fri, 19 Dec 2025 13:33:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766151199; cv=none; b=dFxiQ6InnCCCtjqGamrVD4sXxSYtPu1AVdgGgjaBzulTmyLwTz/r1SKuR3Vcg5HFQH9yUOTOPzL1FRSqzihiaV7mRkK/vnOC4baX7y1fuwPUau++epxqOBFVxCVh6bAv17qFR5Hp/xR7ePIfDzoFYI2inzhb0UyX4fkPfSS9gZM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766151199; c=relaxed/simple; bh=y/78bf5G8lbi5N5++TA4RIXe3uQy2zd6zGvGNvFcGsw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=W3IYCQNcms8yfnDh0XqNAg1memxxrKg8LxLGq+TGqocfEciXcsLtd1wQ3JMMFn2JsaV1EFEB93GZekEV/jsuzKgXAkNjBy13lW+09j4IGBWjKopkEkX7+2fzDkAbC9x7pswAgwfSnr11s1PS7jn9qh3XARhNvCfvIbuTTdoPg2c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=j7gJkZS8; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=K5erBheG; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="j7gJkZS8"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="K5erBheG" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BJBlTD13318713 for ; Fri, 19 Dec 2025 13:33:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= O9orEthglfu+PnjZEtg1EkiIu/RLCFUj7Foj950BKbA=; b=j7gJkZS8JIyUln21 3sDzcMn6Rz/XkNAJpjracuXz4vZzP3V9naurlQrV2EMBqbSIlcaKEG0h4Mhhj/1s FuCvtn9RtXtQd5hhvGPOGU2mkSpkE2XQ6L5SY1Js76SMHLm9Gw4ge0awbIT4nfuh QviP6wTAk8rmeXACVByOjPG4H1WbhRtGd5K3Dk32Qo+VTxTGFOkKMFrclrUpWNn+ b2q0O3trEh6PXp9shWgLQh4MCkVraX6P16qtDCiKy6ejUuiIDZt0/xBKioSZUIbK UPbE/ihlLqvTqVuOoF2Tv10PdIF8PZlenFCt9tQd5ewdR34AiNhLT957nPWzces5 jc73TA== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b4r2etr6d-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 19 Dec 2025 13:33:17 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4f1e17aa706so7727881cf.2 for ; Fri, 19 Dec 2025 05:33:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766151197; x=1766755997; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=O9orEthglfu+PnjZEtg1EkiIu/RLCFUj7Foj950BKbA=; b=K5erBheGXJ7v+pVkbkjNegr3hrFVlKMs4qQ5z8pmi0+xJ20qkvfUXMD12y5ALzkM/h xX365emBOqF3m8EAKcdm0ZHgm3MUxZ0b7HzibUGraqXofapVJ2XOmDvbLzkDbSujCPRX d2uY9wqFVjPwCdFUzIfph0KyACtKgxFUijlSXMiV/NfihiDlWL62Db1SzfQbTK0J1ETN QYp1unmxds9OWkIS1wiAZNsiySa71ifDUqPkdxYrkPjCW7csVhip8DhhoW+xl1zuT8QC GlZKjT5xe9oLRAP1lkPtCVjlZ9nQiwjxHV6ftYvLIFCzfk3t3KZih2tSIuUi0SWsCPOV 6XMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766151197; x=1766755997; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=O9orEthglfu+PnjZEtg1EkiIu/RLCFUj7Foj950BKbA=; b=Os7dhnm3FYGP7BunItm8n/z6XNuANHc25x2hvcPSE7yPvPHJpDBPGvUxn9NcqRAWtv xLANSf9pIMwvUsqsUaxM2aO63/JJA28+/lyFVo+g2SgYlIaVDHkYs5x9quYmmSQYhu6+ WZM5GFumZKyzUP/WEdafpBSXR1uhNZhKn0wfV34FDggJk9U3Q+bU9P6WQoMClxJn3Wp4 SvQ5a51K6kqPnn6dDJ4CLR08Nf4eGLO7omdRR9y1WmRKNpAhLFSOZ9G8WjrLxzNNgy4I sMstwzGf6RjjWtQ6RAvHmGu+UZkDnANOcjxxNPyLhzwDUaih0BliAEM+vmxEUY9CZEce 4mWQ== X-Forwarded-Encrypted: i=1; AJvYcCXq+dAkDJ+Nz/uwA8hbNPuAlr16c0+JpSPMezWEvfp3RtmRRt094hCw7pF90r/t9nkGtTTfth00KhZYrT8=@vger.kernel.org X-Gm-Message-State: AOJu0YygofKvIuKt0HvWasSr1LSqBx3apskJwZ4r0sLNQqlbpL/5rzfz mE8fzUpxkUCq2iUKSRJqC0QywixjvWI4cLu+x98ptUfRq1LlTLR7iZWEkyANLUpuCs8Q7gngf1T zLfjHBC+QHy4AO2uORXvnAZ+DRbo4h0HT7KE/nCJ2N7nvvUwzRnyhIseO7m6Ct59ENVo= X-Gm-Gg: AY/fxX6eMAksOzNF+I9G9DEgQyyGhT4AaZX0llB4R7DgjfvRfA92JjW6/b+BAK0vkry ldKjPAKupGM9DZR2u9lkD3eHIIpvGp1hGgrY+o/k/3mJFZqSf0xfrCNeL4FUhqWD9q+ZOYV/IX+ sMQyO59APWHhhK8KFPmeVvEcdEl/XqwlkneNVnpwGlHIU22Sj7kMakWw2dVqC+ZpddEWTUhSvzV om5HZMAptskcmAX5bxCk/nvFvIW1yb3ygAqtNIjOHm0TRcWYeOyiOkm7NeTo4m8RYGcQE4LS1hT 6qc0IYEHCVKaZNV8/1SVsyk+fofSobiizIUL/j/0o18OISPoeTc/EoOrqAy4VLX5llm67PsqJyj eV2Qd4n8kVUcYLoVCYuyl4v50Xw/Dd4bHR1wDHc8nMMeEnGkHF3CgKOCZqKp5jQyCYg== X-Received: by 2002:a05:622a:14:b0:4ee:1367:8836 with SMTP id d75a77b69052e-4f4abd1239emr30865621cf.5.1766151196481; Fri, 19 Dec 2025 05:33:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IFCRQttfRGvz4IETD4ibzOBiHm3VS45e6KRJmrOxaGhERSR383GVg/VvQup5ivuLKP3chW7qw== X-Received: by 2002:a05:622a:14:b0:4ee:1367:8836 with SMTP id d75a77b69052e-4f4abd1239emr30865151cf.5.1766151195895; Fri, 19 Dec 2025 05:33:15 -0800 (PST) Received: from [192.168.119.72] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64b90414649sm2245506a12.0.2025.12.19.05.33.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Dec 2025 05:33:15 -0800 (PST) Message-ID: Date: Fri, 19 Dec 2025 14:33:13 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] arm64: dts: qcom: monaco: add lt8713sx bridge with displayport To: Vishnu Saini Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Vishnu Saini , prahlad.valluru@oss.qualcomm.com, Prahlad Valluru References: <20251120-lt8713sx-bridge-linux-for-next-v1-0-2246fc5fb490@qti.qualcomm.com> <20251120-lt8713sx-bridge-linux-for-next-v1-1-2246fc5fb490@qti.qualcomm.com> <7d31f45b-1062-4118-8769-49209908f2ef@oss.qualcomm.com> <4112ba0b-6feb-4e30-a57e-50ef9e3d6b5e@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: gfmSE0ySwzlMdEPtm1ign_el73rTO8FG X-Proofpoint-ORIG-GUID: gfmSE0ySwzlMdEPtm1ign_el73rTO8FG X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE5MDExMyBTYWx0ZWRfX1+QaF47SqusM rm39q0KgGNwHNAN54G5gbzoC8rt2Pq/RW+ICLMGoHiFkEgDFmo8c0niagL32BUsNSnP7njQeuzM iNlglkWkTHfbb6Xo9SBHHGffSfKICC/d7SsMWdtFI47KM6FFmOMpyaspQOjLJGQZ4wzk212b5fO bQF6tnIX5CylG2fu5uR4sg14XGYYMhbqVF8usVnmoxfjwUpE3qV4fftbKNropOKAFhcFweCWaa1 wqb/LfWpoGZi+drgrhZWpi/l7ACy2/AsHhg7aaBMnRMCVo598sSFpx6+SzoxhyKrw567VpjQJNB E7986Ze3ppJf9kibjMOr82oxtxGajYtQlHlwUh8ZRgMHoa553TDCCver2ta/wzA0Xe93VbJEK5n kYJU30NPHKE5KvRmTPSwFdB0huV8PzvdT629tE4u7Xg/7htt/SuMgMKh9i/AolsIWC2TbKc6EFz rvC7Xt2tgzF8j4U5wVg== X-Authority-Analysis: v=2.4 cv=Tp7rRTXh c=1 sm=1 tr=0 ts=6945541d cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=VRXACKE1YIbZzR_II2oA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-19_04,2025-12-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 impostorscore=0 malwarescore=0 spamscore=0 phishscore=0 priorityscore=1501 lowpriorityscore=0 suspectscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512190113 On 12/19/25 1:59 PM, Vishnu Saini wrote: > On Fri, Dec 19, 2025 at 01:10:19PM +0100, Konrad Dybcio wrote: >> On 12/19/25 12:20 PM, Vishnu Saini wrote: >>> On Thu, Nov 20, 2025 at 01:11:00PM +0100, Konrad Dybcio wrote: >>>> On 11/20/25 11:58 AM, Vishnu Saini wrote: >>>>> Monaco-evk has LT8713sx which act as DP to 3 DP output >>>>> converter. Edp PHY from monaco soc is connected to lt8713sx >>>>> as input and output of lt8713sx is connected to 3 mini DP ports. >>>>> Two of these ports are available in mainboard and one port >>>>> is available on Mezz board. lt8713sx is connected to soc over >>>>> i2c0 and with reset gpio connected to pin6 or ioexpander5. >>>>> >>>>> Enable the edp nodes from monaco and enable lontium lt8713sx >>>>> bridge node. >>>>> >>>>> Co-developed-by: Prahlad Valluru >>>>> Signed-off-by: Prahlad Valluru >>>>> Signed-off-by: Vishnu Saini >>>>> --- >> >> [...] >> >>>>> + qup_i2c0_default: qup-i2c0-state { >>>>> + pins = "gpio17", "gpio18"; >>>>> + function = "qup0_se0"; >>>>> + drive-strength = <2>; >>>>> + bias-pull-up; >>>> >>>> Similarly, you can move these settings to monaco.dtsi and keep them as >>>> defaults since 99.99% of I2C users will share them >>> Is it ok if i update this in a different series, similar other nodes like qup_i2c1_default >>> added in monaco-evk.dts? >> >> No, I don't want you to introduce something "wrong" only because you >> don't want to run git commit --amend >> >> I see you've now sent a v2 just 7 minutes after asking this question. >> Should I interpret that as you expecting me to drop everything and rush >> to respond to your queries immediately, or do you not care about my >> feedback anyway? > Apologies, for quickly raising the new patch, i thought of correcting this > in next V3 patch if you ask for. > I am new contributor to the upstream community, just now i setup mutt and learned a bit about > sending reply to the emails and V2 patch was already validated that's why i submitted it. It's okay. Just please try not to do it again - it's really an anti-pattern. > monaco.dtsi already have below node except drive-strength and bias-pull-up. > tlmm { > qup_i2c0_data_clk: qup-i2c0-data-clk-state { > pins = "gpio17", "gpio18"; > function = "qup0_se0"; > }; > }; > I will add drive-strength and bias-pull-up in monaco-evk.dts, let me know if this is ok? That should be fine. Other SoC DTSIs do that already Konrad