Re: [PATCH] mtd: MTD_INTEL_DG should depend on DRM_I915 or DRM_XE

[Jani Nikula <jani.nikula@linux.intel.com>]

On Wed, 30 Jul 2025, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> Hi Jani,
>
> On Wed, 30 Jul 2025 at 12:32, Jani Nikula <jani.nikula@linux.intel.com> wrote:
>> On Wed, 30 Jul 2025, Geert Uytterhoeven <geert+renesas@glider.be> wrote:
>> > Intel Discrete Graphics non-volatile memory is onlt present on intel
>> > discrete graphics devices, and its auxiliary device is instantiated by
>> > the Intel i915 and Xe2 DRM drivers.  Hence add dependencies on DRM_I915
>> > and DRM_XE, to prevent asking the user about this driver when
>> > configuring a kernel without Intel graphics support.
>> >
>> > Fixes: ceb5ab3cb6463795 ("mtd: add driver for intel graphics non-volatile memory device")
>> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>> > ---
>> >  drivers/mtd/devices/Kconfig | 4 ++--
>> >  1 file changed, 2 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/drivers/mtd/devices/Kconfig b/drivers/mtd/devices/Kconfig
>> > index 46cebde79f34b0b7..f0ab74d695347117 100644
>> > --- a/drivers/mtd/devices/Kconfig
>> > +++ b/drivers/mtd/devices/Kconfig
>> > @@ -185,8 +185,8 @@ config MTD_POWERNV_FLASH
>> >
>> >  config MTD_INTEL_DG
>> >       tristate "Intel Discrete Graphics non-volatile memory driver"
>> > -     depends on AUXILIARY_BUS
>> > -     depends on MTD
>> > +     depends on AUXILIARY_BUS && MTD
>> > +     depends on DRM_I915 || DRM_XE || COMPILE_TEST
>>
>> I understand the intent, but IIUC auxiliary bus usage should not require
>> a "depends on" relationship. Couldn't you have MTD_INTEL_DG=y and
>> DRM_I915=m just fine?
>
> That is indeed a good point!
>
> What about
>
>     depends on DRM_I915!=n || DRM_XE!=n || COMPILE_TEST
>
> instead?

Fine by me, up to Alexander.

BR,
Jani.



-- 
Jani Nikula, Intel