From: Neil Armstrong <neil.armstrong@linaro.org>
To: Sander Vanheule <sander@svanheule.net>,
Rob Herring <robh+dt@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Rob Herring <robh@kernel.org>,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH v3] dt-bindings: pinctrl: convert semtech,sx150xq bindings to dt-schema
Date: Fri, 18 Nov 2022 16:23:08 +0100 [thread overview]
Message-ID: <b5970487-9326-9d41-a004-6369e854e530@linaro.org> (raw)
In-Reply-To: <79ba65cc117db8102bd8f7e30d6d44fdbd0542f1.camel@svanheule.net>
On 18/11/2022 16:19, Sander Vanheule wrote:
> Hi,
>
> On Tue, 2022-11-15 at 11:06 +0100, Neil Armstrong wrote:
>> This converts the Semtech SX150Xq bindings to dt-schemas, add necessary
>> bindings documentation to cover all differences between HW variants
>> and current bindings usage.
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>> Reviewed-by: Rob Herring <robh@kernel.org>
>> ---
>> To: Linus Walleij <linus.walleij@linaro.org>
>> To: Rob Herring <robh+dt@kernel.org>
>> To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
>> Cc: linux-gpio@vger.kernel.org
>> Cc: devicetree@vger.kernel.org
>> Cc: linux-kernel@vger.kernel.org
>> ---
>> Changes in v3:
>> - Resent with missing To: Linus Walleij
>> - Link to v2: https://lore.kernel.org/r/20221005-mdm9615-sx1509q-yaml-v2-0-a4a5b8eecc7b@linaro.org
>>
>> Changes in v2:
>> - fixed rob comments
>> - added rob's Reviewed-by
>> - Link to v1: https://lore.kernel.org/r/20221005-mdm9615-sx1509q-yaml-v1-0-0c26649b637c@linaro.org
>> ---
>
> [snip]
>
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + enum:
>> + - semtech,sx1503q
>> + - semtech,sx1506q
>> + then:
>> + patternProperties:
>> + '-cfg$':
>> + properties:
>> + pins:
>> + items:
>> + pattern: '^gpio[0-15]$'
>
> [snip]
>
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + const: semtech,sx1509q
>> + then:
>> + patternProperties:
>> + '-cfg$':
>> + properties:
>> + pins:
>> + items:
>> + pattern: '^(oscio|gpio[0-15])$'
>
> Sorry to be so late to reply, but don't these patterns only match "gpio0", "gpio1", and "gpio5"?
>
> A quick search for some datasheets turned up the SX1503 and SX1509Q with 16 GPIOs, so I assume the
> intention was to match "gpio0" to "gpio15". I think this should be "^(gpio[0-9]|gpio1[0-5])$" (or
> something equivalent).
Damn you're right, Linus should I resend or send a fixup ?
Thanks,
Neil
>
> Best,
> Sander
next prev parent reply other threads:[~2022-11-18 15:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 10:06 Neil Armstrong
2022-11-17 8:56 ` Linus Walleij
2022-11-18 14:39 ` Neil Armstrong
2022-11-17 8:58 ` Linus Walleij
2022-11-18 15:19 ` Sander Vanheule
2022-11-18 15:23 ` Neil Armstrong [this message]
2022-11-21 13:51 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5970487-9326-9d41-a004-6369e854e530@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sander@svanheule.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®