From: Peilin Ye <yepeilin@google.com>
To: bpf@vger.kernel.org
Cc: Peilin Ye <yepeilin@google.com>,
Alexei Starovoitov <ast@kernel.org>,
Eduard Zingerman <eddyz87@gmail.com>, Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>,
Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>,
"Paul E. McKenney" <paulmck@kernel.org>,
Puranjay Mohan <puranjay@kernel.org>,
Xu Kuohai <xukuohai@huaweicloud.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Quentin Monnet <qmo@kernel.org>,
Mykola Lysenko <mykolal@fb.com>, Shuah Khan <shuah@kernel.org>,
Josh Don <joshdon@google.com>, Barret Rhoden <brho@google.com>,
Neel Natu <neelnatu@google.com>,
Benjamin Segall <bsegall@google.com>,
David Vernet <dvernet@meta.com>,
Dave Marchevsky <davemarchevsky@meta.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH RFC bpf-next v1 3/4] selftests/bpf: Delete duplicate verifier/atomic_invalid tests
Date: Sat, 21 Dec 2024 01:25:57 +0000 [thread overview]
Message-ID: <b59b9954a5bb8ee03f1cf8924a89bcd4b475511e.1734742802.git.yepeilin@google.com> (raw)
In-Reply-To: <cover.1734742802.git.yepeilin@google.com>
Right now, the BPF_ADD and BPF_ADD | BPF_FETCH cases are tested twice:
#55/u atomic BPF_ADD access through non-pointer OK
#55/p atomic BPF_ADD access through non-pointer OK
#56/u atomic BPF_ADD | BPF_FETCH access through non-pointer OK
#56/p atomic BPF_ADD | BPF_FETCH access through non-pointer OK
#57/u atomic BPF_ADD access through non-pointer OK
#57/p atomic BPF_ADD access through non-pointer OK
#58/u atomic BPF_ADD | BPF_FETCH access through non-pointer OK
#58/p atomic BPF_ADD | BPF_FETCH access through non-pointer OK
Reviewed-by: Josh Don <joshdon@google.com>
Signed-off-by: Peilin Ye <yepeilin@google.com>
---
tools/testing/selftests/bpf/verifier/atomic_invalid.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/tools/testing/selftests/bpf/verifier/atomic_invalid.c b/tools/testing/selftests/bpf/verifier/atomic_invalid.c
index 25f4ac1c69ab..8c52ad682067 100644
--- a/tools/testing/selftests/bpf/verifier/atomic_invalid.c
+++ b/tools/testing/selftests/bpf/verifier/atomic_invalid.c
@@ -13,8 +13,6 @@
}
__INVALID_ATOMIC_ACCESS_TEST(BPF_ADD),
__INVALID_ATOMIC_ACCESS_TEST(BPF_ADD | BPF_FETCH),
-__INVALID_ATOMIC_ACCESS_TEST(BPF_ADD),
-__INVALID_ATOMIC_ACCESS_TEST(BPF_ADD | BPF_FETCH),
__INVALID_ATOMIC_ACCESS_TEST(BPF_AND),
__INVALID_ATOMIC_ACCESS_TEST(BPF_AND | BPF_FETCH),
__INVALID_ATOMIC_ACCESS_TEST(BPF_OR),
--
2.47.1.613.gc27f4b7a9f-goog
next prev parent reply other threads:[~2024-12-21 1:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-21 1:22 [PATCH RFC bpf-next v1 0/4] Introduce load-acquire and store-release BPF instructions Peilin Ye
2024-12-21 1:24 ` [PATCH RFC bpf-next v1 1/4] bpf/verifier: Factor out check_load() Peilin Ye
2024-12-21 1:25 ` [PATCH RFC bpf-next v1 2/4] bpf: Introduce load-acquire and store-release instructions Peilin Ye
2024-12-24 10:07 ` Xu Kuohai
2024-12-26 23:07 ` Peilin Ye
2024-12-27 0:23 ` Peilin Ye
2024-12-27 9:20 ` Peilin Ye
2024-12-30 8:27 ` Xu Kuohai
2024-12-31 1:15 ` Peilin Ye
2025-01-04 0:12 ` Eduard Zingerman
2025-01-07 1:08 ` Peilin Ye
2025-01-07 1:20 ` Eduard Zingerman
2025-01-07 8:25 ` Peilin Ye
2024-12-21 1:25 ` Peilin Ye [this message]
2024-12-21 1:26 ` [PATCH RFC bpf-next v1 4/4] selftests/bpf: Add selftests for " Peilin Ye
2024-12-23 20:18 ` Peilin Ye
2025-01-04 1:11 ` Eduard Zingerman
2025-01-07 1:12 ` Peilin Ye
2024-12-21 7:19 ` [PATCH RFC bpf-next v1 0/4] Introduce load-acquire and store-release BPF instructions Peilin Ye
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b59b9954a5bb8ee03f1cf8924a89bcd4b475511e.1734742802.git.yepeilin@google.com \
--to=yepeilin@google.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brho@google.com \
--cc=bsegall@google.com \
--cc=catalin.marinas@arm.com \
--cc=daniel@iogearbox.net \
--cc=davemarchevsky@meta.com \
--cc=dvernet@meta.com \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=joshdon@google.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mykolal@fb.com \
--cc=neelnatu@google.com \
--cc=paulmck@kernel.org \
--cc=puranjay@kernel.org \
--cc=qmo@kernel.org \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=will@kernel.org \
--cc=xukuohai@huaweicloud.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®