From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B338C4321A for ; Fri, 28 Jun 2019 15:17:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F2C742133F for ; Fri, 28 Jun 2019 15:17:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726953AbfF1PRf (ORCPT ); Fri, 28 Jun 2019 11:17:35 -0400 Received: from s3.sipsolutions.net ([144.76.43.62]:53360 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726795AbfF1PRe (ORCPT ); Fri, 28 Jun 2019 11:17:34 -0400 Received: by sipsolutions.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1hgsd2-0004T1-MI; Fri, 28 Jun 2019 17:17:32 +0200 Message-ID: Subject: Re: [Linux-kernel-mentees][PATCH v2] nl80211: Fix undefined behavior in bit shift From: Johannes Berg To: Shuah Khan , Jiunn Chang Cc: linux-kernel-mentees@lists.linuxfoundation.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 28 Jun 2019 17:17:30 +0200 In-Reply-To: <9e17c585-bd42-8c65-a37a-add6aa4d5ca4@linuxfoundation.org> (sfid-20190628_170419_565002_8FFEF936) References: <20190627010137.5612-4-c0d1n61at3@gmail.com> <20190627032532.18374-4-c0d1n61at3@gmail.com> <8b8c44c3ecb8626d9bb5a8f786b1d2b7488df86b.camel@sipsolutions.net> <9e17c585-bd42-8c65-a37a-add6aa4d5ca4@linuxfoundation.org> (sfid-20190628_170419_565002_8FFEF936) Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-3.fc28) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Shuah, > I went looking in the git log. Looks like there are several commits with > "Changes since" included in the commit log. It still appears to be > maintainer preference. Probably from networking and networking related > areas - wireless being one of them. This trend is recent it appears in > any case. Yeah. I was really just observing that I'd seen this, and some people (I guess 'many' was an exaggeration) actively request it to be in the commit log. I "grew up" with "changelog after ---" too ;-) > There is a value to seeing changes as the work evolves. However, there > is the concern that how log should it be. That doesn't parse, what did you mean? > This example commit has history from RFC stage and no doubt very useful > since this is a new driver. > > 8ef988b914bd449458eb2174febb67b0f137b33c > > If we make this more of a norm, we do want to make sure, we evolve > from informal nature of these "Changes since", to "Commit log" text. Not sure it's really worth it, but I guess some recommendations could be useful. If it is indeed to become the norm, and there aren't some people who strongly feel it should *not* be included. johannes