From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC 1/3] arm64: dts: qcom: sm8750: Add Iris VPU v3.5
Date: Tue, 15 Jul 2025 12:09:44 +0200 [thread overview]
Message-ID: <b5a68138-4eca-4bdd-8f72-d80236b02c0a@oss.qualcomm.com> (raw)
In-Reply-To: <15b8b9e0-a211-4102-9b68-994c8ab50a7a@linaro.org>
On 7/15/25 12:07 PM, Krzysztof Kozlowski wrote:
> On 15/07/2025 11:32, Krzysztof Kozlowski wrote:
>> On 14/07/2025 15:55, Krzysztof Kozlowski wrote:
>>> +
>>> + videocc: clock-controller@aaf0000 {
>>> + compatible = "qcom,sm8750-videocc";
>>> + reg = <0x0 0x0aaf0000 0x0 0x10000>;
>>> + clocks = <&bi_tcxo_div2>,
>>> + <&gcc GCC_VIDEO_AHB_CLK>;
>>> + power-domains = <&rpmhpd RPMHPD_MMCX>;
>>
>> This is incomplete, need second power domain and I did not check against
>> qcom,sm8750-videocc schema before sending. I will send a v2 a bit later
>> (maybe some reviews pop up).
>
> Heh, no. The DTS here is correct. The videocc bindings are not correct
> (and that's not my patch).
Well, you want two power domains here in either case..
Konrad
next prev parent reply other threads:[~2025-07-15 10:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-14 13:55 [PATCH RFC 0/3] " Krzysztof Kozlowski
2025-07-14 13:55 ` [PATCH RFC 1/3] " Krzysztof Kozlowski
2025-07-15 9:32 ` Krzysztof Kozlowski
2025-07-15 10:07 ` Krzysztof Kozlowski
2025-07-15 10:09 ` Konrad Dybcio [this message]
2025-07-15 10:28 ` Taniya Das
2025-07-15 10:34 ` Krzysztof Kozlowski
2025-07-15 10:50 ` Konrad Dybcio
2025-07-16 11:30 ` Krzysztof Kozlowski
2025-07-14 13:55 ` [PATCH DO NOT MERGE RFC 2/3] arm64: dts: qcom: sm8750-mtp: Enable Iris codec Krzysztof Kozlowski
2025-07-14 13:55 ` [PATCH DO NOT MERGE RFC 3/3] arm64: dts: qcom: sm8750-qrd: " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5a68138-4eca-4bdd-8f72-d80236b02c0a@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®