From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D36CC433FE for ; Tue, 29 Nov 2022 16:01:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232159AbiK2QBi (ORCPT ); Tue, 29 Nov 2022 11:01:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236088AbiK2QBA (ORCPT ); Tue, 29 Nov 2022 11:01:00 -0500 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DEEF5697CB for ; Tue, 29 Nov 2022 07:59:23 -0800 (PST) Received: by mail-lf1-x132.google.com with SMTP id c1so22702655lfi.7 for ; Tue, 29 Nov 2022 07:59:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=bDvxVOu+PnvvHRulbZFibX61kwkQP19u6RVUNmmpkgY=; b=bw/kC+x+9HZsxIhQWPogLf1q10xRBgTta5JXdbQzEI3yOW1lB1zVd+DO+mU9OChNsp OwiHrMEjR3cjneLpBilCu5WReSjHfNk1WtkziQM+nASpT277TBPjRo08F0XoVf7DyVJV EQ3+bYudZ/j90oQrP9gpstBeWCQtuha7r6Lr1vQOPG1Yc20bkJeRINKzwAKyiKzpK7ws roEH+azxI+KRjYeHxbMaT39a8q9We7+RTbU81GNNnUV0EqFedsVhQ26bvdjMMRwNv1pr N9Wv0gtWbmS8uSJWUkOn2gXRo9JdZq2tNKFyVWiTSEGV4+GkE6AZuqoLcRlZYPkfDvVI ZW7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bDvxVOu+PnvvHRulbZFibX61kwkQP19u6RVUNmmpkgY=; b=jqqsvnogxCQAYpXTEAgqI5SNSLGuHh/gj5adjDkmWPul9fzHq45GLOkNw/32VYUgs/ cWFb8aL1KknDUXEVgugII5e26IbDyOU04+MubJe9EW5Nn9LwrHxH+y29Hs7s8mYDe06s lLBhgBZkJrgs8monDNbbNNsA8y06d4w/w6ZrX8XzhmTl/fMstakgJS/+CI8mycVP+WlK vTQ83bqpYtYmoEWpM1nPZ9zq2QgQ+2WLrkR5pPCNZxzcFFyl1HlkAg7c967XnIGqzZvu +2KPvy1s6MUrvc0t88Hx3xJpefGzdW53Re7fUXSvBwHW1qnaibWYPZ2FNEZSvs5pPku8 a0tg== X-Gm-Message-State: ANoB5pnd08Ng0LzKzDastaVQj2sZFtcbNWdEjZd8zD9YSmKqKgJ9C+iC d8fOyt2/NaFEgJkCgz60T+5zTA== X-Google-Smtp-Source: AA0mqf6s6h21gBLJgUb7HsJExGWf4j/ozGnG1ZJJ/G04lnH7uEnRrIfZndNl3qwLh6+Y0H8lkADvEA== X-Received: by 2002:a05:6512:1505:b0:4af:b5d0:695e with SMTP id bq5-20020a056512150500b004afb5d0695emr20039824lfb.6.1669737562297; Tue, 29 Nov 2022 07:59:22 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id z15-20020a056512370f00b004a9b9ccfbe6sm2282883lfr.51.2022.11.29.07.59.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Nov 2022 07:59:21 -0800 (PST) Message-ID: Date: Tue, 29 Nov 2022 16:59:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] dt-bindings: mmc: Make comment on wakeup-source less confusing Content-Language: en-US To: Ulf Hansson Cc: Christoph Niedermaier , linux-kernel@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Marek Vasut , kernel@dh-electronics.com, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org References: <20221122111124.6828-1-cniedermaier@dh-electronics.com> <20221122111124.6828-3-cniedermaier@dh-electronics.com> <55c29f92-4c6b-266f-2004-ae633a658963@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/11/2022 16:30, Ulf Hansson wrote: > On Tue, 29 Nov 2022 at 13:36, Krzysztof Kozlowski > wrote: >> >> On 22/11/2022 12:11, Christoph Niedermaier wrote: >>> The current comment on wakeup-source is a bit confusing, because it isn't >>> clear at first sight which property is actually deprecated. >>> Change the comment to one that is less confusing. >> >> It's still confusing - you mention some non-existing property. I don't >> think it's worth to touch it. If you insist, drop entire comment... > > Hmm, it doesn't look that easy to me. The "enable-sdio-wakeup" is > indeed a deprecated wakeup property [1], but it seems like it's not > really described somewhere. I wouldn't mind removing it (as it seems > to add some confusions), but in that case it needs to be entirely > removed from the DT docs, right? Yes, from the bindings and from DTSes. It's already gone from mmc-controller.yaml bindings, so basically we already did the most of such removal. > > Another option, would be to add a proper description of the property > and mark it with "deprecated: true". Best regards, Krzysztof