From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87A23C77B7C for ; Wed, 31 May 2023 11:37:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235094AbjEaLh2 (ORCPT ); Wed, 31 May 2023 07:37:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230341AbjEaLhZ (ORCPT ); Wed, 31 May 2023 07:37:25 -0400 Received: from mx.sberdevices.ru (mx.sberdevices.ru [45.89.227.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 601C4E8; Wed, 31 May 2023 04:37:21 -0700 (PDT) Received: from s-lin-edge02.sberdevices.ru (localhost [127.0.0.1]) by mx.sberdevices.ru (Postfix) with ESMTP id 0A5605FD56; Wed, 31 May 2023 14:37:19 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1685533039; bh=sbZRDG56hPIOzkNrYqptHD1M16aZFlNz8dicpHblK9c=; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; b=lGO/LXW0zAg/oFZRQl6qF6g1JvO/wxAO9tqaA4tCpeWiXRuRmFlZsZpErm100gOzC HB4DQD64WsksKD2W0V8IDBM053e1Nrkc3NADDTgboXzh77lw7wMz0ja6lP4T69F5Sd EYF6c7U83SW2rX60lS6mifkjOBl5IHkNxsApjySWKY4EtOJJjnvmghzQHzJ/748B5o 4XcKfCeYYxRfnyLV8nXbavS50N0RX/sh0XP0lkT2CEr43mKnkS/xLHn806hD5Eh7My dEAG7MSVM8ww9VY3FauUKhJFSQSZ2ng9CxTMoWuhlZ2C0av2BNFmKxnJ6pUI3df/Da jwLtn/leQmmgA== Received: from S-MS-EXCH01.sberdevices.ru (S-MS-EXCH01.sberdevices.ru [172.16.1.4]) by mx.sberdevices.ru (Postfix) with ESMTP; Wed, 31 May 2023 14:37:16 +0300 (MSK) Message-ID: Date: Wed, 31 May 2023 14:33:03 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v1] meson saradc: fix clock divider mask length Content-Language: en-US To: Martin Blumenstingl CC: "jic23@kernel.org" , Dmitry Rokosov , "lars@metafoo.de" , "neil.armstrong@linaro.org" , "khilman@baylibre.com" , "jbrunet@baylibre.com" , "andy.shevchenko@gmail.com" , "nuno.sa@analog.com" , "linux-iio@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-amlogic@lists.infradead.org" , "linux-kernel@vger.kernel.org" , kernel , Vyacheslav References: <20230515210545.2100161-1-gnstark@sberdevices.ru> <6910550a-b025-0d97-0b39-bc89b235541e@sberdevices.ru> From: George Stark In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [172.16.1.6] X-ClientProxiedBy: S-MS-EXCH01.sberdevices.ru (172.16.1.4) To S-MS-EXCH01.sberdevices.ru (172.16.1.4) X-KSMG-Rule-ID: 4 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiPhishing: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 1.1.2.30, bases: 2023/05/31 06:02:00 #21385342 X-KSMG-AntiVirus-Status: Clean, skipped Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/29/23 23:41, Martin Blumenstingl wrote: > Hi George, > > On Mon, May 22, 2023 at 5:47 PM Старк Георгий Николаевич > wrote: >> Hello Martin >> >> Actually you were right that my patch affects only meson8 family not the all new ones, my bad. >> It's clear from the driver code meson_saradc.c and dts files. >> I've made an experiment on a113l soc - changingclock_rate inmeson_sar_adc_param and measuring adc channel many times >> and with low clockfrequency (priv->adc_clk) time of measurementis high >> and vice versa. ADC_CLK_DIV field in SAR_ADC_REG3 is always zero. > Thanks for sharing your findings! > >> I need to get s805 (meson8) board for example and made experiment on it. > If you don't find any Meson8 (S802)/Meson8b (S805) or Meson8m2 (S812) > board then please provide the code that you used for your experiment > as a patch so I can give it a try on my Odroid-C1 (Meson8b). Hello Martin Thanks for the help! I managed to get Odroid-C1 myself. I think it'll be useful to test further patches. By the way seems like the board and the sock are not popular anymore... It remains only to build mainline kernel for meson8 to perform tests. Hope to be back soon. Best regards George > > > Best regards, > Martin >