From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34E5623EA93 for ; Sun, 5 Apr 2026 00:21:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775348515; cv=none; b=tcHYH0E1v+mQXragd8zakTQWX2dFVdrdTy4Tryb1gMhzSuGMpj6CQq6nJQwyZj4iWJvYqy5heF7uo3bbQAMxSamN0/rft6Nx90Ckp2dCXcPptkHDDqtUOfgHN0vkpbIQohIPou/KEkKAhDWQiJSASO4RgjXctDY1+Oo0Oaq5QT8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775348515; c=relaxed/simple; bh=tqWs+zzx709MgWZt3PmvYlKpoqqid78J2QNdrEuuRig=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iS1L31r9DJLtILtjfo1D3w9PHvwXQ9Z2LJeZLl/z8J109xl2fpHUCapKkS3sZAdur593K6q+FQIMAP80ip1Su6F6kPCFmHAMLMkaMGVqOb0+usclEvV9T8TX6CrRR692PFlGVWYv7czapVuBBy+yiPs238fBpU3Tnx/T91ZFBAE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=OMMg/Bb/; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OMMg/Bb/" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-483487335c2so29379785e9.2 for ; Sat, 04 Apr 2026 17:21:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1775348512; x=1775953312; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/bPmswsl0ZEMtXy2tMsgQsJ71tmyi4kiw2oOvZ6aYTA=; b=OMMg/Bb/Lwv/ZtLsRo4wcxuEpVNGKc5KTTL3DmJmxTr8IXVRrn0l6YLvJkBqeWtVSQ 2ce0IMabicu2A4jPi0q6qNsb44MN1E5zLOs5TuOx83dmqie0/xWLHx3bme4CLmKALhDN CUKf98HnWAU3NmtM7GMP0LL/5oX3vs2dA2GFFNABIWLHsmHKw8qCQNo5SdlfwJnlFxzN 1wDwhNwMmlDu5yeliyWzq8HFK+LU3J1TgvYZHoaP4Fon9cCEZwvplcfynv/q7zAjCtmI d+sqNPCi71Ao89IX0RTlZVzX7Qdecydv3ggiUEoAnOlaXqK/6O20JNH5N5xKO84txYej 9JMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775348512; x=1775953312; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/bPmswsl0ZEMtXy2tMsgQsJ71tmyi4kiw2oOvZ6aYTA=; b=BCAou0bFgu+lHaejc3Bhl+3RNIFrfpXncktjcqEVDKB0Llw4fzd63B1PThvlOf8EGP oCF1EAKxvUMWcCPtirRAll/QWywPUEra/TEOH1yuCNuRdlakGjPjXkPm3OLpMtqjTHXY Ekuc1lMCNXkb0OKJIgCfpJK/bunzYQuB3h5ApC1IwDpRZojA++i+cEkk6gMsMlBfNs2X jS5oWYKOdRu9pyhOyCfog2pFqS7bUgxvMgyERIyQFfcJU3XqN71LykfrPrF0IVexeS7y 9cfLpykDsHByM8uH/1wo1SCDr+LS04hi0bQNqGa6J8+yHo9ky7hhhF4fXPbU0VRwSyqm OV2g== X-Forwarded-Encrypted: i=1; AJvYcCUXx13XNSz78z0jTmzSvTouhB4Ko23E0qUfoQ0Ln7vOycj1bSQTrceq71gC6/vluqRnq9sWrlQQJBRGy2o=@vger.kernel.org X-Gm-Message-State: AOJu0YxkRecGo7c6Nd5CJzKfTo0RsyzsA4o85W678niWuODKNLGrr2VU blnDSZDMuWlLKCQAsAlrtCwRcJTWqCqEke+QXvM6Fog82dvZZA7CtL12x1IfFEH3STw= X-Gm-Gg: AeBDiesFqKocal3H1zltidVBUJOalYP7plivc9RXQxJ5v2QlD47puDzEs9AHV6j4eSI 9cZw8DuY/eRD3oUinDCPPsBxaxGjJ+VpGO92CNvMTvfmrvQ0R0rO/+jbdLnF/6L/uMcXteKTyIC dLU1hTC3d96QCRxjm/DQKyBCoMjUexsxUxIVG4mhyB9Qoqxxw0kxk48kSoKCFdjgT3pdjbIgeJ6 XWLoMwlJ8FweCEbwR1AvPTkPULpydGFrMKT46XsqrI7CRrmxrlJLK2axJRX4oJBjmbVXYiw3UyA bmyffZQfeuBwLe3DjOXmVf9OiYSFpItytcApGlP/TpZ4vxiqVty/WYY0OoRoh4R65B+miUq03OW i6vHdejOBILTaDJGd6Zr7FuqoIANPb2vMTlR0Z13mlR0PQJISC3qC051RyVMbB4NtI7KSlYlXQb LDA5vQdcR1OOQ9jsod5qong87IZnwwZ6KIXTCtvNppdtl8Vw== X-Received: by 2002:a05:6000:2482:b0:43b:851c:4483 with SMTP id ffacd0b85a97d-43d29276b96mr11673051f8f.4.1775348512511; Sat, 04 Apr 2026 17:21:52 -0700 (PDT) Received: from [192.168.0.35] ([109.77.125.194]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d1e4e221bsm26296263f8f.29.2026.04.04.17.21.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 04 Apr 2026 17:21:51 -0700 (PDT) Message-ID: Date: Sun, 5 Apr 2026 01:21:49 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/4] arm64: dts: qcom: x1e80100-dell-xps13-9345: introduce EC To: Aleksandrs Vinarskis , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, laurentiu.tudor1@dell.com, Abel Vesa , Tobias Heider , Val Packett References: <20260404-dell-xps-9345-ec-v2-0-c977c3caa81f@vinarskis.com> <20260404-dell-xps-9345-ec-v2-4-c977c3caa81f@vinarskis.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20260404-dell-xps-9345-ec-v2-4-c977c3caa81f@vinarskis.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 04/04/2026 13:55, Aleksandrs Vinarskis wrote: > + io-channel-names = "sys_therm0", > + "sys_therm1", > + "sys_therm2", > + "sys_therm3", > + "sys_therm4", > + "sys_therm5", > + "sys_therm6"; io-channels-names = "lpddr5x-therm", "charger-left-therm", "charger-right-therm", "ssd-therm", "keyboard-therm" > + }; > }; > > &i2c7 { > @@ -1025,6 +1050,64 @@ rtmr0_1p8_reg_en: rtmr0-1p8-reg-en-state { > }; > }; > > +&pmk8550_vadc { > + /* Around DRAM */ > + channel@14c { > + reg = ; > + qcom,hw-settle-time = <200>; > + qcom,ratiometric; > + label = "sys_therm0"; You might as well use the same name for the label "lpddr5-therm" > + }; On thena the list is: - "OPT temp" - "CPU VR" - "GPU VR" - "Charging-1" - "Charging-2" - "WLAN" - "WLAN (EE)" So I think both the source and the sink should describe and be allowed to describe what it is io-channel-names = "fixed list" is too restrictive. Much more useful to userspace to see a string "lpddr5-therm" than "sys_therm0". --- bod