From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E237399364 for ; Tue, 10 Mar 2026 14:12:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773151977; cv=none; b=UdsR/7c7wVPSQF57wK/6oQrR8c0FhbUd9IXo4Jbzq1A+lDZdmQAwx2rq85xoGE9t4DCnniQftgXFiZ5vl46MrV3W72+1PdZ7e+zLaxDoPN2FVh3IxLGhhbUsOEuWbK187C00iaT5r3lmlg8qpQ94AHaCsmcGnOmf3oCijKhcx0g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773151977; c=relaxed/simple; bh=1FaIPFuWAfmVNzG9+OtQXpdcIagmdohXDgobkOvWmaU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jJLajlcn4+r6V4NCGumVY5oukELWiQVpZ7tE2LtNMjhGH7O+gXifUzz2F+n0xtRy95bNwMzsradrBeMRVxadJKjOeRaUt2m6fEQt9r6KtvhnSjb+iJfBELz/Lw3Dh/1Z/IfYAG75AXAzeWE9l3q+qc6LEbfPL9JJF1jgFwSMr5o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=FahaEN7n; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PjXm/Q8/; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="FahaEN7n"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PjXm/Q8/" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62ACbDfc3297898 for ; Tue, 10 Mar 2026 14:12:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= OqvWktqC6//V6Esd6CgK+Uq4ljtYPh/ZuwNGITPaTMo=; b=FahaEN7ngFKMRFZl etdudgxLWcSyWAqy9SPb/9EueWGgIiP1tySGYqNLoG73WEYSNCX9qxDFE0uzf1OY neMDEFMDMw7UyQm+2eQlRek0cjCopGNhk0xLK62K8AslpiV49P4j9IMDXvSxnkLc 1NfTt6KQS+dd0R9BmE7ehywg/1m4uHTlheTe3Q5uYA9ETXFBtQ/uzMs4VBmeS/+l k8o4jGPEZixb0LHO4dgaX+bTGLIjxELLZ5olZ8a4ZOTygFYtB5ffBYc1lDzD7QtX PNDifgNrfuogc4stYiwZwsxcgpZeFdmbF+dEPguY7HYIDNuxEB/Uk0r7NDmUVcgO Y/pubw== Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ctg1ms7cj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 10 Mar 2026 14:12:55 +0000 (GMT) Received: by mail-ua1-f71.google.com with SMTP id a1e0cc1a2514c-94abae6fee7so1733998241.0 for ; Tue, 10 Mar 2026 07:12:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773151975; x=1773756775; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=OqvWktqC6//V6Esd6CgK+Uq4ljtYPh/ZuwNGITPaTMo=; b=PjXm/Q8/gIL4eKo6no6UhhN9rO7atQOHqmfIRUqV7AQUYUF/xlCpnCVKGRO9SI9AdZ UbXceXkx2UrNTymGpL5fIs0AyS1a6kl/WkpM06cJ0w/FD5ue9++VYXJJry6hd3391xfe qitoy8z0zrDWn95+eURVJcSd6g8WmfRIgk5Q8KlDXEIxAwUQE6rz6VaAhszYGlCDJ49K AsPDcvIh2e5Zm121CnbCcdqUK8+/aoFBGlZuOBficeFyS3M0+47ei4E9aojW6OpxRHrL UsUPDQ+0npX3fucwmILk8cdYuv49k8+rqvk8hd1+3MTaTrZ4i6WyShzpl7GWuLMItl/H +J8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773151975; x=1773756775; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OqvWktqC6//V6Esd6CgK+Uq4ljtYPh/ZuwNGITPaTMo=; b=nfynjncGQ6JfiWXce4h3bZA3pxrYnlgmjP9AgdvZYa7NPcv6zLRPLVW/vf6KNimvvj lryYe1aECci/+E/4kuZPIORTF41DS+u6tQ8sEHRw/1GEFlLpG8tfneDDqs/DufrhPlT+ oZnEX1lHiB26t5IzvkTENnjfrRdjl8JXd4Jaay/c3KUp9+rNcVfy+5QBzA1F0cE1Omel Kdpk36IG21YyRAryPDh5yE2KbG5pOrtByngw1lVBx2gTzJ/KjfzRV/iC8NwMZwpuT08/ FLUiuRevxre2B2wJKjqaB3lzvzHn2Yj5ZX+PN+bTkx8ZC1REEeLTwj1SAhZdAUkBe2wY Vc5w== X-Forwarded-Encrypted: i=1; AJvYcCUWIFXkII1KXsKOvXC0H+W7AQSkWTdEt+m0CjRJz8Xg3bTcS0B53ls5etYqBR0FhAHyUDqvfFoK6m+hZAk=@vger.kernel.org X-Gm-Message-State: AOJu0YyOkHqLy8oDj30lFFLVXLCWjZG5Ce3DXbL95KgQ8P5/ksBIMNug wmbnzKKoOY9cN5DD1Qa2c0wpZ00kW++O0AOKwFNX/4DhhEvyASEMSImRkUeh5KThbSj6jutMW8i BI65mcAHl5/NFahFzc9XdOCtW+lOUajMfsKaroajfQhpeIGCBvbUMGlWP4WvCzK6II1o= X-Gm-Gg: ATEYQzz6LaNwADHfkh3tknLSrKZi3R9Var2ebAQquIK4mo64zMu1Py426c3JcDfmm2h V+v1ywdeeyMnL0FSw78oFsz9PPIvxfpSUjbcH9wgw6uzPcO5gwxnGFtaOtD8sGTK/A5FIK37qr7 nAMJ4P0AW2XnepMB9YV+wa4Q8kVNT09AXBTRO/kY3Tvhje9KeAcklRJsYm4elAa7qp7nFFfmPr8 fsF+N0elsZtgECK4Or5g7ANA18mn/B/3m1ZaeqVs9w1vCKIx5cK6hHQkdAzMPFpWsSjtej/8ovL XoG72wh+22WVg2eIGV0s3BuDgTYsGTlun665fQ+ymYicFgqAohHoZ4SEUjRQAQtWi0LxfnyaQSQ fGCyNSI2MvuV9/K0CHXRLMtspeEnnKVEXC2i6gesyPLKv+OFtpoIaUp7r4cU23l9ihEbajo0FcV 7mFLc= X-Received: by 2002:a05:6102:d92:b0:5ff:c0e8:d89a with SMTP id ada2fe7eead31-5ffe5ba4013mr2497925137.0.1773151974616; Tue, 10 Mar 2026 07:12:54 -0700 (PDT) X-Received: by 2002:a05:6102:d92:b0:5ff:c0e8:d89a with SMTP id ada2fe7eead31-5ffe5ba4013mr2497898137.0.1773151973959; Tue, 10 Mar 2026 07:12:53 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-661a3c66d3fsm4317323a12.2.2026.03.10.07.12.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Mar 2026 07:12:52 -0700 (PDT) Message-ID: Date: Tue, 10 Mar 2026 15:12:48 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 06/11] arm64: dts: qcom: kodiak: Add power-domain and iface clk for ice node To: Harshal Dev , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , Yuvaraj Ranganathan , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski References: <20260310-qcom_ice_power_and_clk_vote-v2-0-b9c2a5471d9e@oss.qualcomm.com> <20260310-qcom_ice_power_and_clk_vote-v2-6-b9c2a5471d9e@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260310-qcom_ice_power_and_clk_vote-v2-6-b9c2a5471d9e@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=YOeSCBGx c=1 sm=1 tr=0 ts=69b026e7 cx=c_pps a=KB4UBwrhAZV1kjiGHFQexw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=z_dnvKGLtVwtNw_c-ccA:9 a=QEXdDO2ut3YA:10 a=zZCYzV9kfG8A:10 a=o1xkdb1NAhiiM49bd1HK:22 X-Proofpoint-ORIG-GUID: LxggPIfTgvYjU-xIuuQfsbY3rkverCbj X-Proofpoint-GUID: LxggPIfTgvYjU-xIuuQfsbY3rkverCbj X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEwMDEyNCBTYWx0ZWRfX6RVcegevMBgS dkrgsvST4l4uJrCOOsVTY0nnyxnwi7kGaql7CcwwEibG6LzGGup8L0QzF3Fu9mFVYOqBueBEoOG 4+dBJwJymTYBYLy82pwST/F57Sj4nmsrcjj8WTTEEj6ARGha8GknvlIEgN/xa8/sE98FUhhomYH Ol+T+/rX8Jkp/8vVXYuRTx6tehAhWM5qC4TM89mEXc2qNyLp3l4wkvXPMP26iyu2Tp1zFdr4Ixt mVEDyok2p41LbPJVh+5xyTcxaBZ5D3ivSnnmNwKzK2pPbFFcCEbwza3ZR/G/vkZwWmaNiXw2yti g2uuAh2ydVflT5Jyff8KZid7yhY2ewlm5xQaBL8keoYy/TYnOyKfrEy0WlFdGGWr5Vi4NaU1CPi gcLRlu/iPc13U/fK9/3FFFiul5EXhYBYdDuakHs8aKsm3j32M7G9j/TiJRnK9JCLDOGKL3BBiES v1LMFFM+0ujS7U32K8w== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-10_02,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1015 spamscore=0 bulkscore=0 suspectscore=0 priorityscore=1501 malwarescore=0 phishscore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603100124 On 3/10/26 9:06 AM, Harshal Dev wrote: > Qualcomm in-line crypto engine (ICE) platform driver specifies and votes > for its own resources. Before accessing ICE hardware during probe, to > avoid potential unclocked register access issues (when clk_ignore_unused > is not passed on the kernel command line), in addition to the 'core' clock > the 'iface' clock should also be turned on by the driver. This can only be > done if the GCC_UFS_PHY_GDSC power domain is enabled. Specify both the > GCC_UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for > kodiak. > > Fixes: dfd5ee7b34bb7 ("arm64: dts: qcom: sc7280: Add inline crypto engine") > Signed-off-by: Harshal Dev > --- Reviewed-by: Konrad Dybcio Konrad