From: Andrew Lunn <andrew@lunn.ch>
To: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Lukasz Majewski <lukma@denx.de>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux@ew.tq-group.com,
Michael Krummsdorf <michael.krummsdorf@tq-group.com>
Subject: Re: [PATCH] net: dsa: mv88e6xxx: fix usable ports on 88e6020
Date: Wed, 27 Mar 2024 13:44:47 +0100 [thread overview]
Message-ID: <b5abcd09-8dda-4a9a-b6b2-47c9a50faccf@lunn.ch> (raw)
In-Reply-To: <20240326123655.40666-1-matthias.schiffer@ew.tq-group.com>
On Tue, Mar 26, 2024 at 01:36:54PM +0100, Matthias Schiffer wrote:
> From: Michael Krummsdorf <michael.krummsdorf@tq-group.com>
>
> The switch has 4 ports with 2 internal PHYs, but ports are numbered up
> to 6, with ports 0, 1, 5 and 6 being usable.
>
> Fixes: 71d94a432a15 ("net: dsa: mv88e6xxx: add support for MV88E6020 switch")
> Signed-off-by: Michael Krummsdorf <michael.krummsdorf@tq-group.com>
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
> ---
>
> I was unfortunately too busy to notice the issue when the patch this
> Fixes was resubmitted in my name. It would have been better to change
> my From into a Based-on-patch-by or similar when modifying it - and the
> final version obviously wasn't even tested on an 88E6020...
>
> Best regards,
> Matthias
>
>
> drivers/net/dsa/mv88e6xxx/chip.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
> index 9ed1821184ece..c95787cb90867 100644
> --- a/drivers/net/dsa/mv88e6xxx/chip.c
> +++ b/drivers/net/dsa/mv88e6xxx/chip.c
> @@ -5503,8 +5503,12 @@ static const struct mv88e6xxx_info mv88e6xxx_table[] = {
> .family = MV88E6XXX_FAMILY_6250,
> .name = "Marvell 88E6020",
> .num_databases = 64,
> - .num_ports = 4,
> + /* Ports 2-4 are not routed to pins
> + * => usable ports 0, 1, 5, 6
> + */
> + .num_ports = 7,
> .num_internal_phys = 2,
> + .invalid_port_mask = BIT(2) | BIT(3) | BIT(4),
This patch does what the commit message suggests. So
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
It would however be nice to fully understand how it currently works
for the deployed use case, just to ensure we are not missing
something.
Andrew
next prev parent reply other threads:[~2024-03-27 12:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 12:36 Matthias Schiffer
2024-03-26 13:34 ` Lukasz Majewski
2024-03-26 14:00 ` Matthias Schiffer
2024-03-26 15:52 ` Lukasz Majewski
2024-03-27 9:42 ` Matthias Schiffer
2024-03-27 12:44 ` Andrew Lunn [this message]
2024-03-28 13:47 ` Simon Horman
2024-03-29 19:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5abcd09-8dda-4a9a-b6b2-47c9a50faccf@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@ew.tq-group.com \
--cc=lukma@denx.de \
--cc=matthias.schiffer@ew.tq-group.com \
--cc=michael.krummsdorf@tq-group.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®