From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C16AFC83F3F for ; Mon, 4 Sep 2023 16:02:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353259AbjIDQCa (ORCPT ); Mon, 4 Sep 2023 12:02:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230430AbjIDQC3 (ORCPT ); Mon, 4 Sep 2023 12:02:29 -0400 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C00FCD7 for ; Mon, 4 Sep 2023 09:02:25 -0700 (PDT) Received: by mail-lj1-x22c.google.com with SMTP id 38308e7fff4ca-2b962535808so24393571fa.0 for ; Mon, 04 Sep 2023 09:02:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693843343; x=1694448143; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zM3ET3bm2MbxGsAbrqdg/qprAQrKGyxNE7Tfou0mlV4=; b=FswPU9tKOiaRRaTRSyqWWYALPv6LBD4XUjVGZC6go3XUFCqNkXv5CqLjMZjwQ5LqGe T0s77zTLYGqOZYH7wovzV+kfTTVOHaG4w3TBcUomI7G7p9z9UY8DHrvrqXog35HT4roM 604jYeeatGfXQ6F4n50XjLXnf7vQpjGeQzinSLTpOQWTtcfPlkJSl6QkY064FIv3ZfMA O1qRpHKxLuZGJAa5Gtfkb/l1NEf9+7UUswkX/gCxrUTuHsr66O8KRqGWCN/uBHuy0hnQ KvygWLYtAkFOex6YNU2GtdMqMvtTz7ly/qJ4ZscZcttQrPcwigmW6YshcnN6jQh5dv+6 InGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693843343; x=1694448143; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zM3ET3bm2MbxGsAbrqdg/qprAQrKGyxNE7Tfou0mlV4=; b=BhrG2Kr0a5OrwTN2brpKRSa2E6zAu6lmah/x3ESf/QwxBMEk+YqV8SVot0uIbmktUV wze1FdR+0xbZCFRAw9k0gBwmiCcDUYtaq/FWDNzT/pvXIPymiXt/N+rxdieqYPKPplb7 7CxBserUQhH7oMtH9rHg4RgE6ewvh/cbPeZW2CCW10zlCZ6Adz4SQZV7ofZvb+ZiU00C 0/eWe5svJFefiHSDboQZWQcaOZrjbA5lL7lyGrv4AYfSWUFkJBEyQ9Wr0erlh1jY3VZs bqv9A96ehpir6EsmC32+doRJzJlr112gIVa/UJM/XgICTEBmYyg3sBXcIHg/DeiBdqi3 i/sA== X-Gm-Message-State: AOJu0YwTHwctvYAjS1jMDEa2fQ6SLT3DDbb8CeW5wOY9VqAdCWPUl7KY JnNsoElBo1ebgF3NBrt1Jirs2w== X-Google-Smtp-Source: AGHT+IHiB69w0yi0rVaLin56mgZNQm67pzg8h8iP2iC0Wu4b+jj3V+Ufqgpquoa/8Zr2zn3/XOerMA== X-Received: by 2002:a2e:9788:0:b0:2bc:e51e:b007 with SMTP id y8-20020a2e9788000000b002bce51eb007mr7402219lji.41.1693843343542; Mon, 04 Sep 2023 09:02:23 -0700 (PDT) Received: from [192.168.1.101] (abxj43.neoplus.adsl.tpnet.pl. [83.9.3.43]) by smtp.gmail.com with ESMTPSA id a16-20020a2e9810000000b002bb99f6f2c7sm2223735ljj.90.2023.09.04.09.02.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Sep 2023 09:02:23 -0700 (PDT) Message-ID: Date: Mon, 4 Sep 2023 18:02:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/6] clk: qcom: Use HW_CTRL_TRIGGER flag to switch video GDSC to HW mode Content-Language: en-US To: Jagadeesh Kona , Abel Vesa Cc: "Rafael J . Wysocki" , Kevin Hilman , Ulf Hansson , Pavel Machek , Len Brown , Greg Kroah-Hartman , Bjorn Andersson , Andy Gross , Mike Turquette , Stephen Boyd , Taniya Das , linux-pm@vger.kernel.org, Linux Kernel Mailing List , linux-arm-msm@vger.kernel.org, Ajit Pandey , Imran Shaik References: <20230816145741.1472721-1-abel.vesa@linaro.org> <20230816145741.1472721-5-abel.vesa@linaro.org> <2fc0d771-cee2-4826-a62a-56ed4bfad3a2@linaro.org> <07e93a9d-69ac-41b7-aa21-b855b97bf801@linaro.org> <8257f7b3-dfb8-4683-85de-600f3b1ed54b@linaro.org> From: Konrad Dybcio Autocrypt: addr=konrad.dybcio@linaro.org; keydata= xsFNBF9ALYUBEADWAhxdTBWrwAgDQQzc1O/bJ5O7b6cXYxwbBd9xKP7MICh5YA0DcCjJSOum BB/OmIWU6X+LZW6P88ZmHe+KeyABLMP5s1tJNK1j4ntT7mECcWZDzafPWF4F6m4WJOG27kTJ HGWdmtO+RvadOVi6CoUDqALsmfS3MUG5Pj2Ne9+0jRg4hEnB92AyF9rW2G3qisFcwPgvatt7 TXD5E38mLyOPOUyXNj9XpDbt1hNwKQfiidmPh5e7VNAWRnW1iCMMoKqzM1Anzq7e5Afyeifz zRcQPLaqrPjnKqZGL2BKQSZDh6NkI5ZLRhhHQf61fkWcUpTp1oDC6jWVfT7hwRVIQLrrNj9G MpPzrlN4YuAqKeIer1FMt8cq64ifgTzxHzXsMcUdclzq2LTk2RXaPl6Jg/IXWqUClJHbamSk t1bfif3SnmhA6TiNvEpDKPiT3IDs42THU6ygslrBxyROQPWLI9IL1y8S6RtEh8H+NZQWZNzm UQ3imZirlPjxZtvz1BtnnBWS06e7x/UEAguj7VHCuymVgpl2Za17d1jj81YN5Rp5L9GXxkV1 aUEwONM3eCI3qcYm5JNc5X+JthZOWsbIPSC1Rhxz3JmWIwP1udr5E3oNRe9u2LIEq+wH/toH kpPDhTeMkvt4KfE5m5ercid9+ZXAqoaYLUL4HCEw+HW0DXcKDwARAQABzShLb25yYWQgRHli Y2lvIDxrb25yYWQuZHliY2lvQGxpbmFyby5vcmc+wsGOBBMBCAA4FiEEU24if9oCL2zdAAQV R4cBcg5dfFgFAmQ5bqwCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQR4cBcg5dfFjO BQ//YQV6fkbqQCceYebGg6TiisWCy8LG77zV7DB0VMIWJv7Km7Sz0QQrHQVzhEr3trNenZrf yy+o2tQOF2biICzbLM8oyQPY8B///KJTWI2khoB8IJSJq3kNG68NjPg2vkP6CMltC/X3ohAo xL2UgwN5vj74QnlNneOjc0vGbtA7zURNhTz5P/YuTudCqcAbxJkbqZM4WymjQhe0XgwHLkiH 5LHSZ31MRKp/+4Kqs4DTXMctc7vFhtUdmatAExDKw8oEz5NbskKbW+qHjW1XUcUIrxRr667V GWH6MkVceT9ZBrtLoSzMLYaQXvi3sSAup0qiJiBYszc/VOu3RbIpNLRcXN3KYuxdQAptacTE mA+5+4Y4DfC3rUSun+hWLDeac9z9jjHm5rE998OqZnOU9aztbd6zQG5VL6EKgsVXAZD4D3RP x1NaAjdA3MD06eyvbOWiA5NSzIcC8UIQvgx09xm7dThCuQYJR4Yxjd+9JPJHI6apzNZpDGvQ BBZzvwxV6L1CojUEpnilmMG1ZOTstktWpNzw3G2Gis0XihDUef0MWVsQYJAl0wfiv/0By+XK mm2zRR+l/dnzxnlbgJ5pO0imC2w0TVxLkAp0eo0LHw619finad2u6UPQAkZ4oj++iIGrJkt5 Lkn2XgB+IW8ESflz6nDY3b5KQRF8Z6XLP0+IEdLOOARkOW7yEgorBgEEAZdVAQUBAQdAwmUx xrbSCx2ksDxz7rFFGX1KmTkdRtcgC6F3NfuNYkYDAQgHwsF2BBgBCAAgFiEEU24if9oCL2zd AAQVR4cBcg5dfFgFAmQ5bvICGwwACgkQR4cBcg5dfFju1Q//Xta1ShwL0MLSC1KL1lXGXeRM 8arzfyiB5wJ9tb9U/nZvhhdfilEDLe0jKJY0RJErbdRHsalwQCrtq/1ewQpMpsRxXzAjgfRN jc4tgxRWmI+aVTzSRpywNahzZBT695hMz81cVZJoZzaV0KaMTlSnBkrviPz1nIGHYCHJxF9r cIu0GSIyUjZ/7xslxdvjpLth16H27JCWDzDqIQMtg61063gNyEyWgt1qRSaK14JIH/DoYRfn jfFQSC8bffFjat7BQGFz4ZpRavkMUFuDirn5Tf28oc5ebe2cIHp4/kajTx/7JOxWZ80U70mA cBgEeYSrYYnX+UJsSxpzLc/0sT1eRJDEhI4XIQM4ClIzpsCIN5HnVF76UQXh3a9zpwh3dk8i bhN/URmCOTH+LHNJYN/MxY8wuukq877DWB7k86pBs5IDLAXmW8v3gIDWyIcgYqb2v8QO2Mqx YMqL7UZxVLul4/JbllsQB8F/fNI8AfttmAQL9cwo6C8yDTXKdho920W4WUR9k8NT/OBqWSyk bGqMHex48FVZhexNPYOd58EY9/7mL5u0sJmo+jTeb4JBgIbFPJCFyng4HwbniWgQJZ1WqaUC nas9J77uICis2WH7N8Bs9jy0wQYezNzqS+FxoNXmDQg2jetX8en4bO2Di7Pmx0jXA4TOb9TM izWDgYvmBE8= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4.09.2023 11:27, Jagadeesh Kona wrote: > > > On 9/2/2023 5:33 PM, Konrad Dybcio wrote: >> On 28.08.2023 08:48, Jagadeesh Kona wrote: >>> >>> >>> On 8/26/2023 4:17 PM, Konrad Dybcio wrote: >>>> On 23.08.2023 12:41, Abel Vesa wrote: >>>>> On 23-08-16 19:56:46, Konrad Dybcio wrote: >>>>>> On 16.08.2023 16:57, Abel Vesa wrote: >>>>>>> From: Jagadeesh Kona >>>>>>> >>>>>>> The current HW_CTRL flag switches the video GDSC to HW control mode as >>>>>>> part of GDSC enable itself, instead of that use HW_CTRL_TRIGGER flag to >>>>>>> give consumer drivers more control and switch the GDSC mode as and when >>>>>>> required. >>>>>>> >>>>>>> HW_CTRL_TRIGGER flag allows consumer drivers to switch the video GDSC to >>>>>>> HW/SW control modes at runtime using dev_pm_genpd_set_hwmode API. >>>>>>> >>>>>>> Signed-off-by: Jagadeesh Kona >>>>>>> Signed-off-by: Abel Vesa >>>>>>> --- >>>>>> Do we have any use for the HW_CTRL flag? >>>>>> >>>>>> Perhaps it should be renamed to HW_CTRL_ALWAYS? >>>>>> >>>>>> Or even better, *if and only if* that is necessary, add a common >>>>>> property like "always_hw_managed" to the genpd code? >>>>> >>>>> The HW_CTRL flag is still needed for the consumers that expect the GDSC >>>>> to be have the HW control bit set right after it gets enabled. >>>> Guess the correct question here would be.. Are there any? >>>> >>> >>> Yes, Display GDSC(mdss_gdsc) is required to be controlled always in HW control mode when it is enabled. >> Oh really? >> >> Looking at msm-5.10 techpack, only the SDE RSC driver seems to >> trigger regulator fast mode (so, enabling gdsc hw_ctrl on downstream). >> > > Yes, on downstream, display GDSC has only one consumer(SDE RSC driver) and there are no other consumers. SDE RSC driver switches the GDSC to hw control mode once GDSC is enabled and leaves it in hw control mode. Thanks! Sorry for pulling your tongue here a bit, but would it only concern RPMh SoCs? Designs like SM6115 don't implement RSCs, should they not have HW_CTRL enabled at all times? Konrad