From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D71BB3BC680 for ; Tue, 24 Mar 2026 13:04:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774357475; cv=none; b=sXZ6cHlQQSejjGX0AEEaNvoDvw8Yw64XR2euVMJRxz/SvxNLlguZM3R0RMPAaRcmWgwjG7obKiJ18wWM3K4oX9cg1XGQpZGg1ywNZ2uo0VRCquFBgAeAjBdJ35L17jdqLxdbs9z8NrcHuLZFrpFpl0BbGUjIHMjnl6BR+X7eb6o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774357475; c=relaxed/simple; bh=lkj4K5KneEaXfI/hABfu7CsdmDXqGAITS+gNHz4+WSE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pfsUipkhjvxPfeILMOHjE7E5XeBgzpLYRsmNqysmJcWR5ugpquZQt55ehZXiLvHfQf21C3B1PZLKsroAXrgizoRKCH4RmOj/hHSbziLxStB4FHj5P47VNaj068qn9lOBwPmFO+eDFolO5V8p9ZBEV9/af30ATLRpfBBKDYrzs2Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PzzQ/VjJ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YoUy6k5w; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PzzQ/VjJ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YoUy6k5w" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62OC54Yf409088 for ; Tue, 24 Mar 2026 13:04:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Ih9VTv83QqyTp0YZh+OZkzFBW3xGR+7UkInLLJl+QN0=; b=PzzQ/VjJI+CsrFld sCQVJ2z0SrwnyWtz63sC1Gq0UQR3aIxbQsS16N5N95Ib2FQyvf6togKuGckPxVHN PPBGvN0WhYsJDUuTCKk8tnmdhDycrwN0FFnAYW0BvcsHzcGP1KcT1+qJg3Q5+KDM eWwAZBC9N5og5MZbp/1L9tR7qnwPsEHGsTwaPXCeSFutdoNLReIm9oLYaUuWnR0T W5N4VlJlynGkV5w2gaNgg3btE2UvX/l51wYKM+Ht9+iOBVco5ok+QJMTQ45XodOf oZgXPEHUfwXc2U5PCv17f0WPSmokIVySI4XPDZEDtVv1xN+2UIvkDk6fC62kMxDG 6n6iwA== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d3nexsekq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 24 Mar 2026 13:04:33 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2b079b4a8c3so42892285ad.3 for ; Tue, 24 Mar 2026 06:04:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774357472; x=1774962272; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Ih9VTv83QqyTp0YZh+OZkzFBW3xGR+7UkInLLJl+QN0=; b=YoUy6k5whkjK+ZhxrH1XLhtCSJ4v0NNaR8+1iR3uQ5F32br5HrK4eAczKX7P+FGG+J SapH6uHidtcfETkR5eSP9h7Fa1VkWe7+Xl5BPW4P6x4mxKAQDWPu//38/PXsocTkJU30 v2E86VIUq9naeY4yL8Df6kUF3MnxIaNeFItuP13Kd2EJoOsqMURV3vxewmoHAHQ1ccNu 1tvTBdOna/TImzuBQ/vfNBThWAoSBA4RuSlhEdmOa64SPlbUQ56P9jTxUwbr4XTHEM/N WjZg1hGj+igStqNWALFxWQ6Fv6rBDpHWiPQMss5uFudVhxhfElTKnrUUPZHgD4fox2rF YP/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774357472; x=1774962272; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Ih9VTv83QqyTp0YZh+OZkzFBW3xGR+7UkInLLJl+QN0=; b=Pvd1pXWAontgl94ltoi/SY5N9jiyKYh2tAsw2+VEzuj2adWYTQnJxf9g7/0mnkTf4P JANWndUXRTZDH4dAdI8eHaJG38jiGdq6bCkc4WLclErP5ZYd99ohxQpKoH3+wQ4gTJIo YB582pOnaDrcbsFX85Bq7VLnIY8t5+ibU9a+sTHvc5qD72q1VHAgIZ+bfBpcm3Ab2aBV 2a/uhuvNPhHrPHh3V4QLT9Z5OMjS5SbajNiFIZs6rTmGzXVgaUXhygvfbhcp7xwo4aHD IzsTrGOcHj84X+/0RDgEWdVmBTM0cRduQGUFdMrj22GjEPuq9MZATge5PgfjCdj3eJD0 t05Q== X-Forwarded-Encrypted: i=1; AJvYcCX0wmGaT5ahsXiIF+v0mAHcPcGfEYyCCCQrmUtAvYpDiEazU3Jr6aiiK/t13j3PdStQnLERCJUsvpgO3J0=@vger.kernel.org X-Gm-Message-State: AOJu0YxIe2wKWd4IyTfABHoc4lXOs93vCZhUX37LQ97bpWXQ1hkxFmJM /9E7gqjF+bn/ghx3tiGZ4jf7Zn/oKU2rEvGOrgm1A02ExotCBRZZx5ocRHL9UlZNm32sbqUkwbN r8z3CVtiTrhG61xztYuLZ1HNqVp+VFtu/7+syG37wO6AS1pVBpfYxQnx0uQn8fgyoWuGFM0KYyW o= X-Gm-Gg: ATEYQzxWEKLTa1Lih5enrkleJ6jmx5pv+KLZU63iM6NU+n/4N1YvzTvSq+HM8TnsKCl mPK47YIDDZVfawhGSoleTi0pf/DKIgg4iXYVueFFgxJ/1b0ElJR4UNoVgxe/kCuJ9u8q5GaWRtG QVBxPUhdBQkWirzULjhv7rmbSLNJhZl2Es78mLK8GCs0njSqOs7xNeL1+anjBYylWWFV6tUeAEJ GWOMmzyqpVOpYKIoUkxdCzBF1cdT9m4zGYfv+2G8bw+ORHHBpI6Wbj1jklaKiSW/i0pTU+O9Zi3 End5aEzeezyDeWmjZ5EWGdL2efVVJlirlyPc9i4RjDTi18voyfMdySn3C+QQwSC/xI95Z8oZyM6 vyJI82Srm6ubk9YsAS4baoG5jYqMfSdKN3pOfvtsBpMy9TdsuMCvjLYjOBW0GUTzfDWRMMRb8f3 nQdhLxpSTOrim5Cm/sIw== X-Received: by 2002:a17:903:2284:b0:2ae:ced7:4650 with SMTP id d9443c01a7336-2b082797411mr162229275ad.24.1774357472035; Tue, 24 Mar 2026 06:04:32 -0700 (PDT) X-Received: by 2002:a17:903:2284:b0:2ae:ced7:4650 with SMTP id d9443c01a7336-2b082797411mr162228805ad.24.1774357471373; Tue, 24 Mar 2026 06:04:31 -0700 (PDT) Received: from [10.133.33.127] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b0835298acsm151917955ad.22.2026.03.24.06.04.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Mar 2026 06:04:30 -0700 (PDT) Message-ID: Date: Tue, 24 Mar 2026 21:04:24 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 31/38] drm/msm/dp: add HPD callback for dp MST To: Dmitry Baryshkov Cc: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Abhinav Kumar References: <20250825-msm-dp-mst-v3-0-01faacfcdedd@oss.qualcomm.com> <20250825-msm-dp-mst-v3-31-01faacfcdedd@oss.qualcomm.com> Content-Language: en-US From: Yongxing Mou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI0MDEwMyBTYWx0ZWRfX+7uDlimbEKPO jqUAw/CmYxz7USkMq0gvnFmTYOh8aAP4v2m/5XAD36b+6tu6T7pS5XSYOTw98xHus9uKCtGypkE HJTHBtOr1Sf4WLM3jQuKNwzD1OdqKdYrIgu7pmBHxn5MOc4HrMqBX6s9rheqgIi5Nele0cnhHHW YU/y+7FOFLgg2R/ERsQ09K6XWFPard3n9Une/bokfXRN3s1QwXq1ncqiAqUcPF+8Fdymui4sI6E WCOp8y4klW2L+SVcC+aNW6ysSNR3HHbK0tZy5SljY9XMSG8Eh7fXdxL7tNA+z4ix5lTXCZ5uBl5 PMx6oSxLSgqRSkakDecdvma2JjzL44vHE7n2/ipg5CmUHDyts9Jb5K80MdBwZP/JIZ8FYK3uHA2 xpjQfXLr+/mPGEm7kT1KlCJMsDpqOynx+shxSubjjwG75n2t5VX/9zLLXtydD4WFLp/FeRZK0uX mV/c2l+lVXg54QYhvIw== X-Proofpoint-GUID: jf57zFLNdz0pjDojirS7xRPSPx7Gfx4y X-Proofpoint-ORIG-GUID: jf57zFLNdz0pjDojirS7xRPSPx7Gfx4y X-Authority-Analysis: v=2.4 cv=Bd/VE7t2 c=1 sm=1 tr=0 ts=69c28be1 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=wlarEYM4F4ymYTEdJbgA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-24_03,2026-03-23_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 impostorscore=0 clxscore=1015 malwarescore=0 bulkscore=0 phishscore=0 suspectscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603240103 On 8/27/2025 2:40 AM, Dmitry Baryshkov wrote: > On Mon, Aug 25, 2025 at 10:16:17PM +0800, Yongxing Mou wrote: >> From: Abhinav Kumar >> >> Add HPD callback for the MST module which shall be invoked from the >> dp_display's HPD handler to perform MST specific operations in case >> of HPD. In MST case, route the HPD messages to MST module. >> >> Signed-off-by: Abhinav Kumar >> Signed-off-by: Yongxing Mou >> --- >> drivers/gpu/drm/msm/dp/dp_display.c | 15 ++++++++++++--- >> drivers/gpu/drm/msm/dp/dp_mst_drm.c | 34 ++++++++++++++++++++++++++++++++++ >> drivers/gpu/drm/msm/dp/dp_mst_drm.h | 2 ++ >> 3 files changed, 48 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c >> index abcab3ed43b6da5ef898355cf9b7561cd9fe0404..59720e1ad4b1193e33a4fc6aad0c401eaf9cbec8 100644 >> --- a/drivers/gpu/drm/msm/dp/dp_display.c >> +++ b/drivers/gpu/drm/msm/dp/dp_display.c >> @@ -500,9 +500,16 @@ static int msm_dp_display_handle_irq_hpd(struct msm_dp_display_private *dp) >> >> static int msm_dp_display_usbpd_attention_cb(struct device *dev) >> { >> - int rc = 0; >> - u32 sink_request; >> struct msm_dp_display_private *dp = dev_get_dp_display_private(dev); >> + struct msm_dp *msm_dp_display = &dp->msm_dp_display; >> + u32 sink_request; >> + int rc = 0; >> + >> + if (msm_dp_display->mst_active) { >> + if (msm_dp_aux_is_link_connected(dp->aux) != ISR_DISCONNECTED) >> + msm_dp_mst_display_hpd_irq(&dp->msm_dp_display); >> + return 0; >> + } >> >> /* check for any test request issued by sink */ >> rc = msm_dp_link_process_request(dp->link); >> @@ -1129,8 +1136,10 @@ static irqreturn_t msm_dp_display_irq_thread(int irq, void *dev_id) >> if (hpd_isr_status & DP_DP_HPD_UNPLUG_INT_MASK) >> msm_dp_display_send_hpd_notification(dp, false); >> >> - if (hpd_isr_status & DP_DP_IRQ_HPD_INT_MASK) >> + if (hpd_isr_status & DP_DP_IRQ_HPD_INT_MASK) { >> msm_dp_display_send_hpd_notification(dp, true); >> + msm_dp_irq_hpd_handle(dp, 0); > > Why is it a part of this patch?? It has nothing to do with MST. > Emm ... maybe here we can directly call msm_dp_mst_display_hpd_irq.. I tried an alternative approach by calling the MST IRQ handler from msm_dp_bridge_hpd_notify(). I expected that when hpd_isr_status == DP_DP_IRQ_HPD_INT_MASK, the hpd_link_status read in msm_dp_bridge_hpd_notify() would be ISR_IRQ_HPD_PULSE_COUNT. That way, we could handle both SST and MST interrupt paths in msm_dp_irq_hpd_handle(). However, hpd_link_status only reports ISR_CONNECTED. So I had to move the MST IRQ handling into the IRQ thread. Do you have any suggestions on this? >> + } >> >> ret = IRQ_HANDLED; >> >> diff --git a/drivers/gpu/drm/msm/dp/dp_mst_drm.c b/drivers/gpu/drm/msm/dp/dp_mst_drm.c >> index b4f640134af544c77ab262d2cbe0b67e1e2e1b3a..331d08854049d9c74d49aa231f3507539986099e 100644 >> --- a/drivers/gpu/drm/msm/dp/dp_mst_drm.c >> +++ b/drivers/gpu/drm/msm/dp/dp_mst_drm.c >> @@ -567,6 +567,40 @@ static struct msm_dp_mst_bridge_state *msm_dp_mst_br_priv_state(struct drm_atomi >> return to_msm_dp_mst_bridge_state_priv(obj_state); >> } >> >> +/* DP MST HPD IRQ callback */ >> +void msm_dp_mst_display_hpd_irq(struct msm_dp *dp_display) >> +{ >> + int rc; >> + struct msm_dp_mst *mst = dp_display->msm_dp_mst; >> + u8 ack[8] = {}; >> + u8 esi[4]; >> + unsigned int esi_res = DP_SINK_COUNT_ESI + 1; >> + bool handled; >> + >> + rc = drm_dp_dpcd_read(mst->dp_aux, DP_SINK_COUNT_ESI, >> + esi, 4); >> + if (rc != 4) { >> + DRM_ERROR("dpcd sink status read failed, rlen=%d\n", rc); > > It's DPCD, not dpcd. > Will fix it. >> + return; >> + } >> + >> + drm_dbg_dp(dp_display->drm_dev, "mst irq: esi1[0x%x] esi2[0x%x] esi3[%x]\n", >> + esi[1], esi[2], esi[3]); >> + >> + rc = drm_dp_mst_hpd_irq_handle_event(&mst->mst_mgr, esi, ack, &handled); >> + >> + /* ack the request */ >> + if (handled) { >> + rc = drm_dp_dpcd_writeb(mst->dp_aux, esi_res, ack[1]); >> + >> + if (rc != 1) > > No empty space, drm_dp_dpcd_write_byte(). > Got it. >> + DRM_ERROR("dpcd esi_res failed. rc=%d\n", rc); >> + >> + drm_dp_mst_hpd_irq_send_new_request(&mst->mst_mgr); >> + } >> + drm_dbg_dp(dp_display->drm_dev, "mst display hpd_irq handled:%d rc:%d\n", handled, rc); >> +} >> + >> /* DP MST Connector OPs */ >> static int >> msm_dp_mst_connector_detect(struct drm_connector *connector, >> diff --git a/drivers/gpu/drm/msm/dp/dp_mst_drm.h b/drivers/gpu/drm/msm/dp/dp_mst_drm.h >> index 1484fabd92ad0075eac5369aac8ca462acbd3eda..5e1b4db8aea4506b0e1cc1cc68980dd617d3f72a 100644 >> --- a/drivers/gpu/drm/msm/dp/dp_mst_drm.h >> +++ b/drivers/gpu/drm/msm/dp/dp_mst_drm.h >> @@ -86,4 +86,6 @@ int msm_dp_mst_drm_bridge_init(struct msm_dp *dp, struct drm_encoder *encoder); >> >> int msm_dp_mst_init(struct msm_dp *dp_display, u32 max_streams, struct drm_dp_aux *drm_aux); >> >> +void msm_dp_mst_display_hpd_irq(struct msm_dp *dp_display); >> + >> #endif /* _DP_MST_DRM_H_ */ >> >> -- >> 2.34.1 >> >