From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6A2530566A for ; Mon, 6 Jul 2026 13:04:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783343072; cv=none; b=frqgowEti/bZt0uXAAjCut6zKtpwGIfccAD5XraK9Lz0+aBtEgW6ZcyetBE5woc5hbRzRWg15pzUU35OHPHIMcozPY5W0OFKtrA++OZ3/hp0vRivlP2xoAjIvHxwd1k7u6PSAyDA1LT48yt49UooM7s+MSAC8DVgDL9M8t3AtB0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783343072; c=relaxed/simple; bh=9/7QPfKMTMI/CjWRhumszI3/aGbVFOoiMgVoaf9cHw8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XzEUCdFdhTR88b0o38JQ6scoEs6fm80Q8yHU9qRuHoSHz9AD5e/YVHk7O0NSEDJjJcvvzVSIHRwTHYTSVArW4nw+Xhw2zXLXZjt23Dk51/Pa8RH9CY2gYMxDitbBF/k1miTXh47Ux8LCcnlK6whHXcc3IfKNsp9njsYJ+7lIwvU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JapYqo/b; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=LgW7ilQK; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JapYqo/b"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LgW7ilQK" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 666AxBML361240 for ; Mon, 6 Jul 2026 13:04:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= pWsnU3ydAXBOIOITNJSSKAM8BpjQAyuQui8bRCBB0A8=; b=JapYqo/b3DOlXT5l YMkVOG5SkD+soPzoW2SxJcmivNrwV0JagYLz/i1Yzga4SuyiMddZ9BOzp9AY3VUC ZB+ETwaWTBYE6NkT8O6hB3MrGqkwoUBLOLV3OCVJvHIMk1sMG7WbYFJk4EiEDVMK A6oAebTAZ9ge/1H5uZTGMSAVfn5v1ItcScKJByUgdfAfZ5qsG6M0NjQbef4hLPlT JRh/wZ1lUSLTwa19my23fMtBUNR9r/eJrT7V+Q8J63mMlQIPc6TtTOmCh/ovCzRu 21f9oUxvn8bpiG4mzCmDG9+Wf1njfa2eNPEuWfVhcHV8EBH/M/igw9ujOvGR0pl7 y9GzUA== Received: from mail-ot1-f69.google.com (mail-ot1-f69.google.com [209.85.210.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f88h51554-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 13:04:29 +0000 (GMT) Received: by mail-ot1-f69.google.com with SMTP id 46e09a7af769-7eb4f51ba95so141062a34.3 for ; Mon, 06 Jul 2026 06:04:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783343069; x=1783947869; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=pWsnU3ydAXBOIOITNJSSKAM8BpjQAyuQui8bRCBB0A8=; b=LgW7ilQKS16zt1HFya455QK74TAwcan4xMWabuRn9WD1QPU2FPNSUqNL0lipoQp25a /jMCBFQViyR4PoBnwZZMQKYsAoUV2q4LNYweQ8bgCYS5iTIEKF08+69V/pc6XhdE6Lry 5sy9VcDsDicxPcXqhY/rDKPPPt0VlBDZPDFPqvbnDB7k0sLZ1niWVZ5BmSvjuBZIEsmq PDTZUZGtxH7aLZ5pBdOddJgHqN254HsRb/woVp9diBV3TVOM5uq1SJ4qHGgfOLRClOUL pnlTGgrinY2/4GHgVsB49Fx4Sf/WJBpkoJbwmV0goYos7vJMf8EefuEaPergLFw7Sm7/ 2z6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783343069; x=1783947869; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=pWsnU3ydAXBOIOITNJSSKAM8BpjQAyuQui8bRCBB0A8=; b=cu+3FueEZAIgXDm5VDYyMjUntVy7uCTi9pVyYtQl64n9iFJmdv0CjR5f2vXgAknz00 kk0y3isSqd4tqv9qx2+wJbFIJPNpgb3aLeaH0C2d1PVbf+PsMEjZoU1gLnijFB5Vb9lE ie3X9j37noW4/V691j/e4UbTzv162ONfPm2SDt1w0WnMotNKA8zP3krgVDYwN1gc6inv gR8s1b+vCIfMu+kioHoCH+0MVLSBxEcG+XgaOMqjlcFqzjMTaZ7ZhoyyhpNv5YP/Wz1I yMDi+RBzGZvnaOhZ64jOukSseRyXvl4ysWPchr/bj9ZwgHMwjaA/sH6AaYvgMZ8HlBi6 Hkmw== X-Forwarded-Encrypted: i=1; AFNElJ8148m8TjAuC9CBNzer/lA7jB7MsMEXL3JgUSjyVevYWyaOkPMD9RUAkNxU0mbf3+VSUED+bJMwo7U5ZfA=@vger.kernel.org X-Gm-Message-State: AOJu0YzrWMCpm90egd2UzLY0o6ugrDJzMlfzKPytmdQFQUq3GRy+38Ob 0dyxN6tuSYQa2ICln6BCubrTG5GBA7hv7dnlAavO1gUN/yjsdtE+34kAcd1MKVlDpuMQGdwELSn mSrR/OB8Cxz5w5tr72RJNb2kLuD6l0604wbodGyPUi0FP8kdnOnTBYsZOPMxdak12bIM= X-Gm-Gg: AfdE7cmero3WEquXoerRoX0dIIyvDvtrbdl+ApZBEgnJhpkFX+NCu5hz0EsGEsK7b7z lMTwwAo6iI1j8dKFOM3geZELmWxratH7iaPu2y+mtnPvVkVYHEKPGLdWxmQN9kofA0CyExM5+kw MsinQGgQSsuL0B8C66poxA7sPAtcqFHQzBkt0JVBonNkxKKZemDQmDsVk8g6DAvx3IOnlvo7TWx yOlElVFCWCgEbCYEyDGcLdm/xTuQtHdmFcgjANS5Qci1TXHdnpL64jwXLJXheqdqRJdj+jT2eiS I7UUMWLY9KaVV3ZcLYeWq08S8/0iDOJ/Ymb9D1+jmD8+ARA6eNVjQTJOq/sidDyVvqhXhpSFoep K1rWrwsZ+a3Wks613q34A6WPiYyWaWvefHhY= X-Received: by 2002:a05:6830:348d:b0:7e9:e1ca:5316 with SMTP id 46e09a7af769-7eb7f1933cfmr4339234a34.0.1783343067632; Mon, 06 Jul 2026 06:04:27 -0700 (PDT) X-Received: by 2002:a05:6830:348d:b0:7e9:e1ca:5316 with SMTP id 46e09a7af769-7eb7f1933cfmr4339199a34.0.1783343067095; Mon, 06 Jul 2026 06:04:27 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-69a19dbef44sm4216078a12.31.2026.07.06.06.04.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Jul 2026 06:04:26 -0700 (PDT) Message-ID: Date: Mon, 6 Jul 2026 15:04:22 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] spi: qcom-geni: Fix missing error check on pm_runtime_get_sync() To: Praveen Talari , Mark Brown , Dilip Kota , Stephen Boyd , Girish Mahadevan , Alok Chauhan , bjorn.andersson@oss.qualcomm.com, "Rafael J. Wysocki" , Len Brown , Pavel Machek , Greg Kroah-Hartman , Danilo Krummrich , Douglas Anderson Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Mukesh Kumar Savaliya , aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, jyothi.seerapu@oss.qualcomm.com, linux-pm@vger.kernel.org, driver-core@lists.linux.dev References: <20260706-fix_sticky_-einval_after_pm_runtime_api_failure-v3-0-92feb5a7b926@oss.qualcomm.com> <20260706-fix_sticky_-einval_after_pm_runtime_api_failure-v3-2-92feb5a7b926@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260706-fix_sticky_-einval_after_pm_runtime_api_failure-v3-2-92feb5a7b926@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: _uorvJNmqUbBTIdcm0Lrs94ev-SGiQRr X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDEzMyBTYWx0ZWRfX5qhbZoD0WKp+ YUx4nmk/Qg7HsN6fTSUE6HKlD7o9DIHGcouQYR7VdDf7ApYVa0Kmy9wo7iBqZzjH47+hLUKfoEX rtj/CkIs0Psw0r40FKWAfJtWU2Im6Ew= X-Authority-Analysis: v=2.4 cv=EPU2FVZC c=1 sm=1 tr=0 ts=6a4ba7dd cx=c_pps a=z9lCQkyTxNhZyzAvolXo/A==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=p3Hybbcu0AkdvJTjDJUA:9 a=QEXdDO2ut3YA:10 a=EyFUmsFV_t8cxB2kMr4A:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDEzMyBTYWx0ZWRfX+Nsa0qmpijgQ YNvhcQpons08ypS159uR60r2oIdSdpBIRhsem5vdxTGUDX8FztbQhclbv2aSbSX8AMWE3DBqmKX dnBTRk15IW8dl6mZCcUXWGPz0QExHOYLm8Ivm781JlKcRQeUM6kwUNNZd8toEd0hGYfGHoZEug0 Wmc6rfcZw/JFK1j6k3tik8qBRJDiyWUcxwqK6Bqg0F0TcTcf8WJkkyaWqqedt7LkSAqW+DYyCO1 Q6E8qNJu/U5sVbKmP3dffAQHtQTK2qtbjfTAqSKRb8snh0aw5K+9oYOhSi/DVNH6Zw/c/gAvrQU 4BQ6gVmhlUUkI3/cS4wvp0WgRMIc37OCAiFKT2pK+EuyQnZQPHTqavFsQehX2HYRtY/GCSWBU2Y F9/Gc262RWKsDnNTXEUvVI6J9pAMJB5TR2CktJr/YjCe0wbE3+I6YYNa5iOoubI7vHtKj7R6fwc +nXp6BH5KcCaNsi2peQ== X-Proofpoint-ORIG-GUID: _uorvJNmqUbBTIdcm0Lrs94ev-SGiQRr X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-06_01,2026-07-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 malwarescore=0 spamscore=0 adultscore=0 suspectscore=0 phishscore=0 bulkscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060133 On 7/6/26 10:53 AM, Praveen Talari wrote: > spi_geni_init() calls pm_runtime_get_sync() to power up the device > before accessing hardware registers, but never checks the return value. > If the runtime resume fails, the function silently proceeds to read and > write hardware registers on a device that may not be powered up, leading > to register access faults. > > Fix this by replacing pm_runtime_get_sync() with the > PM_RUNTIME_ACQUIRE_IF_ENABLED() macro and checking the result via > PM_RUNTIME_ACQUIRE_ERR(), propagating any error back to the caller > immediately before any hardware access occurs. > > Since the macro handles its own cleanup on failure, the out_pm label and > the corresponding pm_runtime_put() call are no longer needed. Replace > all goto out_pm paths with direct return ret statements and remove the > label entirely. > > Fixes: 561de45f72bd ("spi: spi-geni-qcom: Add SPI driver support for GENI based QUP") > Signed-off-by: Praveen Talari > --- Reviewed-by: Konrad Dybcio Konrad