From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f47.google.com (mail-io1-f47.google.com [209.85.166.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11567215764 for ; Fri, 20 Dec 2024 14:21:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734704466; cv=none; b=U9UK4f79/S4dp6BfvvqMVBdtfmP8SfXnQ+OcPtpighzC+obWqhPg5QNI1RlCVFJwqy0KgFfl30isNrJy8CNrBvmAaklOk51S/XJISrOiOkJizzqDdPM5ljLb2h0mHMMV/nom3NLvarNL4NNQ+NlbR+FKJCueqh+LAi/ey7txoj4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734704466; c=relaxed/simple; bh=ZmvORrp2lZZv9x8zCaTOLAkBhQDSjTLLRa6i8Pc30dg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=I3ov4CqGjH7pPwk8AJgS4rlv+bVsZFOhACyvbAjuNhoAjFIHS7DmN743+lk18T7c1URQJ7oMxUwvsi6qUOUU572/DFQDXyhu/v8AJwBPAymob28DBY1xyhH6wgGoCIStQeHPnVWzOz9WxCf2VSYdH5KINtNAGFY4mDzyBV7I3pY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=csTVOiXW; arc=none smtp.client-ip=209.85.166.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="csTVOiXW" Received: by mail-io1-f47.google.com with SMTP id ca18e2360f4ac-844e9b8b0b9so159139439f.0 for ; Fri, 20 Dec 2024 06:21:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1734704463; x=1735309263; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=31DzIQjE9S8zB8EihDSpAerIn7KsH/HS0eAgGru0OYk=; b=csTVOiXW2NZiyIi3cvIOvd8qx7uxqmmQbdkufGeFmqoRiTeMKpO7AXG99fKfopbfaa vsXCKBw75NryC0Fh6jEWSX2nrZPK8WrtO/6AAsnrJ1v7wB+SVy8YKeF5Zh60hsJ6AaUS Qd9eZg9jWAxjsE36xtTLllX4RMY/4s1DQ/NA17VM5HsHENrXsZNeVoQxOlvBFUtgkiVW wNeiAeGH+rhmkinzBZbunaQlQjMfLhvzrUWcwi6XBLG7hMcAXHLzASwZ3yKrs9UN2dXQ Fky/tCazmZytAeyTatSSP1e/Bce/TlYNlqZ3JL+azd02x1L1w7E3tZBYBaCl5afg5Krk j7lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734704463; x=1735309263; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=31DzIQjE9S8zB8EihDSpAerIn7KsH/HS0eAgGru0OYk=; b=iSFzBWq2VJGQd3A0vNS6LrmQHSeDjy1l+EvlV/OnhrEDGxpZBe+vpezSQ8+6cCKs83 malbI4ZhdL9ce1eevV2TZUV4fwUwlrLQyUUCOeKaTtzB3omcXBJN8Ssf8LQMhTDwB+AX aB9CReVfzzPakrvgJ1Y194+McrNhII/abTlOrvDWoXVRlGcdC2j9AAW7qFPVx0gLxtKA PgosrV5uBqus7ifQE+WNX499tyE/sNByFQTY2uYZ+NKe+UhQInQowyli5k2HUU1/xUV9 MO5Sw/4T9sbBh3PoVDnw5VhLHHLxOscZL7wTgSXd/rV5TktLNPRHRuQVV7BM/wKSDUa5 VNgg== X-Forwarded-Encrypted: i=1; AJvYcCXf2ZgH4MPHCzKsU4xAqCD0z3pnb1WBnTtPemNAdpfOuhkWyobAWD1vIcl9ZkAXgC3K1C0g3aunX/cvxhA=@vger.kernel.org X-Gm-Message-State: AOJu0YwwZv9pNUaoFTfXwfVl6jf4RRAL/v751CY/32W3Cz+8wLl/q7gh C3Yzoc+2n+rT0Cncc2l1zEWWOE4AfTO7AooBPmIBLaRYI4mJvDEfSsCoXR/tYr0= X-Gm-Gg: ASbGnctYAVW04m/6SAa8KT1bl9nDpSz3TVc7G2D8zfNEKUUrKd8LsVYr90i3b5kimoM PNw9sZLeJqtWk/E2AhkDlNEuhr9l2hgMAgrKbTO+GM6PjCsWAx+cTLJJcRhu8F2ZfksmCZKYJKv zuZVOwHgmcKfI10VzF3D+e4/RrvA0TFwq0xRgB4uvnFqW0mIBKcAWIxzN+Y3p/SuN2nA6vV0mUH admXpSlnBnKJqiCqxqTcC6sQDtFdUaFrv4xQ1+5/ixXiObAyuxz X-Google-Smtp-Source: AGHT+IEj0xCISBX0Tk5xDDbo9glyTwomym223EgEc8tW4cI6P2VS4z3kvPSV5qtUa4FmLA3Gwp08uw== X-Received: by 2002:a05:6e02:219c:b0:3a7:a2c6:e6d1 with SMTP id e9e14a558f8ab-3c2d5151ee6mr28309845ab.16.1734704461729; Fri, 20 Dec 2024 06:21:01 -0800 (PST) Received: from [192.168.1.116] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-3c0e3f3633esm8740715ab.59.2024.12.20.06.21.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Dec 2024 06:21:00 -0800 (PST) Message-ID: Date: Fri, 20 Dec 2024 07:21:00 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHSET v7 0/11] Uncached buffered IO To: "Kirill A. Shutemov" Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, hannes@cmpxchg.org, clm@meta.com, linux-kernel@vger.kernel.org, willy@infradead.org, bfoster@redhat.com References: <20241213155557.105419-1-axboe@kernel.dk> Content-Language: en-US From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/20/24 4:25 AM, Kirill A. Shutemov wrote: >> Since v6 >> - Rename the PG_uncached flag to PG_dropbehind >> - Shuffle patches around a bit, most notably so the foliop_uncached >> patch goes with the ext4 support >> - Get rid of foliop_uncached hack for btrfs (Christoph) >> - Get rid of passing in struct address_space to filemap_create_folio() >> - Inline invalidate_complete_folio2() in folio_unmap_invalidate() rather >> than keep it as a separate helper >> - Rebase on top of current master > > Hm. v6 had a patch that cleared the PG_uncached flag if the page accessed > via non-uncached lookup[1]. What happened to it? I don't see it here. > > https://lore.kernel.org/all/20241203153232.92224-14-axboe@kernel.dk Since I only needed these bits for the fs support, I didn't include it in this series. However, I did move it back to the core series for v8, it's this one: https://git.kernel.dk/cgit/linux/commit/?h=buffered-uncached.10&id=e4b7e8f693caf84021424ebafa139f38c5599db3 to avoid having a core dependency for the patches adding support to iomap and xfs/btrfs. I'll send out a new version with just slight tweaks today. So far it has the following changelog: - Rename filemap_uncached_read() to filemap_end_dropbehind_read() - Rename folio_end_dropbehind() to folio_end_dropbehind_write() - Make the "mm: add FGP_DONTCACHE folio creation flag" patch part of the base patches series, to avoid dependencies with btrfs/xfs/iomap - Remove now dead IOMAP_F_DONTCACHE define and setting on xfs/iomap where moving this patch back to teh core series is one of the entries. -- Jens Axboe