From: Krzysztof Kozlowski <krzk@kernel.org>
To: Brandon Brnich <b-brnich@ti.com>, linux-kernel@vger.kernel.org
Cc: Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
Tero Kristo <kristo@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Devarsh Thakkar <devarsht@ti.com>, Udit Kumar <u-kumar1@ti.com>,
Darren Etheridge <detheridge@ti.com>
Subject: Re: [PATCH v2] arm64: dts: ti: k3-j722s-main: Add E5010 JPEG Encoder
Date: Tue, 5 Aug 2025 08:02:55 +0200 [thread overview]
Message-ID: <b5ba5a22-dc0a-423b-963f-5db6c7e04665@kernel.org> (raw)
In-Reply-To: <20250804180106.2393256-1-b-brnich@ti.com>
On 04/08/2025 20:01, Brandon Brnich wrote:
> This adds node for E5010 JPEG Encoder which is a stateful JPEG Encoder
> present in J722s SoC, supporting baseline encoding of semiplanar based
> YUV420 and YUV422 raw video formats to JPEG encoding, with resolutions
> supported from 64x64 to 8kx8k.
>
> Signed-off-by: Brandon Brnich <b-brnich@ti.com>
> ---
>
> Changes in v2:
> - remove invalid clock-names attribute
>
> arch/arm64/boot/dts/ti/k3-j722s-main.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi b/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi
> index 5cfa7bf36641..fb24c14614b4 100644
> --- a/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi
> @@ -385,6 +385,16 @@ c7x_1: dsp@7e200000 {
> ti,sci-proc-ids = <0x31 0xff>;
> status = "disabled";
> };
> +
> + e5010: e5010@fd20000 {
Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> + compatible = "img,e5010-jpeg-enc";
Wrong compatible. This is TI, not IMG.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-08-05 6:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-04 18:01 Brandon Brnich
2025-08-05 4:56 ` devarsh
2025-08-05 6:02 ` Krzysztof Kozlowski [this message]
2025-08-05 13:34 ` Brandon Brnich
2025-08-05 14:05 ` Brandon Brnich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5ba5a22-dc0a-423b-963f-5db6c7e04665@kernel.org \
--to=krzk@kernel.org \
--cc=b-brnich@ti.com \
--cc=conor+dt@kernel.org \
--cc=detheridge@ti.com \
--cc=devarsht@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh@kernel.org \
--cc=u-kumar1@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®